mbox series

[RFC,0/5] fstests specific MAINTAINERS file

Message ID 20230404171411.699655-1-zlang@kernel.org
Headers show
Series fstests specific MAINTAINERS file | expand

Message

Zorro Lang April 4, 2023, 5:14 p.m. UTC 
I think I might be mad to include that many mailing lists in this patchset...

As I explained in [PATCH 1/5], fstests covers more and more fs testing
thing, so we always get help from fs specific mailing list, due to they
learn about their features and bugs more. Besides that, some folks help
to review patches (relevant with them) more often. So I'd like to bring
in the similar way of linux/MAINTAINERS, records fs relevant mailing lists,
reviewers or supporters (or call co-maintainers). To recognize the
contribution from them, and help more users to know who or what mailing list
can be added in CC list of a patch.

(The MAINTAINERS and get_maintainer.pl are copied from linux project,
then I made some changes for fstests specially.)

PATCH 3~5 are still under reviewing, hasn't been decided...

About [3/5], if someone mailing list doesn't want to be in cc list of related
fstests patch, please clarify, I'll remove.

About [4/5], if someone people doesn't want to be CCed, tell me, I'll remove.

About [5/5], need more reviewing from btrfs list.

If others fs which *always send patches to fstests@* and *hope to have a specific
co-maintainer* who can help more on your patches (to fststs) before merging, refer
to [5/5].

Thanks,
Zorro

Comments

Eric Biggers April 4, 2023, 10:16 p.m. UTC | #1 
Hi Zorro,

On Wed, Apr 05, 2023 at 01:14:09AM +0800, Zorro Lang wrote:
> +FSVERITY
> +L:	fsverity@lists.linux.dev
> +S:	Supported
> +F:	common/verity
> +
> +FSCRYPT
> +L:      linux-fscrypt@vger.kernel.org
> +S:	Supported
> +F:	common/encrypt

Most of the encrypt and verity tests are in tests/generic/ and are in the
'encrypt' or 'verity' test groups.

These file patterns only pick up the common files, not the actual tests.

Have you considered adding a way to specify maintainers for a test group?
Something like:

    G:      encrypt

and

    G:      verity

- Eric
Darrick J. Wong April 4, 2023, 11:21 p.m. UTC | #2 
On Wed, Apr 05, 2023 at 01:14:09AM +0800, Zorro Lang wrote:
> The fstests supports different kind of fs testing, better to cc
> specific fs mailing list for specific fs testing, to get better
> reviewing points. So record these mailing lists and files related
> with them in MAINTAINERS file.
> 
> Signed-off-by: Zorro Lang <zlang@kernel.org>
> ---
> 
> If someone mailing list doesn't want to be in cc list of related fstests
> patch, please reply this email, I'll remove that line.
> 
> Or if I missed someone mailing list, please feel free to tell me.
> 
> Thanks,
> Zorro
> 
>  MAINTAINERS | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 09b1a5a3..620368cb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -107,6 +107,83 @@ Maintainers List
>  	  should send patch to fstests@ at least. Other relevant mailing list
>  	  or reviewer or co-maintainer can be in cc list.
>  
> +BTRFS
> +L:	linux-btrfs@vger.kernel.org
> +S:	Supported
> +F:	tests/btrfs/
> +F:	common/btrfs
> +
> +CEPH
> +L:	ceph-devel@vger.kernel.org
> +S:	Supported
> +F:	tests/ceph/
> +F:	common/ceph
> +
> +CIFS
> +L:	linux-cifs@vger.kernel.org
> +S:	Supported
> +F:	tests/cifs
> +
> +EXT4
> +L:	linux-ext4@vger.kernel.org
> +S:	Supported
> +F:	tests/ext4/
> +F:	common/ext4
> +
> +F2FS
> +L:	linux-f2fs-devel@lists.sourceforge.net
> +S:	Supported
> +F:	tests/f2fs/
> +F:	common/f2fs
> +
> +FSVERITY
> +L:	fsverity@lists.linux.dev
> +S:	Supported
> +F:	common/verity
> +
> +FSCRYPT
> +L:      linux-fscrypt@vger.kernel.org
> +S:	Supported
> +F:	common/encrypt
> +
> +FS-IDMAPPED
> +L:	linux-fsdevel@vger.kernel.org
> +S:	Supported
> +F:	src/vfs/
> +
> +NFS
> +L:	linux-nfs@vger.kernel.org
> +S:	Supported
> +F:	tests/nfs/
> +F:	common/nfs
> +
> +OCFS2
> +L:	ocfs2-devel@oss.oracle.com
> +S:	Supported
> +F:	tests/ocfs2/
> +
> +OVERLAYFS
> +L:	linux-unionfs@vger.kernel.org
> +S:	Supported
> +F:	tests/overlay
> +F:	common/overlay
> +
> +UDF
> +R:	Jan Kara <jack@suse.com>
> +S:	Supported
> +F:	tests/udf/
> +
> +XFS
> +L:	linux-xfs@vger.kernel.org
> +S:	Supported
> +F:	common/dump
> +F:	common/fuzzy
> +F:	common/inject
> +F:	common/populate

note that populate and fuzzy apply to ext* as well.

> +F:	common/repair
> +F:	common/xfs
> +F:	tests/xfs/

Otherwise looks good to me,

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> +
>  ALL
>  M:	Zorro Lang <zlang@kernel.org>
>  L:	fstests@vger.kernel.org
> -- 
> 2.39.2
>
Darrick J. Wong April 4, 2023, 11:22 p.m. UTC | #3 
On Tue, Apr 04, 2023 at 03:16:53PM -0700, Eric Biggers wrote:
> Hi Zorro,
> 
> On Wed, Apr 05, 2023 at 01:14:09AM +0800, Zorro Lang wrote:
> > +FSVERITY
> > +L:	fsverity@lists.linux.dev
> > +S:	Supported
> > +F:	common/verity
> > +
> > +FSCRYPT
> > +L:      linux-fscrypt@vger.kernel.org
> > +S:	Supported
> > +F:	common/encrypt
> 
> Most of the encrypt and verity tests are in tests/generic/ and are in the
> 'encrypt' or 'verity' test groups.
> 
> These file patterns only pick up the common files, not the actual tests.
> 
> Have you considered adding a way to specify maintainers for a test group?
> Something like:
> 
>     G:      encrypt
> 
> and
> 
>     G:      verity

Yes, good suggestion.

--D

> - Eric
Darrick J. Wong April 4, 2023, 11:26 p.m. UTC | #4 
On Wed, Apr 05, 2023 at 01:14:11AM +0800, Zorro Lang wrote:
> Darrick J. Wong would like to nominate Anand Jain to help more on

In case anyone's wondering how this all came about -- Anand asked me how
he could do more upstream fstests review work, so I suggested that he
and I talk to Zorro about delegating some of the review and maintainer
work so that it's not all on Zorro to keep everything running.

> btrfs testing part (tests/btrfs and common/btrfs). He would like to
> be a co-maintainer of btrfs part, will help to review and test
> fstests btrfs related patches, and I might merge from him if there's
> big patchset. So CC him besides send to fstests@ list, when you have
> a btrfs fstests patch.
> 
> Signed-off-by: Zorro Lang <zlang@kernel.org>
> ---
> 
> Please btrfs list help to review this change, if you agree (or no objection),
> then I'll push this change.

This is what Zorro, Anand, and I sketched out as far as co-maintainer
resposibilities go:

> A co-maintainer will do:
> 1) Review patches are related with him.
> 2) Merge and test patches in his local git repo, and give the patch an ACK.
> 3) Maintainer will trust the ack from co-maintainer more (might merge directly).
> 4) Maintainer might merge from co-maintainer when he has a big patchset wait for
>    merging.
> 
> Thanks,
> Zorro
> 
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0ad12a38..9fc6c6b5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -108,6 +108,7 @@ Maintainers List
>  	  or reviewer or co-maintainer can be in cc list.
>  
>  BTRFS
> +M:	Anand Jain <anand.jain@oracle.com>

I would like to hear agreement from the btrfs community about this
before making this particular change official.

--D

>  R:	Filipe Manana <fdmanana@suse.com>
>  L:	linux-btrfs@vger.kernel.org
>  S:	Supported
> -- 
> 2.39.2
>
Steve French April 5, 2023, 4:04 a.m. UTC | #5 
Reviewed-by: Steven French <stfrench@microsoft.com>

On Tue, Apr 4, 2023 at 6:22 PM Darrick J. Wong <djwong@kernel.org> wrote:
>
> On Wed, Apr 05, 2023 at 01:14:09AM +0800, Zorro Lang wrote:
> > The fstests supports different kind of fs testing, better to cc
> > specific fs mailing list for specific fs testing, to get better
> > reviewing points. So record these mailing lists and files related
> > with them in MAINTAINERS file.
> >
> > Signed-off-by: Zorro Lang <zlang@kernel.org>
> > ---
> >
> > If someone mailing list doesn't want to be in cc list of related fstests
> > patch, please reply this email, I'll remove that line.
> >
> > Or if I missed someone mailing list, please feel free to tell me.
> >
> > Thanks,
> > Zorro
> >
> >  MAINTAINERS | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 77 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 09b1a5a3..620368cb 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -107,6 +107,83 @@ Maintainers List
> >         should send patch to fstests@ at least. Other relevant mailing list
> >         or reviewer or co-maintainer can be in cc list.
> >
> > +BTRFS
> > +L:   linux-btrfs@vger.kernel.org
> > +S:   Supported
> > +F:   tests/btrfs/
> > +F:   common/btrfs
> > +
> > +CEPH
> > +L:   ceph-devel@vger.kernel.org
> > +S:   Supported
> > +F:   tests/ceph/
> > +F:   common/ceph
> > +
> > +CIFS
> > +L:   linux-cifs@vger.kernel.org
> > +S:   Supported
> > +F:   tests/cifs
> > +
> > +EXT4
> > +L:   linux-ext4@vger.kernel.org
> > +S:   Supported
> > +F:   tests/ext4/
> > +F:   common/ext4
> > +
> > +F2FS
> > +L:   linux-f2fs-devel@lists.sourceforge.net
> > +S:   Supported
> > +F:   tests/f2fs/
> > +F:   common/f2fs
> > +
> > +FSVERITY
> > +L:   fsverity@lists.linux.dev
> > +S:   Supported
> > +F:   common/verity
> > +
> > +FSCRYPT
> > +L:      linux-fscrypt@vger.kernel.org
> > +S:   Supported
> > +F:   common/encrypt
> > +
> > +FS-IDMAPPED
> > +L:   linux-fsdevel@vger.kernel.org
> > +S:   Supported
> > +F:   src/vfs/
> > +
> > +NFS
> > +L:   linux-nfs@vger.kernel.org
> > +S:   Supported
> > +F:   tests/nfs/
> > +F:   common/nfs
> > +
> > +OCFS2
> > +L:   ocfs2-devel@oss.oracle.com
> > +S:   Supported
> > +F:   tests/ocfs2/
> > +
> > +OVERLAYFS
> > +L:   linux-unionfs@vger.kernel.org
> > +S:   Supported
> > +F:   tests/overlay
> > +F:   common/overlay
> > +
> > +UDF
> > +R:   Jan Kara <jack@suse.com>
> > +S:   Supported
> > +F:   tests/udf/
> > +
> > +XFS
> > +L:   linux-xfs@vger.kernel.org
> > +S:   Supported
> > +F:   common/dump
> > +F:   common/fuzzy
> > +F:   common/inject
> > +F:   common/populate
>
> note that populate and fuzzy apply to ext* as well.
>
> > +F:   common/repair
> > +F:   common/xfs
> > +F:   tests/xfs/
>
> Otherwise looks good to me,
>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
>
> --D
>
> > +
> >  ALL
> >  M:   Zorro Lang <zlang@kernel.org>
> >  L:   fstests@vger.kernel.org
> > --
> > 2.39.2
> >
Christian Brauner April 5, 2023, 7:49 a.m. UTC | #6 
On Wed, Apr 05, 2023 at 01:14:09AM +0800, Zorro Lang wrote:
> The fstests supports different kind of fs testing, better to cc
> specific fs mailing list for specific fs testing, to get better
> reviewing points. So record these mailing lists and files related
> with them in MAINTAINERS file.
> 
> Signed-off-by: Zorro Lang <zlang@kernel.org>
> ---
> 
> If someone mailing list doesn't want to be in cc list of related fstests
> patch, please reply this email, I'll remove that line.
> 
> Or if I missed someone mailing list, please feel free to tell me.
> 
> Thanks,
> Zorro
> 
>  MAINTAINERS | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 09b1a5a3..620368cb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -107,6 +107,83 @@ Maintainers List
>  	  should send patch to fstests@ at least. Other relevant mailing list
>  	  or reviewer or co-maintainer can be in cc list.
>  
> +BTRFS
> +L:	linux-btrfs@vger.kernel.org
> +S:	Supported
> +F:	tests/btrfs/
> +F:	common/btrfs
> +
> +CEPH
> +L:	ceph-devel@vger.kernel.org
> +S:	Supported
> +F:	tests/ceph/
> +F:	common/ceph
> +
> +CIFS
> +L:	linux-cifs@vger.kernel.org
> +S:	Supported
> +F:	tests/cifs
> +
> +EXT4
> +L:	linux-ext4@vger.kernel.org
> +S:	Supported
> +F:	tests/ext4/
> +F:	common/ext4
> +
> +F2FS
> +L:	linux-f2fs-devel@lists.sourceforge.net
> +S:	Supported
> +F:	tests/f2fs/
> +F:	common/f2fs
> +
> +FSVERITY
> +L:	fsverity@lists.linux.dev
> +S:	Supported
> +F:	common/verity
> +
> +FSCRYPT
> +L:      linux-fscrypt@vger.kernel.org
> +S:	Supported
> +F:	common/encrypt
> +
> +FS-IDMAPPED
> +L:	linux-fsdevel@vger.kernel.org
> +S:	Supported
> +F:	src/vfs/

Same suggestion as earlier, make that section VFS as it covers generic
functionality,

Acked-by: Christian Brauner <brauner@kernel.org>
Jan Kara April 5, 2023, 9:52 a.m. UTC | #7 
On Wed 05-04-23 01:14:09, Zorro Lang wrote:
> The fstests supports different kind of fs testing, better to cc
> specific fs mailing list for specific fs testing, to get better
> reviewing points. So record these mailing lists and files related
> with them in MAINTAINERS file.
> 
> Signed-off-by: Zorro Lang <zlang@kernel.org>
> ---

Looks good to me. Feel free to add:

Acked-by: Jan Kara <jack@suse.cz>

								Honza

> 
> If someone mailing list doesn't want to be in cc list of related fstests
> patch, please reply this email, I'll remove that line.
> 
> Or if I missed someone mailing list, please feel free to tell me.
> 
> Thanks,
> Zorro
> 
>  MAINTAINERS | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 09b1a5a3..620368cb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -107,6 +107,83 @@ Maintainers List
>  	  should send patch to fstests@ at least. Other relevant mailing list
>  	  or reviewer or co-maintainer can be in cc list.
>  
> +BTRFS
> +L:	linux-btrfs@vger.kernel.org
> +S:	Supported
> +F:	tests/btrfs/
> +F:	common/btrfs
> +
> +CEPH
> +L:	ceph-devel@vger.kernel.org
> +S:	Supported
> +F:	tests/ceph/
> +F:	common/ceph
> +
> +CIFS
> +L:	linux-cifs@vger.kernel.org
> +S:	Supported
> +F:	tests/cifs
> +
> +EXT4
> +L:	linux-ext4@vger.kernel.org
> +S:	Supported
> +F:	tests/ext4/
> +F:	common/ext4
> +
> +F2FS
> +L:	linux-f2fs-devel@lists.sourceforge.net
> +S:	Supported
> +F:	tests/f2fs/
> +F:	common/f2fs
> +
> +FSVERITY
> +L:	fsverity@lists.linux.dev
> +S:	Supported
> +F:	common/verity
> +
> +FSCRYPT
> +L:      linux-fscrypt@vger.kernel.org
> +S:	Supported
> +F:	common/encrypt
> +
> +FS-IDMAPPED
> +L:	linux-fsdevel@vger.kernel.org
> +S:	Supported
> +F:	src/vfs/
> +
> +NFS
> +L:	linux-nfs@vger.kernel.org
> +S:	Supported
> +F:	tests/nfs/
> +F:	common/nfs
> +
> +OCFS2
> +L:	ocfs2-devel@oss.oracle.com
> +S:	Supported
> +F:	tests/ocfs2/
> +
> +OVERLAYFS
> +L:	linux-unionfs@vger.kernel.org
> +S:	Supported
> +F:	tests/overlay
> +F:	common/overlay
> +
> +UDF
> +R:	Jan Kara <jack@suse.com>
> +S:	Supported
> +F:	tests/udf/
> +
> +XFS
> +L:	linux-xfs@vger.kernel.org
> +S:	Supported
> +F:	common/dump
> +F:	common/fuzzy
> +F:	common/inject
> +F:	common/populate
> +F:	common/repair
> +F:	common/xfs
> +F:	tests/xfs/
> +
>  ALL
>  M:	Zorro Lang <zlang@kernel.org>
>  L:	fstests@vger.kernel.org
> -- 
> 2.39.2
>
Zorro Lang April 5, 2023, 2:02 p.m. UTC | #8 
On Tue, Apr 04, 2023 at 03:16:53PM -0700, Eric Biggers wrote:
> Hi Zorro,
> 
> On Wed, Apr 05, 2023 at 01:14:09AM +0800, Zorro Lang wrote:
> > +FSVERITY
> > +L:	fsverity@lists.linux.dev
> > +S:	Supported
> > +F:	common/verity
> > +
> > +FSCRYPT
> > +L:      linux-fscrypt@vger.kernel.org
> > +S:	Supported
> > +F:	common/encrypt
> 
> Most of the encrypt and verity tests are in tests/generic/ and are in the
> 'encrypt' or 'verity' test groups.
> 
> These file patterns only pick up the common files, not the actual tests.
> 
> Have you considered adding a way to specify maintainers for a test group?
> Something like:
> 
>     G:      encrypt
> 
> and
> 
>     G:      verity

Good idea! Let's check if this patchset is acceptable by most of you,
then I'll think about how to add this feature later.

Thanks,
Zorro

> 
> - Eric
>
Xiubo Li April 6, 2023, 12:25 a.m. UTC | #9 
On 4/5/23 01:14, Zorro Lang wrote:
> The fstests supports different kind of fs testing, better to cc
> specific fs mailing list for specific fs testing, to get better
> reviewing points. So record these mailing lists and files related
> with them in MAINTAINERS file.
>
> Signed-off-by: Zorro Lang <zlang@kernel.org>
> ---
>
> If someone mailing list doesn't want to be in cc list of related fstests
> patch, please reply this email, I'll remove that line.
>
> Or if I missed someone mailing list, please feel free to tell me.
>
> Thanks,
> Zorro
>
>   MAINTAINERS | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 77 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 09b1a5a3..620368cb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -107,6 +107,83 @@ Maintainers List
>   	  should send patch to fstests@ at least. Other relevant mailing list
>   	  or reviewer or co-maintainer can be in cc list.
>   
> +BTRFS
> +L:	linux-btrfs@vger.kernel.org
> +S:	Supported
> +F:	tests/btrfs/
> +F:	common/btrfs
> +
> +CEPH
> +L:	ceph-devel@vger.kernel.org
> +S:	Supported
> +F:	tests/ceph/
> +F:	common/ceph
> +

LGTM and feel free to add:

Acked-by: Xiubo Li <xiubli@redhat.com>

Thanks,

- Xiubo
Chao Yu April 6, 2023, 1:53 a.m. UTC | #10 
On 2023/4/5 1:14, Zorro Lang wrote:
> +F2FS
> +L:	linux-f2fs-devel@lists.sourceforge.net
> +S:	Supported
> +F:	tests/f2fs/
> +F:	common/f2fs

Acked-by: Chao Yu <chao@kernel.org>

Thanks,
David Sterba April 6, 2023, 2:17 p.m. UTC | #11 
On Wed, Apr 05, 2023 at 01:14:11AM +0800, Zorro Lang wrote:
> Darrick J. Wong would like to nominate Anand Jain to help more on
> btrfs testing part (tests/btrfs and common/btrfs). He would like to
> be a co-maintainer of btrfs part, will help to review and test
> fstests btrfs related patches, and I might merge from him if there's
> big patchset. So CC him besides send to fstests@ list, when you have
> a btrfs fstests patch.
> 
> Signed-off-by: Zorro Lang <zlang@kernel.org>
> ---
> 
> Please btrfs list help to review this change, if you agree (or no objection),
> then I'll push this change.
> 
> A co-maintainer will do:
> 1) Review patches are related with him.
> 2) Merge and test patches in his local git repo, and give the patch an ACK.
> 3) Maintainer will trust the ack from co-maintainer more (might merge directly).
> 4) Maintainer might merge from co-maintainer when he has a big patchset wait for
>    merging.
> 
> Thanks,
> Zorro
> 
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0ad12a38..9fc6c6b5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -108,6 +108,7 @@ Maintainers List
>  	  or reviewer or co-maintainer can be in cc list.
>  
>  BTRFS
> +M:	Anand Jain <anand.jain@oracle.com>

Acked-by: David Sterba <dsterba@suse.com>
John Hubbard April 6, 2023, 8:10 p.m. UTC | #12 
On 4/4/23 10:14, Zorro Lang wrote:
> As fstests covers more and more fs testing, so we always get help
> from fs specific mailing list, due to they learn about their features
> and bugs more. Besides that, some folks help to review patches
> (relevant with them) more often.
> 
> So I'd like to bring in the similar way of linux/MAINTAINERS, records
> fs relevant mailing lists, reviewers or co-maintainers. To recognize
> the contribution from them, and help more users to know who or what
> mailing list can be added in CC list of a patch.
> 
> The MAINTAINERS and get_maintainer.pl are copied from linux project,
> then made some changes for fstests specially.

Hi Zorro,

Instead of forking 23,000+ lines of MAINTAINERS and 2600+ lines of
script into a strange tools/ location ("tools/" would then mean fstests,
and "scripts/" would mean "everything else), this upgrade really should
simply be done in place.

I don't see much in the following patches that *truly* requires forking
these files. And if you fix them up in place, then more people will be
able to find the fstests maintainers easily, too.

thanks,