mbox series

[0/5] netfs, cachefiles, 9p: Additional patches

Message ID 20240103145935.384404-1-dhowells@redhat.com
Headers show
Series netfs, cachefiles, 9p: Additional patches | expand

Message

David Howells Jan. 3, 2024, 2:59 p.m. UTC
Hi Christian, Jeff, Gao, Dominique,

Here are some additional patches for my netfs-lib tree:

 (1) Fix __cachefiles_prepare_write() to correctly validate against the DIO
     alignment.

 (2) 9p: Fix initialisation of the netfs_inode so that i_size is set before
     netfs_inode_init() is called.

 (3) 9p: Do a couple of cleanups (remove a couple of unused vars and turn a
     BUG_ON() into a warning).

 (4) 9p: Always update remote_i_size, even if we're asked not to update
     i_size in stat2inode.

 (5) 9p: Return the amount written in preference to an error if we wrote
     something.

David

The netfslib postings:
Link: https://lore.kernel.org/r/20231013160423.2218093-1-dhowells@redhat.com/ # v1
Link: https://lore.kernel.org/r/20231117211544.1740466-1-dhowells@redhat.com/ # v2
Link: https://lore.kernel.org/r/20231207212206.1379128-1-dhowells@redhat.com/ # v3
Link: https://lore.kernel.org/r/20231213152350.431591-1-dhowells@redhat.com/ # v4
Link: https://lore.kernel.org/r/20231221132400.1601991-1-dhowells@redhat.com/ # v5

David Howells (5):
  cachefiles: Fix __cachefiles_prepare_write()
  9p: Fix initialisation of netfs_inode for 9p
  9p: Do a couple of cleanups
  9p: Always update remote_i_size in stat2inode
  9p: Use length of data written to the server in preference to error

 fs/9p/v9fs_vfs.h       |  1 +
 fs/9p/vfs_addr.c       | 24 ++++++++++++------------
 fs/9p/vfs_inode.c      |  6 +++---
 fs/9p/vfs_inode_dotl.c |  7 ++++---
 fs/cachefiles/io.c     | 28 +++++++++++++++++-----------
 5 files changed, 37 insertions(+), 29 deletions(-)

Comments

Dominique Martinet Jan. 3, 2024, 7:45 p.m. UTC | #1
David Howells wrote on Wed, Jan 03, 2024 at 02:59:27PM +0000:
> Do a couple of cleanups to 9p:
> 
>  (1) Remove a couple of unused variables.
> 
>  (2) Turn a BUG_ON() into a warning, consolidate with another warning and
>      make the warning message include the inode number rather than
>      whatever's in i_private (which will get hashed anyway).
> 
> Suggested-by: Dominique Martinet <asmadeus@codewreck.org>

Thanks,

Acked-by: Dominique Martinet <asmadeus@codewreck.org>
Christian Brauner Jan. 5, 2024, 10:33 a.m. UTC | #2
On Wed, Jan 03, 2024 at 02:59:24PM +0000, David Howells wrote:
> Hi Christian, Jeff, Gao, Dominique,
> 
> Here are some additional patches for my netfs-lib tree:
> 
>  (1) Fix __cachefiles_prepare_write() to correctly validate against the DIO
>      alignment.
> 
>  (2) 9p: Fix initialisation of the netfs_inode so that i_size is set before
>      netfs_inode_init() is called.
> 
>  (3) 9p: Do a couple of cleanups (remove a couple of unused vars and turn a
>      BUG_ON() into a warning).
> 
>  (4) 9p: Always update remote_i_size, even if we're asked not to update
>      i_size in stat2inode.
> 
>  (5) 9p: Return the amount written in preference to an error if we wrote
>      something.
> 
> David
> 
> The netfslib postings:
> Link: https://lore.kernel.org/r/20231013160423.2218093-1-dhowells@redhat.com/ # v1
> Link: https://lore.kernel.org/r/20231117211544.1740466-1-dhowells@redhat.com/ # v2
> Link: https://lore.kernel.org/r/20231207212206.1379128-1-dhowells@redhat.com/ # v3
> Link: https://lore.kernel.org/r/20231213152350.431591-1-dhowells@redhat.com/ # v4
> Link: https://lore.kernel.org/r/20231221132400.1601991-1-dhowells@redhat.com/ # v5

Pulled this into vfs.netfs. Thanks, David.