From patchwork Fri Jun 28 16:35:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honnappa Nagarahalli X-Patchwork-Id: 168107 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3910645ilk; Fri, 28 Jun 2019 09:36:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqzc3AdzLyjWRBmVqdi+lcy4oeQNtrzyrPchuZEBFQahufO70MxnQn0Etr42laDdF9AznBxu X-Received: by 2002:a5d:4302:: with SMTP id h2mr7764772wrq.137.1561739768866; Fri, 28 Jun 2019 09:36:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561739768; cv=none; d=google.com; s=arc-20160816; b=hv9k+rcav+siGdZRzHJ88FgVI0xqopE/sTJnEJ2PEkE6Mid5u/tDpUaNMP3CbqyCg+ j8Cl3J2klLY8FVvrA2eWTr0EMW+orBpeAIDFlcTlakNAdLuQPEyygH85PFN/s9ApWk8+ uI2J6FwGCkAkjJva+KH8tN3n3nV0iZiAzDtWBWscWy4NAU+0oHh76G9Q5708ednscVjM aSqaLR2rpo9YTf/BHf/M5KtsIqw6YdlpjzdP/BlpEdw4jcdzQOhmeQuIKhCTE4nwAagH 8Did4KBasSdlNcOBAhMrTin0jQZUG3IGF3XJsOmHT3ZlcD4FKsq9Ob2WyaXAoD0mrjTv HhnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=yNlK4nj1qjgpWKBS/rGlOu+mfIrVcZAfPbi/4ZzZMoE=; b=sCMQT5E6jXmTeq2tygW/I87gbtq3389GA3llsHqE+YRN5Zs2/opOO0e5u8O+QgVbFV C2APBg3VpzwGaQExZXS3MlLMwe0k+AFWwtIDLohA1jUxFOuSHU914VDoGvaU8pDyKwt+ DCbp/dIWncwTO8mU91hC8q299AVVUYnMpwuW6IWmaHUAl8KzhuVrP+1E+TsDHyVAoCyl cI4Q1wM0YjyVEKBb8RVHFA8VZ1A9NzIDXMfhhD8upefQ0De4W//y70IJWahdG2bh7xQ6 DmePBhiGB58ErEu7kTWvR0NW1HZ6wS8dKqvcmVr7D9C/gfj0G5Yk9tqtgZiI85Y6ZtY+ MYcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id l9si1842931wmg.32.2019.06.28.09.36.08; Fri, 28 Jun 2019 09:36:08 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F3DC35398; Fri, 28 Jun 2019 18:36:00 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id E79544C6C; Fri, 28 Jun 2019 18:35:57 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 56B8CEBD; Fri, 28 Jun 2019 09:35:57 -0700 (PDT) Received: from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com [10.118.12.65]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 44DF43F706; Fri, 28 Jun 2019 09:35:57 -0700 (PDT) From: Honnappa Nagarahalli To: honnappa.nagarahalli@arm.com Cc: dev@dpdk.org, david.marchand@redhat.com, thomas@monjalon.net, ferruh.yigit@intel.com, ruifeng.wang@arm.com, nd@arm.com, stable@dpdk.org Date: Fri, 28 Jun 2019 11:35:49 -0500 Message-Id: <20190628163549.29160-2-honnappa.nagarahalli@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190628163549.29160-1-honnappa.nagarahalli@arm.com> References: <20190628034406.5399-1-honnappa.nagarahalli@arm.com> <20190628163549.29160-1-honnappa.nagarahalli@arm.com> Subject: [dpdk-dev] [PATCH v2 2/2] test/rcu: address test case failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Test case for rte_rcu_qsbr_get_memsize is written specifically for 128 threads. Do not use RTE_MAX_LCORE as it changes for different configurations. Fixes: e6a14121f4ae ("test/rcu: remove arbitrary limit on max core count") Cc: stable@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang Reviewed-by: David Marchand --- v2 - Changed the test case result validation (David) app/test/test_rcu_qsbr.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 2.17.1 diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index ae359a987..1d273e39d 100644 --- a/app/test/test_rcu_qsbr.c +++ b/app/test/test_rcu_qsbr.c @@ -89,13 +89,17 @@ test_rcu_qsbr_get_memsize(void) sz = rte_rcu_qsbr_get_memsize(0); TEST_RCU_QSBR_RETURN_IF_ERROR((sz != 1), "Get Memsize for 0 threads"); - sz = rte_rcu_qsbr_get_memsize(RTE_MAX_LCORE); + sz = rte_rcu_qsbr_get_memsize(128); /* For 128 threads, * for machines with cache line size of 64B - 8384 * for machines with cache line size of 128 - 16768 */ - TEST_RCU_QSBR_RETURN_IF_ERROR((sz != 8384 && sz != 16768), - "Get Memsize"); + if (RTE_CACHE_LINE_SIZE == 64) + TEST_RCU_QSBR_RETURN_IF_ERROR((sz != 8384), + "Get Memsize for 128 threads"); + else if (RTE_CACHE_LINE_SIZE == 128) + TEST_RCU_QSBR_RETURN_IF_ERROR((sz != 16768), + "Get Memsize for 128 threads"); return 0; }