| Message ID | cover.1524727887.git.jsarha@ti.com |
|---|---|
| Headers | show |
| Series | drm/panel: Add device link in drm_panel_attach() | expand |
On Thu, Apr 26, 2018 at 11:06:58AM +0300, Jyri Sarha wrote: > I guess the first patch should be mergable. With the second, maybe it > is better to wait until we have a full solution including the bridges > too. What should I do to get the first patch merged? I don't see a reason why patch 2 can't be applied as-is right now. The bridges can always be fixed in a separate patch. Applied both of these to drm-misc-next, thanks. Thierry
On 2018-04-26 14:49, Thierry Reding wrote: > On Thu, Apr 26, 2018 at 11:06:58AM +0300, Jyri Sarha wrote: >> I guess the first patch should be mergable. With the second, maybe it >> is better to wait until we have a full solution including the bridges >> too. What should I do to get the first patch merged? > > I don't see a reason why patch 2 can't be applied as-is right now. The > bridges can always be fixed in a separate patch. > > Applied both of these to drm-misc-next, thanks. Hmm, so why have they not (yet?) landed in linux-next.git? It's been almost a month... Cheers, Peter
I guess the first patch should be mergable. With the second, maybe it is better to wait until we have a full solution including the bridges too. What should I do to get the first patch merged? The third version of these patches can be found here: https://lists.freedesktop.org/archives/dri-devel/2018-April/174221.html Changes since v3: - "drm/panel: Remove drm_panel_detach() calls from all panel drives" - Update kerneldoc for drm_panel_detach() and drm_panel_attach() according to Daniel Vetter's suugestion and add his reviewed-by. - "drm/panel: Add device_link from panel device to drm device" - none The first patch could be squashed to second, but kept is separate since I think it is correct even without the second patch. With these patches unbinding a panel driver in use does not cause nasty backtraces and corrupted drm core structures, but instead it cleanly unbinds the drm master device at the same time. The only down side (currently[1]) is that the drm device does not reprobe if the panel driver is bound again, but everything should work if the drm master driver is bound manually. Best regards, Jyri Jyri Sarha (2): drm/panel: Remove drm_panel_detach() calls from all panel drives drm/panel: Add device_link from panel device to drm device drivers/gpu/drm/drm_panel.c | 16 ++++++++++++++++ drivers/gpu/drm/panel/panel-innolux-p079zca.c | 1 - drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 1 - drivers/gpu/drm/panel/panel-lvds.c | 1 - drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 1 - drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 1 - drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 1 - drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 1 - drivers/gpu/drm/panel/panel-simple.c | 1 - drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 1 - include/drm/drm_panel.h | 1 + 11 files changed, 17 insertions(+), 9 deletions(-)