From patchwork Mon Dec 24 08:33:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 13692 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 00C1023EC8 for ; Mon, 24 Dec 2012 08:42:33 +0000 (UTC) Received: from mail-vc0-f170.google.com (mail-vc0-f170.google.com [209.85.220.170]) by fiordland.canonical.com (Postfix) with ESMTP id AF493A18DDD for ; Mon, 24 Dec 2012 08:42:32 +0000 (UTC) Received: by mail-vc0-f170.google.com with SMTP id fl11so7253747vcb.15 for ; Mon, 24 Dec 2012 00:42:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=AkGtino4wvXhy/1eCXVmbnHNkepxp9XWg+4DOgvY7Yo=; b=S9yccbXzEdvUG9DDRCMyoncHD2Wdh/PeuiovnMxVgQSELs33W2Vr+rbyeSNjHqiFTK kXEuU04PH9wnFruovQ5IBvhEcSYfmRXu/7CRSb1shPmEO2meEfQfiehNICLOVsoIg+yr Mw+q+eHoh7hTy7RHwg70DXzdnyoGMG1LetaD7pbWrbli8ht3vUxKrLEJRI74JgXIH2Fa 07v7W1WVgiueHcseTEIt+xjeYE0F+ogF6aDQW5d83TeqbeQVreJXHMtlRJXUBnI5tPux mcSq1cXebNWw3XqMqf1gzLYIkJ+9j9HLwEaWIB0rhxaOGxWhRfHc03hPft34GR1KER7U 6JIw== X-Received: by 10.52.18.207 with SMTP id y15mr27607694vdd.8.1356338552200; Mon, 24 Dec 2012 00:42:32 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.49.133 with SMTP id u5csp184125ven; Mon, 24 Dec 2012 00:42:31 -0800 (PST) X-Received: by 10.68.190.38 with SMTP id gn6mr65711975pbc.6.1356338551331; Mon, 24 Dec 2012 00:42:31 -0800 (PST) Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by mx.google.com with ESMTPS id rr6si19754243pbc.191.2012.12.24.00.42.31 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Dec 2012 00:42:31 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.53 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.220.53; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.53 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pa0-f53.google.com with SMTP id hz1so3969360pad.40 for ; Mon, 24 Dec 2012 00:42:31 -0800 (PST) X-Received: by 10.66.85.103 with SMTP id g7mr61215563paz.45.1356338550969; Mon, 24 Dec 2012 00:42:30 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id pv8sm11959096pbc.26.2012.12.24.00.42.28 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Dec 2012 00:42:30 -0800 (PST) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Cc: inki.dae@samsung.com, sachin.kamat@linaro.org, patches@linaro.org, airlied@linux.ie, Eunchul Kim Subject: [PATCH 09/10] drm/exynos: Remove redundant NULL check in exynos_drm_gsc.c Date: Mon, 24 Dec 2012 14:03:50 +0530 Message-Id: <1356338031-23674-10-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1356338031-23674-1-git-send-email-sachin.kamat@linaro.org> References: <1356338031-23674-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQkSIXvjfnG6CsVxDqMZzvuU3Ca15Iak1o5kZYbTXCfQFYk+jmyERFJerm0ECkFL8rgsD5XK devm_request_and_ioremap API checks for NULL. Hence explicit NULL check is not necessary. Saves some code. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c index 3b47a7d..e21a0d9 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c @@ -1704,12 +1704,6 @@ static int __devinit gsc_probe(struct platform_device *pdev) /* resource memory */ ctx->regs_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!ctx->regs_res) { - dev_err(dev, "failed to find registers.\n"); - ret = -ENOENT; - goto err_clk; - } - ctx->regs = devm_request_and_ioremap(dev, ctx->regs_res); if (!ctx->regs) { dev_err(dev, "failed to map registers.\n");