From patchwork Fri Aug 30 09:10:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 19627 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f69.google.com (mail-qa0-f69.google.com [209.85.216.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 1749724694 for ; Fri, 30 Aug 2013 09:28:31 +0000 (UTC) Received: by mail-qa0-f69.google.com with SMTP id w8sf2163276qac.4 for ; Fri, 30 Aug 2013 02:28:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:x-gm-message-state:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=wA9hTrKbRiKgQsIFKoULWBFcFTYoK0A2pKoiIP/OhEA=; b=jFEUPOSQSA/aE/7nNHhlSDbSZ9fyAUlXiS0B0BvhRBsj58uK+llvhaSUBaUxiJbdWH fzYcCOYj/nZIrXy8m//REdD6oeLcXvixJrqjKTjuxxbh+UDyvvwnymOPpRylAOgweCqa WsreYOIH16UGw5EX3Amp3dKyssYBdDkvSKG7PkGBkgpzpaW6te1mCqs+rInFM9Bdkh72 i4YOoeuyBokucV+KgZawyGVX5UVvEqVi/2UhhM3LybZfKL255eUmma7USRYzDZP2r1p3 CwStqM43uIHUjtph8m9WQ7bCKuTqQmytHhO1xFLQDtm/06qKneevcHoZOgPjF7bCAftR 3RVw== X-Received: by 10.236.140.130 with SMTP id e2mr2767038yhj.10.1377854910499; Fri, 30 Aug 2013 02:28:30 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.0.41 with SMTP id 9ls1181679qeb.15.gmail; Fri, 30 Aug 2013 02:28:30 -0700 (PDT) X-Received: by 10.52.164.102 with SMTP id yp6mr5747732vdb.14.1377854910353; Fri, 30 Aug 2013 02:28:30 -0700 (PDT) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by mx.google.com with ESMTPS id w4si780667vdo.104.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 30 Aug 2013 02:28:30 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.174; Received: by mail-vc0-f174.google.com with SMTP id gd11so1116769vcb.5 for ; Fri, 30 Aug 2013 02:28:30 -0700 (PDT) X-Gm-Message-State: ALoCoQnQvgsbQpU52S2mXK5pDW5sBJrpc3Azy3Qfz/Md1I1qpPn2+JUNyiOPjsP7uW2B+zWnZ/Ly X-Received: by 10.52.101.166 with SMTP id fh6mr4740249vdb.30.1377854910251; Fri, 30 Aug 2013 02:28:30 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp77749vcz; Fri, 30 Aug 2013 02:28:29 -0700 (PDT) X-Received: by 10.68.255.69 with SMTP id ao5mr8837687pbd.66.1377854909152; Fri, 30 Aug 2013 02:28:29 -0700 (PDT) Received: from mail-pb0-f49.google.com (mail-pb0-f49.google.com [209.85.160.49]) by mx.google.com with ESMTPS id dz4si7617617pbc.149.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 30 Aug 2013 02:28:29 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.49 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.49; Received: by mail-pb0-f49.google.com with SMTP id xb4so1625503pbc.8 for ; Fri, 30 Aug 2013 02:28:28 -0700 (PDT) X-Received: by 10.66.145.166 with SMTP id sv6mr9461512pab.31.1377854908590; Fri, 30 Aug 2013 02:28:28 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id kd1sm46549501pab.20.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 30 Aug 2013 02:28:27 -0700 (PDT) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Cc: inki.dae@samsung.com, sachin.kamat@linaro.org, patches@linaro.org, Andrzej Hajda Subject: [PATCH 1/1] drm/exynos: Fix build error with exynos_drm_connector.c Date: Fri, 30 Aug 2013 14:40:51 +0530 Message-Id: <1377853851-32636-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , exynos_drm_connector.c now uses videomode helper API. Hence select VIDEOMODE_HELPERS at DRM_EXYNOS level itself instead of at DRM_EXYNOS_FIMD to avoid the following compilation error when FIMD is not selected (introduced by commit cf796235a6 "drm/exynos: fimd: replace struct fb_videomode with videomode"): drivers/built-in.o: In function `exynos_drm_connector_get_modes': drivers/gpu/drm/exynos/exynos_drm_connector.c:86: undefined reference to `drm_display_mode_from_videomode' Signed-off-by: Sachin Kamat Cc: Andrzej Hajda --- drivers/gpu/drm/exynos/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index 80a251a..4752f22 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/drm/exynos/Kconfig @@ -6,6 +6,7 @@ config DRM_EXYNOS select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE + select VIDEOMODE_HELPERS help Choose this option if you have a Samsung SoC EXYNOS chipset. If M is selected the module will be called exynosdrm. @@ -26,7 +27,6 @@ config DRM_EXYNOS_FIMD bool "Exynos DRM FIMD" depends on DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM select FB_MODE_HELPERS - select VIDEOMODE_HELPERS help Choose this option if you want to use Exynos FIMD for DRM.