From patchwork Tue May 28 08:27:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 165256 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp8169295ili; Tue, 28 May 2019 01:29:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqz/VV7mV4BUMUTKHPA15f4wSJXR+Yw3mZRIQNBGU507A8PvZfKQrF0Vv5fcAHTEdHblHhga X-Received: by 2002:a63:4346:: with SMTP id q67mr130433486pga.241.1559032142901; Tue, 28 May 2019 01:29:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559032142; cv=none; d=google.com; s=arc-20160816; b=O0F8jCHrtZ/NW42z2IMk+ZYDlwuVamGuBurVqbnCZIsI9d5JKSEVMwY/Wz2XOTQhc9 ADtpnw1woysJsTiI94TDsc/FMXh7AgEq9+IpzbFit/cZvrFQvnyhBDuBKaHb3DN3dmhz EBqLKrTsiBZxwdvBUZteTdiogVYGyEg03cHpyW0xO0YCnib9xMpmBH3nXlI5/dh26SPL nQnnTZo5VTBdD2+MHko81Muk85mcub/XsTQkyONKa8eJH7U0qts7Bpj4farCeMqf06Zl O0Bz14WED6mzLoIg2lc8/rsHF3xp3f7YpYILEKw+WmH/z/8eSd7tbz2XLmOdLd+cb/PC Isyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=l78rFxcGDlL6kd7ReXuWlKi3R32RoGnBwaZ9jNaGrgU=; b=rh03XNDekf3IjNc8GU2l6HjuVJfOE+CM5mAww0/69IrBPry1vuT/Z25XBQKiu0DQ24 rTNx1xdsu8WHNCGZQTa/eSf2xTxSq14sK4MhT5e4WU8cIwNUxyBD710aUSpzg6jh6uab BJwG0zxYzDvkxK97LxdN4Vktm9LhqsAQhSU6ywtyKwyY/tELDFexYDsyFwHKDKn0vUKc MtMCfTVk3+IgSqA0XmHiXEmqYrZgQHln4hsro7C+3KoqaC94zqUOegN7YChPx83swj/2 aMTr34avjHXznlZDmQ6a0ZvRgFLt3zA4ZGUiXpJ2grMe6N2tuW5jc8/dJFqmBRaGL45U 3PQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id p3si9900449plq.78.2019.05.28.01.29.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2019 01:29:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CF4E889C6E; Tue, 28 May 2019 08:28:55 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E76E89D02 for ; Tue, 28 May 2019 08:28:49 +0000 (UTC) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x4S8Sjqb032200; Tue, 28 May 2019 03:28:45 -0500 Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x4S8SjAl115148 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 28 May 2019 03:28:45 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 28 May 2019 03:28:44 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 28 May 2019 03:28:45 -0500 Received: from deskari.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x4S8Rxul125039; Tue, 28 May 2019 03:28:42 -0500 From: Tomi Valkeinen To: , Andrzej Hajda , Laurent Pinchart , Lucas Stach , Andrey Gusakov , Philipp Zabel , Andrey Smirnov , Peter Ujfalusi , Jyri Sarha , Benoit Parrot Subject: [PATCHv4 17/24] drm/bridge: tc358767: remove check for video mode in link enable Date: Tue, 28 May 2019 11:27:40 +0300 Message-ID: <20190528082747.3631-18-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190528082747.3631-1-tomi.valkeinen@ti.com> References: <20190528082747.3631-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1559032125; bh=37aqo7tEqJe/Zc3BOPvR4eqVx2flaYd7SUmzoNetNZ4=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=ZfW+Nry7PMfQEN5tKQU/xk1p7qGp4hfKsmEC+CQtZj+jB60Cf8row0GS5dvjLRVT6 cXeDzBdDbjRN5iJUXqpaYBrc0sod+4ps7ekH1SzGG5yZ3RhpgT0E9rNwe01yJ/aN+d P9VgEKiZCjwC/12TlxWlWSOuPWTKixfh3VtjH3dw= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" tc_main_link_enable() checks if videomode has been set, and fails if there's no videomode. As tc_main_link_enable() no longer depends on the videomode, we can drop the check. Also, while tc_stream_enable() does depend on the videomode, we can expect that a mode has been set before drm_bridge_funcs.enable is called, so we don't need the check there either. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 10a9b46de5f1..604e54b90b79 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -773,10 +773,6 @@ static int tc_main_link_enable(struct tc_data *tc) int ret; u8 tmp[8]; - /* display mode should be set at this point */ - if (!tc->mode) - return -EINVAL; - dev_dbg(tc->dev, "link enable\n"); tc_read(DP0CTL, &value);