From patchwork Mon Aug 31 13:02:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Semwal X-Patchwork-Id: 248740 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp3299759ilg; Mon, 31 Aug 2020 06:03:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFqgzQv+Z8vT1W4T2FYXJcI/loVDHFn6lqEdL4pTwmp3r+IHJh5wOpOauK8dKEE9sIaOD/ X-Received: by 2002:a63:f804:: with SMTP id n4mr1100040pgh.155.1598878996537; Mon, 31 Aug 2020 06:03:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598878996; cv=none; d=google.com; s=arc-20160816; b=YP0p4YJh6djrxnUcbt/LP3lgbku//g52RODp4OxvRuA60h3FU4SQ9InQfl2gYj93CP rFu284HSkAV6zHmh9m/fDdDypqRuqQ/gzxXoySOauUbXe8T4qLVCQr4dg1dyeiGNHqt0 3pgkU0qBBTAlDv2gouXCJer8OfwMt0Ofwnk3l9JuzuDJ+xOpZXLKo04u8KEKOPs8EOMl pj3oGt5QBpfgZwet+jtumsfOxzx0uVkQYRND3MgPcb5w1Cg2OBy/KEz1aADxGXa56IZ6 TUzaKPV2/WbKwI/n48hhPjDN/sKKCM4/zhzkxy8QRoDjCQbq6Z+4FrRcYvQI3OHNYCkD qh2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=BQAyPt2gMVQBHPweIqZtOcdv5TsmP2fS41Ht9sGoiSc=; b=0yqIhsnogvrtb9nMicbOb63zELFUcsYfEYJP2apU9wf3iWs/Lgq/1R7FTO4IjaLyF1 qOd3f9615KrhgytvMU1WnYOCOCBF5U5nH01FQlYrm1iavg7uAnjrKIjbyRFvKItWAfeE pS3GvSJVaEs0Ge2Ie5sGGacGfq3mXvtrZPFF/kVHg9Z4SNDacNdNahqhTCA1eHLGLEgw uhT9ZnDH+g+5GvJ1N1EqWFBUbJlIroJPSyyhiWR28vCom0BBoYQejm/t8vZItvPhjmoB n4Fi3LNGOYlYcAdlqWxNtaDBgS3vbChS67Nk+I3EWPG4xhlNijq4J9JvFWvbRlJccRsa f/tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=JlFI0aBJ; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id w2si5811253pgt.202.2020.08.31.06.03.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2020 06:03:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=JlFI0aBJ; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E0216E258; Mon, 31 Aug 2020 13:03:15 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by gabe.freedesktop.org (Postfix) with ESMTPS id 585FF6E258 for ; Mon, 31 Aug 2020 13:03:13 +0000 (UTC) Received: by mail-pj1-x1043.google.com with SMTP id 2so3102254pjx.5 for ; Mon, 31 Aug 2020 06:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+LHPvergv9JOkc07dMLH/z6MgF4Iu1IXQz+MYRIw4ms=; b=JlFI0aBJMRV0V6ERyv/Umtpl9BgCfore/uqnaZiTtFqkjNpv6g4rQcb5axrwGg78aX 6fpYcc+CMqbmJ6XTs21M4chGSxO02Y5HMzAhEyTZ+bNGkIrklrGcyYNmYhTteZld1cAn OKL4JuC60JL1HvCK40q0ebzZU0mHzugKBPjBwk91D5JYCFSTWgpfR7uQ/9Z3uQfoYmBA Bx5qPBtFvyBSh4UaGwYq4BxRyJFtMNA3HGurkbgv6fSDBw0EfVzW+t89WB5/lctMrbe9 ANCpd3xlSFsEEX+bfaUqyQgj0ZwM6FMl0Q4a5fdJ3n+S5oyX72EZgkXBI5MrpnSCDKso POUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+LHPvergv9JOkc07dMLH/z6MgF4Iu1IXQz+MYRIw4ms=; b=ixy7fl8SIQfU2B3PNniutU0OoC/n76b+BaDFAHvUIZrqE+/+7zdpHDKQUeYoHy+ij3 k0tmS2o47lvEOkzHwLOpN8VNbJcQt42tT9bVTGpmJ2eA7E/GpAm1bxBqm/7Wh7OfJ17U J3++ryTxv0hPpGfOrva55F5HvXvEmkLkI5EDsEYo/rRshAntJC4CWJO3Xx7oBAycqBR6 OKyCjvub4TBKODBIlmbnNgMzDzfDYH6/bJM9N0JfyhqrohvBn+lMeIB+biNvNXMkFBWJ Mnvoz4RL3yGbO6EgzmKZ37eLXsH76yGNZJDagqs04jLotwpmWT+ofmGHaj/ncvnP47lT SqsA== X-Gm-Message-State: AOAM532SrkWqVmtEFClUs1bXSlAPtezRoedTmEna285+k9ccZ4RTKFEM bQuBOo676AdSZ+HyVZgvSedfxA== X-Received: by 2002:a17:90a:fcc:: with SMTP id 70mr1247879pjz.220.1598878992774; Mon, 31 Aug 2020 06:03:12 -0700 (PDT) Received: from nagraj.local ([49.206.21.239]) by smtp.gmail.com with ESMTPSA id l21sm7400580pgb.35.2020.08.31.06.03.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2020 06:03:11 -0700 (PDT) From: Sumit Semwal To: Thierry Reding , Sam Ravnborg Subject: [PATCH v6 2/2] drm: panel: Add novatek nt36672a panel driver Date: Mon, 31 Aug 2020 18:32:51 +0530 Message-Id: <20200831130251.19769-3-sumit.semwal@linaro.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200831130251.19769-1-sumit.semwal@linaro.org> References: <20200831130251.19769-1-sumit.semwal@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , Benni Steini , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , Mauro Carvalho Chehab , "David S . Miller" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Novatek NT36672a is a generic DSI IC that drives command and video mode panels. Add the driver for it. Right now adding support for some Poco F1 phones that have an LCD panel from Tianma connected with this IC, with a resolution of 1080x2246 that operates in DSI video mode. During testing, Benni Steini helped us fix the reset sequence timing (from 10ms to 20ms), to get the bootanimation to work on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occasionally. Signed-off-by: Sumit Semwal Cc: Benni Steini --- v2: increase reset sequence timing to a safe 200ms v4: Since "0425662fdf05: drm: Nuke mode->vrefresh", we have to calculate vrefresh on demand. Update for it. v5: Fixed review comments from Sam: - rebased on top of drm-misc-next remove return of drm_panel_add() remove drm_panel_detach() - renamed the panel driver file to reflect that this is a novatek nt36672a display driver and not only for tianma panels. Adjusted some internal names also to reflect the same. - corrected changelog to add info about the generic Novatek DSI IC - corrected compatible string accordingly - removed pinctrl - used drm_panel* API for prepare/unprepare/disable/remove v6: Fixed few review comments on v5 from Sam: - add dev_err_probe() support - move DRM_* error printing to dev_err() - removed a few unnecessary bits --- MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-novatek-nt36672a.c | 740 ++++++++++++++++++ 4 files changed, 758 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt36672a.c -- 2.28.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/MAINTAINERS b/MAINTAINERS index 01fb9ee6b951..aeecade2d65f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5619,6 +5619,13 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F: Documentation/devicetree/bindings/display/ste,mcde.txt F: drivers/gpu/drm/mcde/ +DRM DRIVER FOR TIANMA NT36672A PANELS +M: Sumit Semwal +S: Maintained +T: git git://anongit.freedesktop.org/drm/drm-misc +F: Documentation/devicetree/bindings/display/panel/tianma,nt36672a-panel.yaml +F: drivers/gpu/drm/panel/panel-tianma-nt36672a.c + DRM DRIVER FOR TDFX VIDEO CARDS S: Orphan / Obsolete F: drivers/gpu/drm/tdfx/ diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 8d97d07c5871..02600f12a063 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -208,6 +208,16 @@ config DRM_PANEL_NOVATEK_NT35510 around the Novatek NT35510 display controller, such as some Hydis panels. +config DRM_PANEL_NOVATEK_NT36672A + tristate "Novatek NT36672A DSI panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to enable support for the panels built + around the Novatek NT36672A display controller, such as some + Tianma panels used in a few Xiaomi Poco F1 mobile phone. + config DRM_PANEL_NOVATEK_NT39016 tristate "Novatek NT39016 RGB/SPI panel" depends on OF && SPI diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 15a4e7752951..4a36eb45f670 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -19,6 +19,7 @@ obj-$(CONFIG_DRM_PANEL_LG_LB035Q02) += panel-lg-lb035q02.o obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o obj-$(CONFIG_DRM_PANEL_NEC_NL8048HL11) += panel-nec-nl8048hl11.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35510) += panel-novatek-nt35510.o +obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36672A) += panel-novatek-nt36672a.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT39016) += panel-novatek-nt39016.o obj-$(CONFIG_DRM_PANEL_MANTIX_MLAF057WE51) += panel-mantix-mlaf057we51.o obj-$(CONFIG_DRM_PANEL_OLIMEX_LCD_OLINUXINO) += panel-olimex-lcd-olinuxino.o diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c new file mode 100644 index 000000000000..675e9d52f3c4 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c @@ -0,0 +1,740 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2020 Linaro Ltd + * Author: Sumit Semwal + * + * This driver is for the DSI interface to panels using the NT36672A display driver IC + * from Novatek. + * Currently supported are the Tianma FHD+ panels found in some Xiaomi phones, including + * some variants of the Poco F1 phone. + * + * Panels using the Novatek NT37762A IC should add appropriate configuration per-panel and + * use this driver. + */ + +#include +#include +#include +#include +#include + +#include +#include +#include + +#include +#include +#include +#include + +#include