From patchwork Mon Nov 9 21:18:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320985 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000408ejb; Mon, 9 Nov 2020 13:19:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJwy/eumOwf/9zBnO8+lovdzqT1CgrXeaaVabu0Ltjz3TS5YlJJBzDjU8D2n4IpDtd3Q5ocW X-Received: by 2002:a17:90a:2ec3:: with SMTP id h3mr1233919pjs.54.1604956772577; Mon, 09 Nov 2020 13:19:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956772; cv=none; d=google.com; s=arc-20160816; b=AD7pbVpNAFkYzYzcKJwr221FU14W7q/RrZFq3YDExHEjsjl2DN5u/Gm5XPrzi5IY6T swcbyZt46sOHJtINBiFilMujrcDMY7KM2a66IWiDWR8y74Tfc1cnVLitqDdjcK4ufMhd ESh4hnvUv+4BLqoOxmZvBdcUva0ztCRS2YOpGMB89CceuM5/I7tmpx35GG1wivCBEKSF 4fFNksXHizN/g2fU0H5teCD+WYsLN3qFG5oCd1Nsa+rw30Rfz20/GHlAHcJCMSUFb9Jz +x7KFCREul8amped2hfTtnh42APdM4b6dFLEA4Nj65o2BKAvO3xCMJZVJfDCVxWzJGT4 Epiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=UWQa05Anfyf/fM0t98fyHNeHd7De6uImlC/x651DIto=; b=LL0f/tPRj7OEvgOxp3of0fnktE2Dwgic3GVoWM96upYLJSDrlgIqQvZC058vjew9Fu LQHX0qnh3EWvemoZlMIvv/XStTiLDT0KCnlk9mG2+xgrqbHZ2brGGXBMT5jX3dIrEKYa jqDqXEcVJQjNCYOVXa9QzQREG9xyMzJaxTTeKnvmCDsGbWSa/ibenhu7CI8bjbhbkQT4 O/2jQMF4VJBmVh6YErmgfh6tJRaoOpbKLrkv6lFDhaq/VKpoo/dR+3FRdpCe84Zq47lu +r0JG8vXeU2kRoP/g1XlpC2qvQIM/MWPsG7+ZvvhJ6BXr537UqwosE+AzKx6BqcfmYJh K6Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=AaQNQ9NI; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id v189si9471498pgd.204.2020.11.09.13.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=AaQNQ9NI; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8444F892FA; Mon, 9 Nov 2020 21:19:31 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id B655A89272 for ; Mon, 9 Nov 2020 21:19:29 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id p22so942915wmg.3 for ; Mon, 09 Nov 2020 13:19:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Hg/I8hWx//QmSj29JDx18mAH+iG9CJqB6Lurd4l5hM4=; b=AaQNQ9NIHkRGoTiIRF1aRbT+aRsVQOm3b9utKoz6DPEumCRmo8ulSQC4s6mp+erOM4 LRXMWkhr0iRHwoQjDKD2CWxMIlFyviTFAewCFYg+m4eNcwLPgs7s7FaXFliAQ1D2LNYV KWWf497r8hxqorMREEcQnOEkHSmQ/oOI+acP+sT85BS6Jj9aCQSUZF/n4aBwaS0ouFNB dQfab8IsQ1wI4bP4VpeVJXWYH450W4LDxGaHXJSDMkuD5kIIVpdbF/lAMSFhiteMxQTs 8AaotcYN+NonRvAYcA2ThRjOs5m937qryN9440lKxewZFO8wEihMG2b7zvWDLNIsgBAP VvrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Hg/I8hWx//QmSj29JDx18mAH+iG9CJqB6Lurd4l5hM4=; b=cLFe+u0dRGyfVLUuhVFlsewhHiJAU8DpS1KPPXdtnVPV8eA3amDrK8iERzdniZlIAF KCLuo1GKGc8RRcx7mZCBrMWhCAhJ+lJ1kv7snqYf9FVhNUYjeK1pzRhesQYBf1UtKZpN c4nI/H7KwE/bn9snld8iAp37UISK7JC2JYo9oGmhwYjlt7kwP+BpLl6rIJ08AmDuDexb l2uIEW3aWDmVnNXsfoBDV55EsrG/v1NKsrYWY/d2WFMmUkekNnoX0dJwmsNv0rEbpVjP 7IA4rgi6Q+IUWwXP8fY1So80uHqeNiw/bgisT4ocK1XYYO3m0NtviJzJFUdkoQtHJ0O4 cKTA== X-Gm-Message-State: AOAM533ce8Ica0A9mQKTDphw8HbZxtJmYOMoKHrpy8buUI1yyQkJUuBI OWjXtM3+oXPyqfuXr9XMsQkeDA== X-Received: by 2002:a1c:790c:: with SMTP id l12mr1056495wme.47.1604956768392; Mon, 09 Nov 2020 13:19:28 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:27 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 10/20] drm/radeon/radeon_ring: Add missing function parameters 'rdev' and 'data' Date: Mon, 9 Nov 2020 21:18:45 +0000 Message-Id: <20201109211855.3340030-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_ring.c:226: warning: Function parameter or member 'rdev' not described in 'radeon_ring_unlock_undo' drivers/gpu/drm/radeon/radeon_ring.c:240: warning: Function parameter or member 'rdev' not described in 'radeon_ring_lockup_update' drivers/gpu/drm/radeon/radeon_ring.c:283: warning: Function parameter or member 'data' not described in 'radeon_ring_backup' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_ring.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_ring.c b/drivers/gpu/drm/radeon/radeon_ring.c index 37093cea24c59..c3304c977a0a5 100644 --- a/drivers/gpu/drm/radeon/radeon_ring.c +++ b/drivers/gpu/drm/radeon/radeon_ring.c @@ -218,6 +218,7 @@ void radeon_ring_undo(struct radeon_ring *ring) /** * radeon_ring_unlock_undo - reset the wptr and unlock the ring * + * @rdev: radeon device structure * @ring: radeon_ring structure holding ring information * * Call radeon_ring_undo() then unlock the ring (all asics). @@ -231,6 +232,7 @@ void radeon_ring_unlock_undo(struct radeon_device *rdev, struct radeon_ring *rin /** * radeon_ring_lockup_update - update lockup variables * + * @rdev: radeon device structure * @ring: radeon_ring structure holding ring information * * Update the last rptr value and timestamp (all asics). @@ -275,6 +277,7 @@ bool radeon_ring_test_lockup(struct radeon_device *rdev, struct radeon_ring *rin * * @rdev: radeon_device pointer * @ring: the ring we want to back up + * @data: placeholder for returned commit data * * Saves all unprocessed commits from a ring, returns the number of dwords saved. */