From patchwork Mon Nov 16 17:40:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 324498 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp3506524ils; Mon, 16 Nov 2020 09:42:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJw5NNgKNv3gHJOB49jcb7RyGF2f0oRX/G9TKRY9AOItENcVmR/neG24OGyXA79kXs7RKkWb X-Received: by 2002:a17:902:ec03:b029:d7:c7c2:145a with SMTP id l3-20020a170902ec03b02900d7c7c2145amr14154061pld.33.1605548526374; Mon, 16 Nov 2020 09:42:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605548526; cv=none; d=google.com; s=arc-20160816; b=dEQxrXpgUtkbjv6R4fJrbk9RUgvc625Rmon2qGJNn2JRFJAs3F0gTXAsDI5mLTln+U d5pELG8pHP805suRXjyKN7KXlkUwVOBo8dsafY95TPr5nJVIF9vK+pK2C2hZ0f7QqYxw POoF6A1FMOLC7SM7Ax0yN705fJSSocDY29r7SZJXK0TIT2ERv5rswCf5Ha15AA92JWjk tHNXwaC7lyDNB5DIuMCCBBi1npNsCR2dVMYUaPH+B5AnguOgYBTJ+DiqhtpuVkCB8uuV P5dzen9Cxyy8Tfirllypi98QoqycO8ZX8YTw86UV+zMgpRlSC84PS3DP5XSueXdRBnqJ +wHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=Y3smD7tfd4dI9mhtJ4OBAEj6KueKuMdc2jcCl3ZnuSA=; b=I0NOWGoAcR45ntrQOAjuT9LeUYDIE127cVlL7AwSOzc2Wa+KsHzGOZ9ffD/KiZ6gBS bNjf8qpx8HvV1nlLGXHGPIX/05ieBRMW4TsbtWjomFgxv/9gU7AQno8C6Kj2NYI/SClf YZn2b7G3Y9jTD4We/FHDdiQ6FDvkYrwMtp2Js6tOfvaTNyMXyT3q7Fy/5IlWZuE2bLXD sLlACQModulINZ66LftUW837HlNYi/hyNBNlqrYl2NmvPy55MofYvtYP23YLu9cS09vE Cw4HFcuVvzbNDfRg9O7o/sNwWWlgqnDWMIeBZUsIElezyB+CBaD3Kbn82o2+GnpK3CHI t+KQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="Q/5s24f2"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id p17si16474099pgi.0.2020.11.16.09.42.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="Q/5s24f2"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D97A6EA07; Mon, 16 Nov 2020 17:42:01 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 44EEE6EA01 for ; Mon, 16 Nov 2020 17:41:52 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id a65so49986wme.1 for ; Mon, 16 Nov 2020 09:41:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=voWmA7JwfKGhDZMYWPZkZRLYOBpcwZ/fXqx90N9cMjo=; b=Q/5s24f2J2WYaf1lDVin02W6tDLEn9ETKKVIAlSa3geYU2EDOSCN8AHyxHt4cvgOCh zTPfZjuqBYHxS2cnpdwzjJC+ZUVxIi9H4UJwrkv0ytH6ZgGUXx35pl+RRgKBsHxPcfDS yHiyh2/prpOiQauOfr6NeOlW8bUML1ksJJex8rye/wHRVQpip2qLEAyWp3kUlXJSK0Er sjLFTmYOVG3joUvxSqsetKTtYqtR6t03eAT1M00X3rfX/vlI3+doDpxEz0yyTFG0N8sw cqDeBro+6ick1o85xj9vMwMomzZ+imZLDJNd7CFBTPKTPHhQj1HKKY0tE0vry6ZKlEH4 7B1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=voWmA7JwfKGhDZMYWPZkZRLYOBpcwZ/fXqx90N9cMjo=; b=Q+GeV9ciMemo+T/IZOqJ+KVaZtCkjUfoYZHqjodhAsE/iRq46PMBho2WrO9C3MZU7u iiEwlPVSJhUrmGYSyfWUVDN+iK65XS/+CTB5jDK92eyaaNFKsUqvQ5ONPvEJAyYXWMl/ C2WCCcdWUqq/CVZRlcifIyih4BDUxltQ3NcXg27ozxJ4BzgVj4dgyDVaSBfUAdeW9HzP 0eXmEiQ51VfOpRN0PHLimhN3DtNCMVPrGkVyuHV5WViQjG0VihiaWzt2OQNkX3EcKvqP 5iCKgFJgnJPQ6N+l86h9+Z7085WLn/CW774KJmW+1FoKdYwF0OUQbUFfUYt0jA9ZYtVI X8fw== X-Gm-Message-State: AOAM532CYIoVbSNeq0jkN+hy1FfFVlyfnP9yUqjMtO+7OK1HMUXOOsW5 bU6iIvxLIMiZayKu878b1hECyw== X-Received: by 2002:a7b:c18e:: with SMTP id y14mr7520926wmi.123.1605548510917; Mon, 16 Nov 2020 09:41:50 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:50 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 21/42] drm/nouveau/nvkm/core/firmware: Fix formatting, provide missing param description Date: Mon, 16 Nov 2020 17:40:51 +0000 Message-Id: <20201116174112.1833368-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Skeggs Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" ... and demote non-conformant kernel-doc header. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter or member 'subdev' not described in 'nvkm_firmware_get' drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter or member 'fwname' not described in 'nvkm_firmware_get' drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter or member 'ver' not described in 'nvkm_firmware_get' drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter or member 'fw' not described in 'nvkm_firmware_get' drivers/gpu/drm/nouveau/nvkm/core/firmware.c:106: warning: Function parameter or member 'fw' not described in 'nvkm_firmware_put' Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c index 8b25367917ca0..ca1f8463cff51 100644 --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c @@ -58,9 +58,10 @@ nvkm_firmware_load_blob(const struct nvkm_subdev *subdev, const char *base, /** * nvkm_firmware_get - load firmware from the official nvidia/chip/ directory - * @subdev subdevice that will use that firmware - * @fwname name of firmware file to load - * @fw firmware structure to load to + * @subdev: subdevice that will use that firmware + * @fwname: name of firmware file to load + * @ver: firmware version to load + * @fw: firmware structure to load to * * Use this function to load firmware files in the form nvidia/chip/fwname.bin. * Firmware files released by NVIDIA will always follow this format. @@ -98,7 +99,7 @@ nvkm_firmware_get(const struct nvkm_subdev *subdev, const char *fwname, int ver, return -ENOENT; } -/** +/* * nvkm_firmware_put - release firmware loaded with nvkm_firmware_get */ void