From patchwork Wed Mar 3 13:43:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 392111 Delivered-To: patch@linaro.org Received: by 2002:a02:290e:0:0:0:0:0 with SMTP id p14csp5133792jap; Wed, 3 Mar 2021 05:45:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJxggke5LyXGv36oQofUQ2ieax8hjY4UcJUao8tX/I4HyFhdCLAdEtnYhKyq1NFTE57wvuZ8 X-Received: by 2002:a62:6585:0:b029:1b9:d8d9:1af2 with SMTP id z127-20020a6265850000b02901b9d8d91af2mr3324039pfb.17.1614779106807; Wed, 03 Mar 2021 05:45:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614779106; cv=none; d=google.com; s=arc-20160816; b=HcItYAij+UuA6W1ywhVI1Obhdfs6hHdSwAVLj3qN7pTsrqsLY9VSTGdc3ozOfqgNJD vTxRrgIaZ5//ZiwGMAwG+grneyuVfvGYHUYq7veW8sL75adXTscMDXCNKNDBN7Kj8vGv PECvWCJzkGl3iD9FEBZV7bC72DWQKoJUKPB1glt1mubCqKfhMRSWMBy376XjClyCRurR O+yqPbkaCE2DlOV7jUMHiabhTjUXY5TO2gALqlKgQD+tOXjOiQjPQXpLbsHlZRE+b17s xikwV/a1uuyCIWweOuraXDyqV7nMU+aCRSpoIkhzrfV8Df6NtqUCBzEoVuFMJKMf2HQk 2mPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=lj4kA3uNiIZa5QMOMgUCTIfROkXsolwstcDt3zBm/Ww=; b=NCLuLsOe7QF1be1p7u1g5w9cOr3P7SwGyNDam00+/LCmJYhC0crIeQMH1IaNfDQekz UjWnSjyZNWrrQisSSe4vrUoyQ75JklKIf2Dhdrs493KAZmejuSbnsJ3zimP0Kx02YAOk QWt7dQM4OItY2xj2IMTN/NpMP3cAM3Cs1Gnd4p4oW7P9oU0IflIfQ6q7+xiOROIykLWU kbXuWf7PoX3kqCxYRIsokdodcX6v9DFAKcESB0pCcz5XtiUtqKytOUUFT4YcfINc1rDf cZAYupJdCiTRCySJ5q1PO9pGTobPoHGKIpWJcoO1USIH4o6PHGWHNihOdHFGynw8kzdQ p/MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=iRy5Bujr; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id lk13si6118178pjb.85.2021.03.03.05.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 05:45:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=iRy5Bujr; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 20CC16E97D; Wed, 3 Mar 2021 13:44:29 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 255056E97D for ; Wed, 3 Mar 2021 13:44:28 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id f12so19933381wrx.8 for ; Wed, 03 Mar 2021 05:44:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sz9Cp9ck6lJ+tMgVjEzPh2tJa07UDmiPup+Dgs8FC3o=; b=iRy5BujrVB9UEC5KMSnntpLfMBSYx0sVYaWNWZtKRMbnfDlkW/xumxxReE2x6f5B+j C0YnAMlW/JaMuXcrib4m8rvnxbyOZ36xtoSET7LYyASMvRURQhfJ7pf8bl+g61GAK/np twPqCvB89X+kHDseXK0/0AcK3ZFQREgadEuf4s6F5u7rpsa9yGgbVByv8gCdVwye7pZR eW4VH77/+ncFbnovCOdTWhN12gKBWETnnMn3yqNib52JMaMAjMggvud4liml0Oznjr6H NUrXh02BQETuPOpXgl6++cFz53olwrsHgUlUBbSl/5PfOJnaoV20ZB2d0nKg42s3n9Mg 3MGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sz9Cp9ck6lJ+tMgVjEzPh2tJa07UDmiPup+Dgs8FC3o=; b=emsSEX0E3OSxX04nE5AILzdCQv1/9ee1JXY5rmQPOuKg4FmXVBrFWQSTso7QKgySCU Ilr2MIHQY/cbKey1sdabhDIt6xDga8eZrkPbJwesS7hl9IWBdfpCdpsHXN5F5GA++faR sCAJzH4Iixv4+BVQaLAzP8dKA/4S5lDOqSgjl3zHifW4NNSvMQW+5giazdRSxmt6TLFV ii6ev6B+iSi5+REyI1YuXb7kS3oA/bbXra/fwFym/fSD9ycvD9eP20irFAsbTHmOuHFA FYQf22IEfEiv93xM7MxJ1ykqaRxdC6waTGTVrKIqz+177I4tLDw9/MoQPUgTA4jnm6kt eN6Q== X-Gm-Message-State: AOAM5327HPHS9URjQyioD+Po3kef0/UsxEbtnkTBOLM7tIUbgVBSIOJ/ n0ZMQr+RGdDnMGzEcYNaTkRjrg== X-Received: by 2002:a05:6000:18a:: with SMTP id p10mr27897680wrx.166.1614779066850; Wed, 03 Mar 2021 05:44:26 -0800 (PST) Received: from dell.default ([91.110.221.155]) by smtp.gmail.com with ESMTPSA id w18sm6109524wrr.7.2021.03.03.05.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 05:44:26 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 50/53] drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function param descriptions Date: Wed, 3 Mar 2021 13:43:16 +0000 Message-Id: <20210303134319.3160762-51-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210303134319.3160762-1-lee.jones@linaro.org> References: <20210303134319.3160762-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Roland Scheidegger , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, VMware Graphics Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty' not described in 'vmw_validation_res_node' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty_set' not described in 'vmw_validation_res_node' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:216: warning: Function parameter or member 'res' not described in 'vmw_validation_find_res_dup' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:216: warning: Excess function parameter 'vbo' description in 'vmw_validation_find_res_dup' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones Signed-off-by: Zack Rusin Link: https://patchwork.freedesktop.org/patch/msgid/20210115181601.3432599-9-lee.jones@linaro.org --- drivers/gpu/drm/vmwgfx/vmwgfx_validation.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.27.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c b/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c index f2e2bf6d1421f..e7570f422400d 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c @@ -48,7 +48,6 @@ struct vmw_validation_bo_node { u32 as_mob : 1; u32 cpu_blit : 1; }; - /** * struct vmw_validation_res_node - Resource validation metadata. * @head: List head for the resource validation list. @@ -64,6 +63,8 @@ struct vmw_validation_bo_node { * @first_usage: True iff the resource has been seen only once in the current * validation batch. * @reserved: Whether the resource is currently reserved by this process. + * @dirty_set: Change dirty status of the resource. + * @dirty: Dirty information VMW_RES_DIRTY_XX. * @private: Optionally additional memory for caller-private data. * * Bit fields are used since these structures are allocated and freed in @@ -205,7 +206,7 @@ vmw_validation_find_bo_dup(struct vmw_validation_context *ctx, * vmw_validation_find_res_dup - Find a duplicate resource entry in the * validation context's lists. * @ctx: The validation context to search. - * @vbo: The buffer object to search for. + * @res: Reference counted resource pointer. * * Return: Pointer to the struct vmw_validation_bo_node referencing the * duplicate, or NULL if none found.