From patchwork Fri Mar 5 17:03:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 393527 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp596732jai; Fri, 5 Mar 2021 09:04:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7pGYIO7xUa/b6snp3CJQrOz3uUzy8Ka/S4BosW6OQXfdhNIPGAmUUAXM/17L3A2pBhdfI X-Received: by 2002:a05:6a00:884:b029:1b4:440f:bce7 with SMTP id q4-20020a056a000884b02901b4440fbce7mr10284208pfj.20.1614963839885; Fri, 05 Mar 2021 09:03:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614963839; cv=none; d=google.com; s=arc-20160816; b=ldEKQGHEuTMbcfb2+6XlpC4pIW/2GPeBa6iRuNk6sv9DkFwxibYyUjAuizJN4tTRGg Z9Nytl3ZFeXS0rbPX0Q4zFmM7p0CmHABCvME2BtMG8GgT7+cNbta1QzHFFJ7+4OYGdLN SnT+z7USgzGp7ZH1e8YQEJZT/nJCFk5NnIhF3e4o1xpiJAhlGV24EBJXgDOoJWL/5bAq YcO1GjBEQt0J2UJsoO8RwTqAtFUJdnChoBSbpk88Ren1/NtvkK4WlGetbCrGP7fzIQFm 32tLSviAhNUS3gReFLQwZ5vmH251f9MNhjshjjU7kPLR5+17Qw74lcoL2W4IpR4BQ+CG agJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:delivered-to; bh=OSH1tdk71siA+L8I4oWGHr7gNJCPHLxAbaOhafupgHc=; b=hlW4QDffYvtUI7Fjxh7eL+gaDEAaazlu8zQN7kQB2uHXop65uh4HeD/FZbsLLQW/CJ CB9VkqYHzdlG0f1Nbnz2yuOxmMehOmDMjxZcTahdsD4lb65GE/RULTf9QfVFqte0PyLk i4JibJsBokwlLeGozStKFW4/B+WIytS6X78fKop/JPHM8qU8gG3KHy+yFluVGAMyCC6G QBZ4DvLCZo8ZdavpsidoUL1/uoBVv7TE1OZNZPyOGOMGH9YvL0G6NeYybxfFBBQqT7b3 xCzD7XlXfqZo05nqTrIW3Vgsz8eNTtmiT8icSyqrP7CM3ohpItiudPEFxP8Plkv6cm36 zoBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TgZURChU; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id y10si3135932plp.242.2021.03.05.09.03.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 09:03:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TgZURChU; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B1AD26E223; Fri, 5 Mar 2021 17:03:56 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF9E66E13C for ; Fri, 5 Mar 2021 17:03:54 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id e23so2067006wmh.3 for ; Fri, 05 Mar 2021 09:03:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lZkNk3yYW/8ijhrD082tSx7qBCi8O3cbnVc/FrlwdlU=; b=TgZURChUGXUbgDO2bV0UsU+s1j/d5KKVOwy39jkcxWe/38xJxE8XgQo917QUm+QWZx 2rsQ+GfXyOcIsol9aos7nC+fVNMkUvQwzoG5Zz6McgO7oengrXe5q+vHiuUp+foGg+49 Sda8/VQh1uaa3anhia/BbnTRkLROiFiCh+yjAMM2y4Kt5Z0Vz/E9vgcbBTKTsFBN18Z3 us1vgkBE5QhZ3hUt66DqUWgUzb23W/10IX7tmRGQrOgYj/m6dnbsJfywsit+pgpB+JW1 koIJk3T02fYaDHy/Xf2D/JPPaD7P24OeeE/UgmWLHqJ7eLs/J6XJUXjBQPjrNY+FA4nl 3YoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lZkNk3yYW/8ijhrD082tSx7qBCi8O3cbnVc/FrlwdlU=; b=t017CSj8b+xF7aYsfq/jXmUJG2cq5NByaqTClHMsYW1h+UpEn8ydeFE3j9MwdG7QqR RsYoVcZu0rlUNMVxUTeMikN7hQ18dIXYUuESD8B2x8rMuPzE/IUoB+6HbPKlkDwnV8+Q E0JZrsGZDi9btQmMnNqR0UrfeM/gGmPCBbvJBgw0RU7bQg5nj7TeYBizMFnAmrhfb0Jy FmcxKD5rMtKqJyX/NUQvyIpq7MWFKYlpxEXzJX/ZAkKHcMpWtisPuEJNrkHgwNOGvm0U z6jyd7QSqCRELh0Qmc1qwtyDTl31uIBl8GkWd+POKuLR1yluVuqXRLTTghTZDeLLZeMS bFVg== X-Gm-Message-State: AOAM531pyt5Vze3nVMVIgOq/JiF/D9/XvZEYzZCwd3dGAUH1fKmH1NyI tcUXqGMJGrJdXFuNuPDciHIvcA== X-Received: by 2002:a05:600c:35c1:: with SMTP id r1mr9670239wmq.60.1614963832386; Fri, 05 Mar 2021 09:03:52 -0800 (PST) Received: from localhost.localdomain (lns-bzn-59-82-252-141-80.adsl.proxad.net. [82.252.141.80]) by smtp.gmail.com with ESMTPSA id p17sm4760934wmq.47.2021.03.05.09.03.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 09:03:51 -0800 (PST) From: Daniel Lezcano To: cwchoi00@gmail.com Subject: [PATCH v2 2/4] devfreq/drivers/lima: Use devfreq cooling device registration Date: Fri, 5 Mar 2021 18:03:35 +0100 Message-Id: <20210305170338.13647-2-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210305170338.13647-1-daniel.lezcano@linaro.org> References: <20210305170338.13647-1-daniel.lezcano@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:DRM DRIVERS FOR LIMA" , linux-pm@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, "open list:DRM DRIVERS FOR LIMA" , steven.price@arm.com, Qiang Yu , lukasz.luba@arm.com MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The devfreq core code is able to register the devfreq device as a cooling device if the 'is_cooling_device' flag is set in the profile. Use this flag and remove the cooling device registering code. Signed-off-by: Daniel Lezcano --- drivers/gpu/drm/lima/lima_devfreq.c | 14 +------------- drivers/gpu/drm/lima/lima_devfreq.h | 2 -- 2 files changed, 1 insertion(+), 15 deletions(-) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c index 5686ad4aaf7c..86aea1bdc4f4 100644 --- a/drivers/gpu/drm/lima/lima_devfreq.c +++ b/drivers/gpu/drm/lima/lima_devfreq.c @@ -7,7 +7,6 @@ */ #include #include -#include #include #include #include @@ -84,17 +83,13 @@ static struct devfreq_dev_profile lima_devfreq_profile = { .polling_ms = 50, /* ~3 frames */ .target = lima_devfreq_target, .get_dev_status = lima_devfreq_get_dev_status, + .is_cooling_device = true, }; void lima_devfreq_fini(struct lima_device *ldev) { struct lima_devfreq *devfreq = &ldev->devfreq; - if (devfreq->cooling) { - devfreq_cooling_unregister(devfreq->cooling); - devfreq->cooling = NULL; - } - if (devfreq->devfreq) { devm_devfreq_remove_device(ldev->dev, devfreq->devfreq); devfreq->devfreq = NULL; @@ -110,7 +105,6 @@ void lima_devfreq_fini(struct lima_device *ldev) int lima_devfreq_init(struct lima_device *ldev) { - struct thermal_cooling_device *cooling; struct device *dev = ldev->dev; struct opp_table *opp_table; struct devfreq *devfreq; @@ -173,12 +167,6 @@ int lima_devfreq_init(struct lima_device *ldev) ldevfreq->devfreq = devfreq; - cooling = of_devfreq_cooling_register(dev->of_node, devfreq); - if (IS_ERR(cooling)) - dev_info(dev, "Failed to register cooling device\n"); - else - ldevfreq->cooling = cooling; - return 0; err_fini: diff --git a/drivers/gpu/drm/lima/lima_devfreq.h b/drivers/gpu/drm/lima/lima_devfreq.h index 2d9b3008ce77..c43a2069e5d3 100644 --- a/drivers/gpu/drm/lima/lima_devfreq.h +++ b/drivers/gpu/drm/lima/lima_devfreq.h @@ -9,7 +9,6 @@ struct devfreq; struct opp_table; -struct thermal_cooling_device; struct lima_device; @@ -17,7 +16,6 @@ struct lima_devfreq { struct devfreq *devfreq; struct opp_table *clkname_opp_table; struct opp_table *regulators_opp_table; - struct thermal_cooling_device *cooling; ktime_t busy_time; ktime_t idle_time;