From patchwork Tue Jun 15 23:18:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 460556 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp26990jae; Tue, 15 Jun 2021 16:18:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTRK8ySiF5mwXtB02O3bhu+IDMEcx0mcBFa0xJuSO0SNliGtpXABh/11hJJPTrhOoR9jBv X-Received: by 2002:a65:6118:: with SMTP id z24mr1898231pgu.325.1623799114433; Tue, 15 Jun 2021 16:18:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623799114; cv=none; d=google.com; s=arc-20160816; b=W5gdfHQwLKPCPE9f3auAjKnXtGp4+kFDLbIowIIaEGk7Oj/vjouvDBVcrKOTfNEaAA TCeBWXQ0CUJXMBWBSi18T2+GhlyRGOONGGC9RX1JRxdkdHhfGQLcAHrrrhsHk5GwJRfM h/qUey9BlbtzFpMCLk3aV39dBLA77sBa2vL8v88md8utZOICxcb11ECGuzytmSUauZpd SYeSIZ63dfOut6uUnbC1+EKyN32sNlS8RAg7ZWf+0hByPas7ZREbafAH9oeeF6wzJ0bw ZngGisxrrIvACTTDsEsFAesQFcfD/l4wiKTNt/4tmcwWH+0hhjVaEegskEcy712m6Rwm N4HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature :delivered-to; bh=pth2v3ZNP3bQI72INPpsNym5/y4d3Mf6qoAfH+N+szA=; b=iJw8cJ3zwhFpmx2zNvhmSoKjW5Ezk3YvToMl1XD+sAWzjl7jP2CVKANGQopjaSrPSy fbG5jnJa/xNwRHp8dJ2oOW9ioYbkCg3cDMdKrMRKYqLZZV1KDNiaVLA6w6hVYLUPS9wP sLkz8/FRaQCMWuvWyPVLV4QTUN7iUZjwUH9+KzpOz5oDsH8doaZ924gzaNmT6KSwk3uz KwCrvw9m31SPAbqMqVZ2BIz97cHk882RF6fJNx+IkqpnsuPANxF59AJrLSfOzca2fvOT U8te7U14nJS/YF9LqqtqRrspMRBblHE/V+e38wRXfd4fiLPgFY0AXgyvOE45dcVAyAmZ hHrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="EU/DAwTQ"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id lr15si255644pjb.28.2021.06.15.16.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 16:18:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="EU/DAwTQ"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D2AB789A98; Tue, 15 Jun 2021 23:18:30 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D5FA89A98 for ; Tue, 15 Jun 2021 23:18:30 +0000 (UTC) Received: by mail-ot1-x333.google.com with SMTP id 7-20020a9d0d070000b0290439abcef697so636728oti.2 for ; Tue, 15 Jun 2021 16:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pth2v3ZNP3bQI72INPpsNym5/y4d3Mf6qoAfH+N+szA=; b=EU/DAwTQl9leUMmTrZZsDJD5Uk35zXy/TcEXIrlpTuyhB9pAmmnrNPqsb9I6YBcCQ8 grHUArQsFzwNCSHwY7sKhhIVIAgnR3aJJOkKfBrexYqtCoG3l8MrlrCcRan2rNUAHOiP Urv2m4sSN9nqp/b4b1Pa2gU7C7Y4SvCWOQOMGsgMIPzIm/WMXH9tDzB/BU21nuTSzOwx JtVkL+24h0RX6rnnnKeqf/xU8pBHuHpNjy7zUMyZzKv6lU9giGcSBvr23mhSMVu22wXc s03lNt2FgbuPExJn2sR7ZG332alnZXrUWfEQ2poVziXMhCRizhp+6CO6XTs08Jvu7DIS rnSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pth2v3ZNP3bQI72INPpsNym5/y4d3Mf6qoAfH+N+szA=; b=V51AFvJaTRqfCXWcB5poO3YiBTxvBmtDdy/V6sTxmOk9vwJU5YyGVkg+4zw6G/1ABg htisQNiU2wVp7QsVSluZWjXAQIxys3ClIa8nurENtnnvkYoSiTH41aw3Hnji/PcRctHL NxPJ4rTxasK72/gJc+XMvkBUFNTshmxoGjhRVwjnoe6exXmkGaruS0lDSo3GR30SM4p/ 5T24n8w2dqkC1OQ5qXA2mEh64G5MegpAPSLxsti0mMUvqyiX6JXN4o7L2HbBDOeKPr30 L9r9BIee27ef9sx0Ss6r+D6jvIdyjaogmaKovtAhoZlWvDUxkxJAHs1Hj/b0+q34sXzP yQsg== X-Gm-Message-State: AOAM533s0iHeTnZGR8KF6kWvEuRBIGK+5rmayrb/9xfLgYQy/OkfEQXs JaMjbzN5aTrHtf2ZhafnLNef5A== X-Received: by 2002:a9d:1ea5:: with SMTP id n34mr1337303otn.340.1623799109568; Tue, 15 Jun 2021 16:18:29 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id m18sm96101otr.61.2021.06.15.16.18.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 16:18:29 -0700 (PDT) From: Bjorn Andersson To: Thierry Reding , =?utf-8?q?Uwe_Kleine-K?= =?utf-8?b?w7ZuaWc=?= , Lee Jones , Doug Anderson Subject: [PATCH v2 1/2] pwm: Introduce single-PWM of_xlate function Date: Tue, 15 Jun 2021 18:18:27 -0500 Message-Id: <20210615231828.835164-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Jonas Karlman , David Airlie , Robert Foss , dri-devel@lists.freedesktop.org, Neil Armstrong , linux-kernel@vger.kernel.org, Jernej Skrabec , Andrzej Hajda , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The existing pxa driver and the upcoming addition of PWM support in the TI sn565dsi86 DSI/eDP bridge driver both has a single PWM channel and thereby a need for a of_xlate function with the period as its single argument. Introduce a common helper function in the core that can be used as of_xlate by such drivers and migrate the pxa driver to use this. Signed-off-by: Bjorn Andersson --- Changes since v1: - Pick up the optional flags cell as well drivers/pwm/core.c | 26 ++++++++++++++++++++++++++ drivers/pwm/pwm-pxa.c | 16 +--------------- include/linux/pwm.h | 2 ++ 3 files changed, 29 insertions(+), 15 deletions(-) -- 2.31.0 diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index a42999f877d2..5e9c876fccc4 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -152,6 +152,32 @@ of_pwm_xlate_with_flags(struct pwm_chip *pc, const struct of_phandle_args *args) } EXPORT_SYMBOL_GPL(of_pwm_xlate_with_flags); +struct pwm_device * +of_pwm_single_xlate(struct pwm_chip *pc, const struct of_phandle_args *args) +{ + struct pwm_device *pwm; + + if (pc->of_pwm_n_cells < 1) + return ERR_PTR(-EINVAL); + + /* validate that one cell is specified, optionally with flags */ + if (args->args_count != 1 && args->args_count != 2) + return ERR_PTR(-EINVAL); + + pwm = pwm_request_from_chip(pc, 0, NULL); + if (IS_ERR(pwm)) + return pwm; + + pwm->args.period = args->args[0]; + pwm->args.polarity = PWM_POLARITY_NORMAL; + + if (args->args_count == 2 && args->args[2] & PWM_POLARITY_INVERTED) + pwm->args.polarity = PWM_POLARITY_INVERSED; + + return pwm; +} +EXPORT_SYMBOL_GPL(of_pwm_single_xlate); + static void of_pwmchip_add(struct pwm_chip *chip) { if (!chip->dev || !chip->dev->of_node) diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c index cfb683827d32..8cd82fb54483 100644 --- a/drivers/pwm/pwm-pxa.c +++ b/drivers/pwm/pwm-pxa.c @@ -148,20 +148,6 @@ static const struct platform_device_id *pxa_pwm_get_id_dt(struct device *dev) return id ? id->data : NULL; } -static struct pwm_device * -pxa_pwm_of_xlate(struct pwm_chip *pc, const struct of_phandle_args *args) -{ - struct pwm_device *pwm; - - pwm = pwm_request_from_chip(pc, 0, NULL); - if (IS_ERR(pwm)) - return pwm; - - pwm->args.period = args->args[0]; - - return pwm; -} - static int pwm_probe(struct platform_device *pdev) { const struct platform_device_id *id = platform_get_device_id(pdev); @@ -187,7 +173,7 @@ static int pwm_probe(struct platform_device *pdev) pwm->chip.npwm = (id->driver_data & HAS_SECONDARY_PWM) ? 2 : 1; if (IS_ENABLED(CONFIG_OF)) { - pwm->chip.of_xlate = pxa_pwm_of_xlate; + pwm->chip.of_xlate = of_pwm_single_xlate; pwm->chip.of_pwm_n_cells = 1; } diff --git a/include/linux/pwm.h b/include/linux/pwm.h index 5a73251d28e3..6aff1fa4fe5d 100644 --- a/include/linux/pwm.h +++ b/include/linux/pwm.h @@ -411,6 +411,8 @@ struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip, struct pwm_device *of_pwm_xlate_with_flags(struct pwm_chip *pc, const struct of_phandle_args *args); +struct pwm_device *of_pwm_single_xlate(struct pwm_chip *pc, + const struct of_phandle_args *args); struct pwm_device *pwm_get(struct device *dev, const char *con_id); struct pwm_device *of_pwm_get(struct device *dev, struct device_node *np,