From patchwork Tue Feb 1 15:10:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 538945 Delivered-To: patch@linaro.org Received: by 2002:a5d:59ac:0:0:0:0:0 with SMTP id p12csp860853wrr; Tue, 1 Feb 2022 07:11:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJzXPVKRMl4U7TZ7GPx36LoYbE+COrnBawShwBggU3PMXe+wuMVbFa/9US5+eTdELnEk05nD X-Received: by 2002:a17:902:b493:: with SMTP id y19mr25545600plr.97.1643728268189; Tue, 01 Feb 2022 07:11:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643728268; cv=none; d=google.com; s=arc-20160816; b=cXmvRXq+XwMbLnVV4PhYwMb5K1ivpOu1VgpAVeTWmR+0jX5WRJh39ScnEMUJlCI+2j 9nebWLmxhgQyW/uM5eDzDV1oZUKnHP8Y9Sb1XqVE55xkTtyQFodTkstw3wFOEPaWhYZB M3yfN2VH27/tIU5ZznZiEUgr/HfZ/GIyksJl0VacpcTEder+rCjjK9mkTTbUe2796H+F 0TWsaOKYFGMiYViy95J3uII/Lczm3XwlP/c/xXZfw2DGV5N4wf3JuR2SB0mPrshauU78 VeeE1pZINdJT9fLN7cdTfpc6tjti3lUyr3WSEIrXp8bfI+DR2oq+hwSwvF8/8ptH9Y65 5zSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to; bh=rStlTv/QLBk6KsFVu0/iZDaKBkJO7zJVGuOILLqnt5c=; b=GzKOZuKib21tNnLvlTgyJRyvwMTc8siKOXe/m1hhCrfRjwsA5itUPCDL6kP3lSEM5F eRvr5Kf9Gwz48nojg+xw/JjkwfRCZbEx/h31R7qD1FHnaUxBzxmHkiR//KtIEBFuToh7 h7CfZjzMn6q5UXkNc98JGht/u9/nFHjpHH/LDuFZfSPbK6KLe3qwBOKIfg82/ExCt8o9 bR8QWFgToi+BW8luDgvviPyWjLnZdJ3MkNKU6jSesVUdTkWRbYYMeEJq8UIRifrld2aJ 838ywLRY2P7XG/zXinaHfrXXgS8xvnnmQibVttxxaUMq2aPc4TOvBBmAMhiDPRDDzo8U ohCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=mBvRaov7; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id d20si2356433pjx.3.2022.02.01.07.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 07:11:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=mBvRaov7; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 086CE10E641; Tue, 1 Feb 2022 15:11:04 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by gabe.freedesktop.org (Postfix) with ESMTPS id C090D10E5F7 for ; Tue, 1 Feb 2022 15:11:01 +0000 (UTC) Received: by mail-lj1-x22f.google.com with SMTP id j14so24599696lja.3 for ; Tue, 01 Feb 2022 07:11:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rStlTv/QLBk6KsFVu0/iZDaKBkJO7zJVGuOILLqnt5c=; b=mBvRaov7kXUZJbbBGmYwL865IkYzMKUi6VGXGwk8/+sbEhvr/OfoTroK0Obq60dxAC MfGUqE4FzLuS6XowC0d/q3lvwCMVK2P5h69IUhNrHvsnMd2nu/z0kF328GCKzc/obLLO 1WYNJ7iCHemNwTVCjJwn/DgWrIwwoTFoUsVHf03r5bT75qHsvx/vzWj3hXTxibvg2EAA vqmw0qKSA/wpfdJ5o+MgVNx2xmjfhmItzzunM2CIh0Up3NXIQvKfCeMhjUxuSyXMdMr+ u6SzQiV5kjwFd54eBlNk/o3vZ/TxZsuDkTSF9kjSPVFZ5QuAb4635rD9kbwY6TEqAO4w jAAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rStlTv/QLBk6KsFVu0/iZDaKBkJO7zJVGuOILLqnt5c=; b=LSv26/dwDdwIo7hnmijPt+OIWbHLJrD3TqQorAjPB3GAqz2EGv20jnMj1G/bcXr3mH E/whPXQ+Nl7DGsbr+7DwRqyLZEpl2fR3P9RoOH0F3tH/Kzn51t4cq92eaqwvqVTll7O1 R7NImgWa7BAuLi5vOkUeRp8IolDiVhKTbKOBOp5zozmde7xWkWpM6BEtw6qKLibFaniN AphvfcHxA1EErOWNVAzm82nxw1XIeMOqCYUckQxzftRAEjBEwW/UBDf8Zw9xC440ToLv FUkWnrdaL660XhzsK4mFSEpTW5Bczt84JWgkZJl/X38dtEogxLeBNfSvwXjDM1SF8Pru ZwXg== X-Gm-Message-State: AOAM533zz/cIEcbD65UbVBk8zE6CF95jOYxS3xJ4s5ZyV3eklDMu4Csz m6DVc8CAO38aVxlImsSinlm1Vw== X-Received: by 2002:a05:651c:1249:: with SMTP id h9mr16891980ljh.127.1643728259886; Tue, 01 Feb 2022 07:10:59 -0800 (PST) Received: from eriador.lan ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id y6sm1337723lfk.157.2022.02.01.07.10.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 07:10:59 -0800 (PST) From: Dmitry Baryshkov To: Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar Subject: [PATCH 2/6] drm/msm/dpu: remove always-true argument of dpu_core_irq_read() Date: Tue, 1 Feb 2022 18:10:52 +0300 Message-Id: <20220201151056.2480055-3-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220201151056.2480055-1-dmitry.baryshkov@linaro.org> References: <20220201151056.2480055-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The argument clear of the function dpu_core_irq_read() is always true. Remove it. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 4 +--- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 4 ++-- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h index 7023ccb79814..6dce5d89f817 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h @@ -33,13 +33,11 @@ irqreturn_t dpu_core_irq(struct msm_kms *kms); * dpu_core_irq_read - IRQ helper function for reading IRQ status * @dpu_kms: DPU handle * @irq_idx: irq index - * @clear: True to clear the irq after read * @return: non-zero if irq detected; otherwise no irq detected */ u32 dpu_core_irq_read( struct dpu_kms *dpu_kms, - int irq_idx, - bool clear); + int irq_idx); /** * dpu_core_irq_register_callback - For registering callback function on IRQ diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 1e648db439f9..5576b8a3e6ee 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -301,8 +301,7 @@ int dpu_encoder_helper_wait_for_irq(struct dpu_encoder_phys *phys_enc, wait_info); if (ret <= 0) { - irq_status = dpu_core_irq_read(phys_enc->dpu_kms, - irq->irq_idx, true); + irq_status = dpu_core_irq_read(phys_enc->dpu_kms, irq->irq_idx); if (irq_status) { unsigned long flags; diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c index 71882d3fe705..85404c9ab4e1 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c @@ -357,7 +357,7 @@ static void dpu_disable_all_irqs(struct dpu_kms *dpu_kms) wmb(); } -u32 dpu_core_irq_read(struct dpu_kms *dpu_kms, int irq_idx, bool clear) +u32 dpu_core_irq_read(struct dpu_kms *dpu_kms, int irq_idx) { struct dpu_hw_intr *intr = dpu_kms->hw_intr; int reg_idx; @@ -384,7 +384,7 @@ u32 dpu_core_irq_read(struct dpu_kms *dpu_kms, int irq_idx, bool clear) intr_status = DPU_REG_READ(&intr->hw, dpu_intr_set[reg_idx].status_off) & DPU_IRQ_MASK(irq_idx); - if (intr_status && clear) + if (intr_status) DPU_REG_WRITE(&intr->hw, dpu_intr_set[reg_idx].clr_off, intr_status);