| Message ID | 20220210114106.290669-3-vkoul@kernel.org |
|---|---|
| State | Accepted |
| Commit | 07567d596eb0ad0f736fce4efa98af4d7b015799 |
| Headers | show |
| Series | [1/3] drm/msm/dpu: Remove set but unused variables | expand |
On 10/02/2022 14:41, Vinod Koul wrote: > dpu_core_irq_callback_handler() function comments seem to have become > stale and emit a warning: > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147: > warning: Function parameter or member 'dpu_kms' not described in 'dpu_core_irq_callback_handler' > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147: > warning: Excess function parameter 'arg' description in 'dpu_core_irq_callback_handler' > > Fix by updating the documentation > > Signed-off-by: Vinod Koul <vkoul@kernel.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > index 9341c88a336f..27073fd49fee 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > @@ -140,7 +140,7 @@ static const struct dpu_intr_reg dpu_intr_set[] = { > > /** > * dpu_core_irq_callback_handler - dispatch core interrupts > - * @arg: private data of callback handler > + * @dpu_kms: Pointer to DPU's KMS structure > * @irq_idx: interrupt index > */ > static void dpu_core_irq_callback_handler(struct dpu_kms *dpu_kms, int irq_idx)
On 2/10/2022 3:41 AM, Vinod Koul wrote: > dpu_core_irq_callback_handler() function comments seem to have become > stale and emit a warning: > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147: > warning: Function parameter or member 'dpu_kms' not described in 'dpu_core_irq_callback_handler' > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147: > warning: Excess function parameter 'arg' description in 'dpu_core_irq_callback_handler' > > Fix by updating the documentation > > Signed-off-by: Vinod Koul <vkoul@kernel.org> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > index 9341c88a336f..27073fd49fee 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > @@ -140,7 +140,7 @@ static const struct dpu_intr_reg dpu_intr_set[] = { > > /** > * dpu_core_irq_callback_handler - dispatch core interrupts > - * @arg: private data of callback handler > + * @dpu_kms: Pointer to DPU's KMS structure > * @irq_idx: interrupt index > */ > static void dpu_core_irq_callback_handler(struct dpu_kms *dpu_kms, int irq_idx)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c index 9341c88a336f..27073fd49fee 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c @@ -140,7 +140,7 @@ static const struct dpu_intr_reg dpu_intr_set[] = { /** * dpu_core_irq_callback_handler - dispatch core interrupts - * @arg: private data of callback handler + * @dpu_kms: Pointer to DPU's KMS structure * @irq_idx: interrupt index */ static void dpu_core_irq_callback_handler(struct dpu_kms *dpu_kms, int irq_idx)
dpu_core_irq_callback_handler() function comments seem to have become stale and emit a warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147: warning: Function parameter or member 'dpu_kms' not described in 'dpu_core_irq_callback_handler' drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147: warning: Excess function parameter 'arg' description in 'dpu_core_irq_callback_handler' Fix by updating the documentation Signed-off-by: Vinod Koul <vkoul@kernel.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)