From patchwork Thu Jun 5 07:52:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramana Radhakrishnan X-Patchwork-Id: 31401 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f71.google.com (mail-oa0-f71.google.com [209.85.219.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 0056D203AC for ; Thu, 5 Jun 2014 07:53:12 +0000 (UTC) Received: by mail-oa0-f71.google.com with SMTP id m1sf3287601oag.6 for ; Thu, 05 Jun 2014 00:53:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:message-id:date:from:user-agent:mime-version:to :subject:x-original-sender:x-original-authentication-results :content-type; bh=MpxBXbO+XEuBhVv40fbgtHmwzrl8xKCd/VgLQ624+HM=; b=KNQwap7rQr8kZlpUThZrvRNZ+s9UC4bEOiS+n5iGnLu5uVkAdzYtCg1YvGWjk34XFT Gp+r0bRdUdy4Gw0PK51WMBDI3ALlYNFEnx5WRrz1/9qLVcVuvcUslerRwCpb8/A0ngYO SGCQPe1MeLHJpde3OCeWSUJq1eTcswjXdSzi1vlRmZycPUXzh8tFRMzIB6JrnZtGZ/sc NBijTtX18ORrEY+nCP7bnkRG8eE0KzVl+bQKgNBK8gJUH/f8hRWMYz1yIfCRV+aT7+MZ 8jgCkhQQBXgB1zEX4mT6IN9WutSJH3YUewf8FxYSN7d+2cpUcvz4258rZ23gWnDM+mrt wg2A== X-Gm-Message-State: ALoCoQlaX9TDTbrhBs2NBic1YCsuTpLYFfPSirDsB8zQ7Dt0Nnfr2mKgSkCS/h/Unpg6MHL7PkBM X-Received: by 10.50.6.80 with SMTP id y16mr5324473igy.1.1401954792268; Thu, 05 Jun 2014 00:53:12 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.93.115 with SMTP id c106ls25596qge.55.gmail; Thu, 05 Jun 2014 00:53:12 -0700 (PDT) X-Received: by 10.220.161.8 with SMTP id p8mr48761521vcx.4.1401954792149; Thu, 05 Jun 2014 00:53:12 -0700 (PDT) Received: from mail-vc0-x22f.google.com (mail-vc0-x22f.google.com [2607:f8b0:400c:c03::22f]) by mx.google.com with ESMTPS id em7si3323261vdb.53.2014.06.05.00.53.12 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 05 Jun 2014 00:53:12 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c03::22f as permitted sender) client-ip=2607:f8b0:400c:c03::22f; Received: by mail-vc0-f175.google.com with SMTP id lc6so720022vcb.20 for ; Thu, 05 Jun 2014 00:53:12 -0700 (PDT) X-Received: by 10.52.227.138 with SMTP id sa10mr41059892vdc.25.1401954792031; Thu, 05 Jun 2014 00:53:12 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp106104vcb; Thu, 5 Jun 2014 00:53:11 -0700 (PDT) X-Received: by 10.68.242.135 with SMTP id wq7mr73963297pbc.147.1401954790978; Thu, 05 Jun 2014 00:53:10 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id ay4si11240762pbc.122.2014.06.05.00.53.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jun 2014 00:53:10 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-369508-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 806 invoked by alias); 5 Jun 2014 07:52:57 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 793 invoked by uid 89); 5 Jun 2014 07:52:56 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: collaborate-mta1.arm.com Received: from fw-tnat.austin.arm.com (HELO collaborate-mta1.arm.com) (217.140.110.23) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jun 2014 07:52:54 +0000 Received: from [10.1.209.147] (e104577-lin.cambridge.arm.com [10.1.209.147]) by collaborate-mta1.arm.com (Postfix) with ESMTPS id 83D7813F796 for ; Thu, 5 Jun 2014 02:52:52 -0500 (CDT) Message-ID: <539021D3.6090102@arm.com> Date: Thu, 05 Jun 2014 08:52:51 +0100 From: Ramana Radhakrishnan User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org ;" Subject: [Patch ARM] Fix bootstrap issue with thumb state + neon. X-IsSubscribed: yes X-Original-Sender: ramana.radhakrishnan@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c03::22f as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 Hi, In certain configurations of our auto-testers bootstrap fails because the enabled attribute depends on "opt_enabled" which is driven by state that is not constant for a compilation unit. We probably need a hot/ cold alternative which may be useful per insn. For now, work around this till we know if we really need this attribute on these patterns and what the impact in reality is. Bootstrapped , tested and applied to trunk. Ramana * config/arm/arm.md (enabled): Disable opt_enabled. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 2efa59f..484b0c0 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +2014-06-03 Ramana Radhakrishnan + + * config/arm/arm.md (enabled): Remove opt_enabled. + 2014-06-02 Ramana Radhakrishnan PR target/61154 diff --git a/gcc/config/arm/arm.md b/gcc/config/arm/arm.md index bec889a..f58a79b 100644 --- a/gcc/config/arm/arm.md +++ b/gcc/config/arm/arm.md @@ -201,6 +201,17 @@ (const_string "no"))) ; Enable all alternatives that are both arch_enabled and insn_enabled. +; FIXME:: opt_enabled has been temporarily removed till the time we have +; an attribute that allows the use of such alternatives. +; This depends on caching of speed_p, size_p on a per +; alternative basis. The problem is that the enabled attribute +; cannot depend on any state that is not cached or is not constant +; for a compilation unit. We probably need a generic "hot/cold" +; alternative which if implemented can help with this. We disable this +; until such a time as this is implemented and / or the improvements or +; regressions with removing this attribute are double checked. +; See ashldi3_neon and di3_neon in neon.md. + (define_attr "enabled" "no,yes" (cond [(and (eq_attr "predicable_short_it" "no") (and (eq_attr "predicated" "yes") @@ -216,9 +227,6 @@ (const_string "no") (eq_attr "arch_enabled" "no") - (const_string "no") - - (eq_attr "opt_enabled" "no") (const_string "no")] (const_string "yes")))