From patchwork Tue Oct 20 10:59:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyrylo Tkachov X-Patchwork-Id: 55300 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by patches.linaro.org (Postfix) with ESMTPS id 4ED3B22EA2 for ; Tue, 20 Oct 2015 10:59:46 +0000 (UTC) Received: by wikv3 with SMTP id v3sf7859450wik.1 for ; Tue, 20 Oct 2015 03:59:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding:x-original-sender :x-original-authentication-results; bh=ftoH1nRB06B4OGGlpZpcvWzl1Jr3W4/P4/5HOxDCrlo=; b=PS47g0VuIwxPj9ivrovltwDNFZiGoJ/Xkq8lgWk/sa7UGZtrLSMCd56h/0FQQjf/wl +GN/kl94kFTv4BdyzMzOyz3PKYRnmwOqgRx42ckz6ABFO0gwBdX5xdAfzzrq9yUiFlZq pY+ezJJH3uyNJXmLM624ytoUE8wcKjAKCdzAvA7aa9gsZE5GQL0EyuwBPE8PasUu88/x gVp1TgYtnjYbTm3qovwJYax3WRcboHzOsob6h979lFfpGndh+ZglN4pbSkQZ14CW+sKQ q7oIiUXhg9qKk6y83LfWw4NIa/uo3L/zmi4LPMIUjVbBWuycOX0zdexhJOdLfW6SUZoz r5dg== X-Gm-Message-State: ALoCoQkqri4fBqEVaxyZ8Dd38fwUXbF6ztIvrcbsUG+DiFgxVvdtrfeRqjvmDXQvaF5qdaae4FdJ X-Received: by 10.112.55.69 with SMTP id q5mr495163lbp.24.1445338785496; Tue, 20 Oct 2015 03:59:45 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.25.211.137 with SMTP id k131ls63025lfg.53.gmail; Tue, 20 Oct 2015 03:59:45 -0700 (PDT) X-Received: by 10.25.211.85 with SMTP id k82mr936312lfg.100.1445338785359; Tue, 20 Oct 2015 03:59:45 -0700 (PDT) Received: from mail-lb0-x234.google.com (mail-lb0-x234.google.com. [2a00:1450:4010:c04::234]) by mx.google.com with ESMTPS id w11si1824778lfd.40.2015.10.20.03.59.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2015 03:59:45 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::234 as permitted sender) client-ip=2a00:1450:4010:c04::234; Received: by lbbec13 with SMTP id ec13so9843698lbb.0 for ; Tue, 20 Oct 2015 03:59:45 -0700 (PDT) X-Received: by 10.112.161.168 with SMTP id xt8mr1397420lbb.88.1445338785188; Tue, 20 Oct 2015 03:59:45 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp2007380lbq; Tue, 20 Oct 2015 03:59:44 -0700 (PDT) X-Received: by 10.107.47.37 with SMTP id j37mr2931755ioo.173.1445338784191; Tue, 20 Oct 2015 03:59:44 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id l1si2373051igx.70.2015.10.20.03.59.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2015 03:59:44 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-410629-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 70351 invoked by alias); 20 Oct 2015 10:59:32 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 70336 invoked by uid 89); 20 Oct 2015 10:59:31 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL, BAYES_50, SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Oct 2015 10:59:30 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-35-3Ukm47PZSz-1Ik51epgE7g-1; Tue, 20 Oct 2015 11:59:24 +0100 Received: from [10.2.207.50] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 20 Oct 2015 11:59:23 +0100 Message-ID: <56261E8B.9000107@arm.com> Date: Tue, 20 Oct 2015 11:59:23 +0100 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Evandro Menezes , gcc-patches@gcc.gnu.org CC: Marcus.Shawcroft@arm.com Subject: Re: [PATCH][AArch64] Fix insn types References: <56255B1F.1010508@samsung.com> In-Reply-To: <56255B1F.1010508@samsung.com> X-MC-Unique: 3Ukm47PZSz-1Ik51epgE7g-1 X-IsSubscribed: yes X-Original-Sender: kyrylo.tkachov@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::234 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 Hi Evandro, On 19/10/15 22:05, Evandro Menezes wrote: > The type assigned to some insn definitions was seemingly not correct: > > * "movi %d0, %1" was of type "fmov" > * "fmov %s0, wzr" was of type "fconstd" > * "mov %0, {-1,1}" were of type "csel" > > This patch changes their types to: > > * "movi %d0, %1" to type "neon_move" > * "fmov %s0, wzr" to type "f_mcr" > * "mov %0, {-1,1}" to type "mov_imm" > > Please, commit if it's alright. > > Thank you, > Looking at your ChangeLog... gcc/ * config/aarch64/aarch64.md (*movdi_aarch64): Change the type of "movi %d0, %1" to "neon_move". (*movtf_aarch64): Change the type of "fmov %s0, wzr" to "f_mcr". (*cmov_insn): Change the types of "mov %0, {-1,1}" to "mov_imm". (*cmovsi_insn_uxtw): Idem The preferred form is "Likewise" rather than "Idem" AFAIK. Also, full stop at the end. I don't think this matches up with your changelog entry. This isn't the *movdi_aarch64 pattern. From what I can see the *movdi_aarch64 pattern already has the type neon_move on the movi\\t%d0, %1 alternative (the last one). In fact, if I apply your patch using "patch -p1" I see it being applied to the *movhf_aarch64 pattern. Is that what you intended? Thanks, Kyrill --- a/gcc/config/aarch64/aarch64.md +++ b/gcc/config/aarch64/aarch64.md @@ -1130,7 +1130,7 @@ ldrh\\t%w0, %1 strh\\t%w1, %0 mov\\t%w0, %w1" - [(set_attr "type" "neon_from_gp,neon_to_gp,fmov,\ + [(set_attr "type" "neon_from_gp,neon_to_gp,neon_move,\ f_loads,f_stores,load1,store1,mov_reg") (set_attr "simd" "yes,yes,yes,*,*,*,*,*") (set_attr "fp" "*,*,*,yes,yes,*,*,*")]