From patchwork Mon Nov 2 11:36:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyrylo Tkachov X-Patchwork-Id: 55872 Delivered-To: patch@linaro.org Received: by 10.112.61.134 with SMTP id p6csp1217461lbr; Mon, 2 Nov 2015 03:36:37 -0800 (PST) X-Received: by 10.66.156.135 with SMTP id we7mr23588558pab.89.1446464197640; Mon, 02 Nov 2015 03:36:37 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id tn5si34385911pbc.139.2015.11.02.03.36.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Nov 2015 03:36:37 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-412335-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-return-412335-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-412335-patch=linaro.org@gcc.gnu.org; dkim=pass header.i=@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=dQSer4qNqIBdPT9Hs Q8bW+XhqpT6en9YNpYU5CfO5qN9YkH7IovvIciFqp5wOq/gT7sQpa3GeuYyaDNHC 13c2G3Bd7tx+3/jYzCFHumEoOuT3SM2FJey/PriBoCX+AuFbEfWSC6+DPVtN2Bu2 gGjdM6ME9UmvGB/XcNjdx8qkjc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=WAQT3bWHtzxwkpgC3A90Mch Og34=; b=QuaWRj9We0Rk4kdPwZKy6bepSDTMQk3hoGxl4gZuW9qe7nYQIhWFzvx 0QOPG5DttirrbSXiBAyfbD1kcfwYtF1gCNPmokY/rgBy7RbUblG86TSjDT7lyXj7 cYY8yP1NiDWqdE5TE0pmcYxymv612qbrIWJEHlQZB2EnjWSCu5Qs= Received: (qmail 82185 invoked by alias); 2 Nov 2015 11:36:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 82172 invoked by uid 89); 2 Nov 2015 11:36:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Nov 2015 11:36:18 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-17-tIun3Yn5Rri884t5GplGmA-1; Mon, 02 Nov 2015 11:36:12 +0000 Received: from [10.2.206.200] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 2 Nov 2015 11:36:12 +0000 Message-ID: <56374AAC.1010505@arm.com> Date: Mon, 02 Nov 2015 11:36:12 +0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Yvan Roux , Ramana Radhakrishnan CC: Christophe Lyon , GCC Patches , Ramana Radhakrishnan , Richard Earnshaw Subject: Re: [PATCH][ARM] PR target/67929 Tighten vfp3_const_double_for_bits checks References: <561E4941.6030204@arm.com> <563720F1.3070903@foss.arm.com> <56372BDD.7060005@foss.arm.com> <56372D16.4020103@arm.com> In-Reply-To: <56372D16.4020103@arm.com> X-MC-Unique: tIun3Yn5Rri884t5GplGmA-1 X-IsSubscribed: yes On 02/11/15 09:29, Kyrill Tkachov wrote: > > On 02/11/15 09:28, Yvan Roux wrote: >> On 2 November 2015 at 10:24, Ramana Radhakrishnan >> wrote: >>> >>> On 02/11/15 09:01, Christophe Lyon wrote: >>>> On 2 November 2015 at 09:51, Yvan Roux wrote: >>>>> On 2 November 2015 at 09:38, Ramana Radhakrishnan >>>>> wrote: >>>>>>>>> 2015-10-12 Kyrylo Tkachov >>>>>>>>> >>>>>>>>> PR target/67929 >>>>>>>>> * gcc.target/arm/pr67929_1.c: New test. >>>>>>> This test fails when tested on hard-float targets, adding the >>>>>>> following line to avoid testing it in such cases will fix the issue, >>>>>>> but I wonder if there is a better dejaGNU directives sequence to do >>>>>>> that. >>>>>>> >>>>>>> /* { dg-skip-if "avoid conflicting multilib options" { *-*-*eabihf } { >>>>>>> "*" } { "" } } */ >>>>>> No, not without further investigation into why the test is failing. >>>>> Sorry, it fails because of the ABI mismatch between the built libs for >>>>> HF targets and the testcase which is built with the flag >>>>> -mfloat-abi=softfp (which is added by the directive arm_vfpv3_ok) >>>>> >>>> I think that's what I meant in: >>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67929#c7 >>> Ah, I see what you mean - instead I would just remove all the special options and move this test into gcc.c-torture/execute. >>> >>> There are enough testers that test by default to armhf now for us to be worried about testing the exact combination. >> Ha yes that's ture and I remember that we ended to that same >> conclusion for one testcase I tried to find the exact float ABI flag >> combination several months ago. > > Ok, moving the test to the torture suite sounds best. > I'll prepare a patch. > Is this proposed patch ok to commit? It moves the test and adds noclone and noinline attributes to 'foo' like Richard suggested. 2015-11-01 Kyrylo Tkachov PR target/67929 * gcc.target/arm/pr67929_1.c: Move to... * gcc.c-torture/execute/pr67929_1.c: ... Here. Remove arm-specific directives. Add noclone, noinline attributes. Thanks, Kyrill > Sorry for the trouble, > Kyrill > >> >> >> Yvan >>> regards >>> Ramana >>> >>>> Christophe. >>>> >>>>> Yvan >>>>> >>>>>> regards >>>>>> Ramana >>>>>> >>>>>>> Cheers, >>>>>>> Yvan >>>>>>> > commit f7da7437733ea999c09806c593d9b253fd2ba324 Author: Kyrylo Tkachov Date: Mon Nov 2 11:16:57 2015 +0000 Move gcc.target/arm/pr67929_1.c test to execute.exp diff --git a/gcc/testsuite/gcc.c-torture/execute/pr67929_1.c b/gcc/testsuite/gcc.c-torture/execute/pr67929_1.c new file mode 100644 index 0000000..ae6cfbf --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/pr67929_1.c @@ -0,0 +1,15 @@ +int __attribute__ ((noinline, noclone)) +foo (float a) +{ + return a * 4.9f; +} + + +int +main (void) +{ + if (foo (10.0f) != 49) + __builtin_abort (); + + return 0; +} diff --git a/gcc/testsuite/gcc.target/arm/pr67929_1.c b/gcc/testsuite/gcc.target/arm/pr67929_1.c deleted file mode 100644 index 14943b6..0000000 --- a/gcc/testsuite/gcc.target/arm/pr67929_1.c +++ /dev/null @@ -1,21 +0,0 @@ -/* { dg-do run } */ -/* { dg-require-effective-target arm_vfp3_ok } */ -/* { dg-options "-O2 -fno-inline" } */ -/* { dg-add-options arm_vfp3 } */ -/* { dg-skip-if "need fp instructions" { *-*-* } { "-mfloat-abi=soft" } { "" } } */ - -int -foo (float a) -{ - return a * 4.9f; -} - - -int -main (void) -{ - if (foo (10.0f) != 49) - __builtin_abort (); - - return 0; -} \ No newline at end of file