From patchwork Thu May 5 13:00:53 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramana Radhakrishnan X-Patchwork-Id: 1353 Return-Path: Delivered-To: unknown Received: from imap.gmail.com (74.125.159.109) by localhost6.localdomain6 with IMAP4-SSL; 08 Jun 2011 14:51:18 -0000 Delivered-To: patches@linaro.org Received: by 10.224.184.145 with SMTP id ck17cs97505qab; Thu, 5 May 2011 06:00:55 -0700 (PDT) Received: by 10.224.188.212 with SMTP id db20mr2326742qab.141.1304600455198; Thu, 05 May 2011 06:00:55 -0700 (PDT) Received: from mail-qw0-f50.google.com (mail-qw0-f50.google.com [209.85.216.50]) by mx.google.com with ESMTPS id g24si4863947qck.156.2011.05.05.06.00.55 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 05 May 2011 06:00:55 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.216.50 is neither permitted nor denied by best guess record for domain of ramana.radhakrishnan@linaro.org) client-ip=209.85.216.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.216.50 is neither permitted nor denied by best guess record for domain of ramana.radhakrishnan@linaro.org) smtp.mail=ramana.radhakrishnan@linaro.org Received: by qwe5 with SMTP id 5so1660946qwe.37 for ; Thu, 05 May 2011 06:00:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.181.142 with SMTP id by14mr2214792qab.122.1304600454857; Thu, 05 May 2011 06:00:54 -0700 (PDT) Received: by 10.224.67.75 with HTTP; Thu, 5 May 2011 06:00:53 -0700 (PDT) In-Reply-To: <1300979471.12868.88.camel@e102346-lin.cambridge.arm.com> References: <4D861AF7.2000903@linaro.org> <1300979471.12868.88.camel@e102346-lin.cambridge.arm.com> Date: Thu, 5 May 2011 14:00:53 +0100 Message-ID: Subject: Re: [Patch ARM] PR47930 Fix documentation for marm / mthumb From: Ramana Radhakrishnan To: Richard Earnshaw Cc: gcc-patches , patches@linaro.org > The arm.opt change is OK, but 'Report' should stay; and it should also > be added to the -marm case. Ok with this change ? Rebuilt docs and built a cross with arm-linux-gnueabi ? 2011-05-05 Ramana Radhakrishnan PR target/47930 * config/arm/arm.opt (marm): Document it. (mthumb): Reject negative variant. cheers Ramana > > R. > > > Index: gcc/doc/invoke.texi =================================================================== --- gcc/doc/invoke.texi (revision 173422) +++ gcc/doc/invoke.texi (working copy) @@ -10282,16 +10282,16 @@ and has length @code{((pc[-3]) & 0xff000000)}. @item -mthumb +@itemx -marm +@opindex marm @opindex mthumb -Generate code for the Thumb instruction set. The default is to -use the 32-bit ARM instruction set. -This option automatically enables either 16-bit Thumb-1 or -mixed 16/32-bit Thumb-2 instructions based on the @option{-mcpu=@var{name}} -and @option{-march=@var{name}} options. This option is not passed to the -assembler. If you want to force assembler files to be interpreted as Thumb code, -either add a @samp{.thumb} directive to the source or pass the @option{-mthumb} -option directly to the assembler by prefixing it with @option{-Wa}. +Select between generating code that executes in ARM and Thumb +states. The default for most configurations is to generate code +that executes in ARM state, but the default can be changed by +configuring GCC with the @option{--with-mode=}@var{state} +configure option. + @item -mtpcs-frame @opindex mtpcs-frame Generate a stack frame that is compliant with the Thumb Procedure Call Index: gcc/config/arm/arm.opt =================================================================== --- gcc/config/arm/arm.opt (revision 173422) +++ gcc/config/arm/arm.opt (working copy) @@ -52,7 +52,8 @@ Specify the name of the target architecture marm -Target RejectNegative InverseMask(THUMB) Undocumented +Target Report RejectNegative InverseMask(THUMB) +Generate code in 32 bit ARM state. mbig-endian Target Report RejectNegative Mask(BIG_END) @@ -131,8 +132,8 @@ Specify the minimum bit alignment of structures mthumb -Target Report Mask(THUMB) -Compile for the Thumb not the ARM +Target Report RejectNegative Mask(THUMB) +Generate code for Thumb state mthumb-interwork Target Report Mask(INTERWORK)