From patchwork Fri Jan 16 12:14:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prathamesh Kulkarni X-Patchwork-Id: 43236 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-we0-f198.google.com (mail-we0-f198.google.com [74.125.82.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 234C4240BA for ; Fri, 16 Jan 2015 12:14:42 +0000 (UTC) Received: by mail-we0-f198.google.com with SMTP id q59sf10876471wes.1 for ; Fri, 16 Jan 2015 04:14:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:mime-version:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-original-sender :x-original-authentication-results; bh=2VZdAAw1XLVvvYPc8Bh+A4rvfOsCX1fkpSfMW01AOjk=; b=Uh+WMEMyVDQyeCAWC4gVMjb2owfDv6NR+4zR+jxK4bI4Uy8jlioGEJ//Y3gtoY1Beb 9uo0PMq++gFZ8pE0WsrspFw+ZzyvWPz4R0cwNWKdS/BOc3R5NS2npcvogX6nzp5hr4fI K7dUjVtA4+Is+yMGfwjE9Ja1Wp7GOtDWyt5KUmmEF+y2QaWXezRJzNOdU47TAwb1WUoW 4tO6nRsq4+E//xGhHHc6T/DwfbVz+LMKThS0q62q9//VpHj/XEnrlJfLtRPXhbnsuWnM 3+i2Hq+fNupDXS2MCeRkeZxCRXZ+XhBSRMCy5K5ld1LKe3k8Rp6x8ln1N2Ppzn/Gt9VR +TCg== X-Gm-Message-State: ALoCoQmDGl5YqUiAllN2sRcK312/cxUXDrQrzxnS9nBwva9RWd3p1LFvSFuiTTrP4de1BI3oZZvV X-Received: by 10.152.235.35 with SMTP id uj3mr230296lac.3.1421410481432; Fri, 16 Jan 2015 04:14:41 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.42.234 with SMTP id r10ls291407lal.17.gmail; Fri, 16 Jan 2015 04:14:41 -0800 (PST) X-Received: by 10.112.14.134 with SMTP id p6mr15633729lbc.36.1421410481286; Fri, 16 Jan 2015 04:14:41 -0800 (PST) Received: from mail-lb0-x229.google.com (mail-lb0-x229.google.com. [2a00:1450:4010:c04::229]) by mx.google.com with ESMTPS id h3si4301181lam.29.2015.01.16.04.14.41 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 16 Jan 2015 04:14:41 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::229 as permitted sender) client-ip=2a00:1450:4010:c04::229; Received: by mail-lb0-f169.google.com with SMTP id p9so18158715lbv.0 for ; Fri, 16 Jan 2015 04:14:41 -0800 (PST) X-Received: by 10.112.14.6 with SMTP id l6mr15328806lbc.91.1421410481074; Fri, 16 Jan 2015 04:14:41 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.9.200 with SMTP id c8csp285189lbb; Fri, 16 Jan 2015 04:14:39 -0800 (PST) X-Received: by 10.70.140.72 with SMTP id re8mr12649759pdb.144.1421410478438; Fri, 16 Jan 2015 04:14:38 -0800 (PST) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id ct2si5399255pbb.21.2015.01.16.04.14.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Jan 2015 04:14:38 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-389522-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 16093 invoked by alias); 16 Jan 2015 12:14:24 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 15938 invoked by uid 89); 16 Jan 2015 12:14:23 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f175.google.com Received: from mail-lb0-f175.google.com (HELO mail-lb0-f175.google.com) (209.85.217.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 16 Jan 2015 12:14:19 +0000 Received: by mail-lb0-f175.google.com with SMTP id z11so18187333lbi.6 for ; Fri, 16 Jan 2015 04:14:15 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.152.238.1 with SMTP id vg1mr15363623lac.83.1421410455698; Fri, 16 Jan 2015 04:14:15 -0800 (PST) Received: by 10.25.211.16 with HTTP; Fri, 16 Jan 2015 04:14:15 -0800 (PST) In-Reply-To: References: Date: Fri, 16 Jan 2015 12:14:15 +0000 Message-ID: Subject: Re: [match-and-simplify] Remove printing "for expression" From: Prathamesh Kulkarni To: Richard Biener Cc: gcc Patches X-IsSubscribed: yes X-Original-Sender: prathamesh.kulkarni@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::229 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 On 12 January 2015 at 08:46, Richard Biener wrote: > On Sat, 10 Jan 2015, Prathamesh Kulkarni wrote: > >> On 8 January 2015 at 17:52, Richard Biener wrote: >> > On Sun, 21 Dec 2014, Prathamesh Kulkarni wrote: >> > >> >> Hi, >> >> I removed printing "for expression:" from print_matches. I think it >> >> is out of place tvim here and we call print_matches after lowering. >> >> OK to commit ? >> > >> > Hum, it's now a very simple wrapper around print_operand - why >> > not replace the two callers with its content? >> Indeed. Done the changes in the attached patch. > > Doesn't that miss the '\n' putc? Added in this patch. OK to commit ? Thanks, Prathamesh > > Thanks, > Richard. > >> OK to commit to match-and-simplify branch ? >> >> Thanks, >> Prathamesh >> > >> > Thanks, >> > Richard. >> > >> >> Thanks, >> >> Prathamesh >> >> >> > >> > -- >> > Richard Biener >> > SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Jennifer Guild, >> > Dilip Upmanyu, Graham Norton HRB 21284 (AG Nuernberg) >> > > -- > Richard Biener > SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Jennifer Guild, > Dilip Upmanyu, Graham Norton HRB 21284 (AG Nuernberg) 2015-01-16 Prathamesh Kulkarni * genmatch.c (print_matches): Remove. (main): Inline calls to print_matches. Index: gcc/genmatch.c =================================================================== --- gcc/genmatch.c (revision 219718) +++ gcc/genmatch.c (working copy) @@ -644,15 +644,6 @@ gcc_unreachable (); } -DEBUG_FUNCTION void -print_matches (struct simplify *s, FILE *f = stderr) -{ - fprintf (f, "for expression: "); - print_operand (s->match, f); - putc ('\n', f); -} - - /* AST lowering. */ /* Lowering of commutative operators. */ @@ -3679,8 +3670,10 @@ if (verbose) for (unsigned i = 0; i < pred->matchers.length (); ++i) - print_matches (pred->matchers[i]); - + { + print_operand (pred->matchers[i]->match); + putc ('\n', stderr); + } decision_tree dt; for (unsigned i = 0; i < pred->matchers.length (); ++i) dt.insert (pred->matchers[i], i); @@ -3696,7 +3689,10 @@ if (verbose) for (unsigned i = 0; i < p.simplifiers.length (); ++i) - print_matches (p.simplifiers[i]); + { + print_operand (p.simplifiers[i]->match); + putc ('\n', stderr); + } decision_tree dt; for (unsigned i = 0; i < p.simplifiers.length (); ++i)