From patchwork Thu Jan 22 20:58:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prathamesh Kulkarni X-Patchwork-Id: 43542 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f69.google.com (mail-wg0-f69.google.com [74.125.82.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id B5C88218DB for ; Thu, 22 Jan 2015 20:58:45 +0000 (UTC) Received: by mail-wg0-f69.google.com with SMTP id x12sf2266119wgg.0 for ; Thu, 22 Jan 2015 12:58:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:mime-version:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-original-sender :x-original-authentication-results; bh=gdjyl0RHQ47jtNERrU6z0w0CcZonxc6xFyup9hsSGFI=; b=XQyRkiMtIKjcVQbiXNNN/px7f5GLsHaY0coy4ud0buLV1+m+M+ssVDJf0SFenQTeeq 4PyVjBaJkPYBhw2OsPLxmNQVHRIzzwBZam6n1LdqOy2wC0ndg0V5MUhRh1gwyMvrRIxv zCVJhhAg1h+o5rCg4C9yM/Vmj9pUc8Z9AAgkZP+avrwq4MzWxuYo8VJxzEYceSBQ9rcg EbsEuL/KZML8Q+Z0NrmBlpHwhD33mWfTGJrThpcKRbHSNB0qRpgqhZW2h7Lc1LhIwFCX a6ZLHpHlMcDMBIRuxZa2dcqXFCDxIvlwNvCX8JC47GmP7TZU3DosEH0p1wZsD7mdKky7 FOOg== X-Gm-Message-State: ALoCoQnKBzQWhAV2UgcK3TDtARUPr7DEIAK40HTiA+ogu0fvCaIHT9lNKDOlz6GTKZt9L6RaSs8C X-Received: by 10.180.108.197 with SMTP id hm5mr2599974wib.4.1421960325056; Thu, 22 Jan 2015 12:58:45 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.23.71 with SMTP id k7ls213863laf.9.gmail; Thu, 22 Jan 2015 12:58:44 -0800 (PST) X-Received: by 10.152.115.230 with SMTP id jr6mr3980681lab.2.1421960324874; Thu, 22 Jan 2015 12:58:44 -0800 (PST) Received: from mail-lb0-x235.google.com (mail-lb0-x235.google.com. [2a00:1450:4010:c04::235]) by mx.google.com with ESMTPS id ea10si21641161lbc.120.2015.01.22.12.58.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jan 2015 12:58:44 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::235 as permitted sender) client-ip=2a00:1450:4010:c04::235; Received: by mail-lb0-f181.google.com with SMTP id u10so3745260lbd.12 for ; Thu, 22 Jan 2015 12:58:44 -0800 (PST) X-Received: by 10.112.52.229 with SMTP id w5mr3910398lbo.52.1421960324672; Thu, 22 Jan 2015 12:58:44 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.9.200 with SMTP id c8csp22283lbb; Thu, 22 Jan 2015 12:58:43 -0800 (PST) X-Received: by 10.70.95.35 with SMTP id dh3mr5244666pdb.91.1421960321641; Thu, 22 Jan 2015 12:58:41 -0800 (PST) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id qt7si13617202pbc.63.2015.01.22.12.58.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jan 2015 12:58:41 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-390234-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 5679 invoked by alias); 22 Jan 2015 20:58:27 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 5667 invoked by uid 89); 22 Jan 2015 20:58:26 -0000 X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-la0-f46.google.com Received: from mail-la0-f46.google.com (HELO mail-la0-f46.google.com) (209.85.215.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 22 Jan 2015 20:58:23 +0000 Received: by mail-la0-f46.google.com with SMTP id s18so3959166lam.5 for ; Thu, 22 Jan 2015 12:58:20 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.152.22.129 with SMTP id d1mr3954723laf.22.1421960300199; Thu, 22 Jan 2015 12:58:20 -0800 (PST) Received: by 10.25.211.16 with HTTP; Thu, 22 Jan 2015 12:58:19 -0800 (PST) In-Reply-To: <3450002.mYNjilJ0dL@polaris> References: <3450002.mYNjilJ0dL@polaris> Date: Fri, 23 Jan 2015 02:28:19 +0530 Message-ID: Subject: Re: flatten expr.h (version 2) From: Prathamesh Kulkarni To: Eric Botcazou Cc: gcc Patches , Richard Biener , Michael Collison , Andrew MacLeod X-IsSubscribed: yes X-Original-Sender: prathamesh.kulkarni@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::235 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 On 21 January 2015 at 23:18, Eric Botcazou wrote: >> Thanks. I had wrongly made eliminate_constant_term() static, reverted >> that change and it builds on >> all targets in config-list.mk. >> Committed as r219655 (hopefully nothing breaks!). > > Any particular reason why store_bit_field, extract_bit_field, extract_low_bits > expand_mult and expand_mult_highpart_adjust are declared in emit-rtl.h? Thanks, moved them to expmed.h. Boostrapped on x86_64-unknown-linux-gnu with languages: all, testing in progress. Build on all targets in config-list.mk in progress. Assuming it goes fine, OK to commit ? Thanks, Prathamesh > > -- > Eric Botcazou 2015-01-22 Prathamesh Kulkarni * emit-rtl.h (store_bit_field): Move prototype to expmed.h. (extract_bit_field): Likewise. (extract_low_bits): Likewise. (expand_mult): Likewise. (expand_mult_highpart_adjust): Likewise. Index: gcc/emit-rtl.h =================================================================== --- gcc/emit-rtl.h (revision 219882) +++ gcc/emit-rtl.h (working copy) @@ -189,17 +189,4 @@ MODE and adjusted by OFFSET. */ extern rtx widen_memory_access (rtx, machine_mode, HOST_WIDE_INT); -extern void store_bit_field (rtx, unsigned HOST_WIDE_INT, - unsigned HOST_WIDE_INT, - unsigned HOST_WIDE_INT, - unsigned HOST_WIDE_INT, - machine_mode, rtx); -extern rtx extract_bit_field (rtx, unsigned HOST_WIDE_INT, - unsigned HOST_WIDE_INT, int, rtx, - machine_mode, machine_mode); -extern rtx extract_low_bits (machine_mode, machine_mode, rtx); -extern rtx expand_mult (machine_mode, rtx, rtx, rtx, int); -extern rtx expand_mult_highpart_adjust (machine_mode, rtx, rtx, rtx, rtx, int); - - #endif /* GCC_EMIT_RTL_H */ Index: gcc/expmed.h =================================================================== --- gcc/expmed.h (revision 219882) +++ gcc/expmed.h (working copy) @@ -703,4 +703,16 @@ rtx, int); #endif +extern void store_bit_field (rtx, unsigned HOST_WIDE_INT, + unsigned HOST_WIDE_INT, + unsigned HOST_WIDE_INT, + unsigned HOST_WIDE_INT, + machine_mode, rtx); +extern rtx extract_bit_field (rtx, unsigned HOST_WIDE_INT, + unsigned HOST_WIDE_INT, int, rtx, + machine_mode, machine_mode); +extern rtx extract_low_bits (machine_mode, machine_mode, rtx); +extern rtx expand_mult (machine_mode, rtx, rtx, rtx, int); +extern rtx expand_mult_highpart_adjust (machine_mode, rtx, rtx, rtx, rtx, int); + #endif // EXPMED_H