From patchwork Fri Apr 10 11:51:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 47025 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 54496218D9 for ; Fri, 10 Apr 2015 12:16:34 +0000 (UTC) Received: by labgx2 with SMTP id gx2sf3957144lab.1 for ; Fri, 10 Apr 2015 05:16:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:mailing-list :precedence:list-id:list-unsubscribe:list-subscribe:list-archive :list-post:list-help:sender:delivered-to:from:to:subject:date :message-id:x-original-sender:x-original-authentication-results; bh=RqPQpe+43af2W5xTXwRyBl6Lfijv59YiWnEGpKwpICY=; b=cPc2RkBWeiJbem3fcPekONDLqTualF2C2xtqRCh0+ZWeaxPNztv0ef++tkZYeLqqqF RGUArFT+HCam5aMGvKz6MPqrORG2/PrtsfVTa2Srhd6lNAh+kMFt8DonxgAFOFvZQySs 7c/GSoCxKxjxuVrWRhYbhfYOV+yFPEE7BDdAfV8gpD7k1yTeoGGnBCu+gWXM2o3Li8Vq 9Orx08V5zRHDY/ay4oDDqFlvPkPsItrYPXDql2Q3lqO2+EbXB3PNspPc6es77MEUDmXS vntX+9RGKgt91vTQPexyBTeevdfoSDbA4RzjDJfp5dyYaktjtCdAzkDKIWNv9Mj9HAyz GVWw== X-Gm-Message-State: ALoCoQn90ckNwBdqBI+ctIEhhDZqu97dr1+DgM62MnW1fvnEBT3Pj/UpNqt/sef+bbl3v+cfKhsS X-Received: by 10.194.71.227 with SMTP id y3mr268734wju.3.1428668193298; Fri, 10 Apr 2015 05:16:33 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.30.37 with SMTP id p5ls452196lah.9.gmail; Fri, 10 Apr 2015 05:16:33 -0700 (PDT) X-Received: by 10.152.1.194 with SMTP id 2mr1211219lao.38.1428668193138; Fri, 10 Apr 2015 05:16:33 -0700 (PDT) Received: from mail-lb0-x236.google.com (mail-lb0-x236.google.com. [2a00:1450:4010:c04::236]) by mx.google.com with ESMTPS id is5si1335176lac.110.2015.04.10.05.16.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Apr 2015 05:16:33 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::236 as permitted sender) client-ip=2a00:1450:4010:c04::236; Received: by lbbqq2 with SMTP id qq2so11911695lbb.3 for ; Fri, 10 Apr 2015 05:16:33 -0700 (PDT) X-Received: by 10.112.141.202 with SMTP id rq10mr1201510lbb.88.1428668192998; Fri, 10 Apr 2015 05:16:32 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.67.65 with SMTP id l1csp1047355lbt; Fri, 10 Apr 2015 05:16:30 -0700 (PDT) X-Received: by 10.68.94.129 with SMTP id dc1mr2064679pbb.8.1428666692786; Fri, 10 Apr 2015 04:51:32 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id i9si2623993pdp.111.2015.04.10.04.51.31 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Apr 2015 04:51:32 -0700 (PDT) Received-SPF: pass (google.com: domain of gdb-patches-return-121785-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 81438 invoked by alias); 10 Apr 2015 11:51:24 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Subscribe: List-Archive: List-Post: , List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 81419 invoked by uid 89); 10 Apr 2015 11:51:23 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f50.google.com Received: from mail-pa0-f50.google.com (HELO mail-pa0-f50.google.com) (209.85.220.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 10 Apr 2015 11:51:22 +0000 Received: by paboj16 with SMTP id oj16so19562290pab.0 for ; Fri, 10 Apr 2015 04:51:20 -0700 (PDT) X-Received: by 10.66.227.169 with SMTP id sb9mr2027404pac.11.1428666676592; Fri, 10 Apr 2015 04:51:16 -0700 (PDT) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id cs17sm2070028pac.12.2015.04.10.04.51.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 10 Apr 2015 04:51:16 -0700 (PDT) From: Yao Qi To: gdb-patches@sourceware.org Subject: [RFC] Unset tcl variable addr to avoid clashing Date: Fri, 10 Apr 2015 12:51:11 +0100 Message-Id: <1428666671-12926-1-git-send-email-qiyaoltc@gmail.com> X-IsSubscribed: yes X-Original-Sender: qiyaoltc@gmail.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::236 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@sourceware.org; dmarc=fail (p=NONE dis=NONE) header.from=gmail.com X-Google-Group-Id: 836684582541 From: Yao Qi Hi, I see some tcl ERRORs in gdb.sum recently: ERROR: tcl error sourcing ../../../../../binutils-gdb/gdb/testsuite/gdb.base/dmsym.exp. ERROR: can't set "addr": variable is array while executing "set addr "0x\[0-9a-zA-Z\]+"" (file "../../../../../binutils-gdb/gdb/testsuite/gdb.base/dmsym.exp" line 45) invoked from within "source ../../../../../binutils-gdb/gdb/testsuite/gdb.base/dmsym.exp" ("uplevel" body line 1) invoked from within "uplevel #0 source ../../../../../binutils-gdb/gdb/testsuite/gdb.base/dmsym.exp" invoked from within "catch "uplevel #0 source $test_file_name"" It is OK to run single dmsym.exp. This error is caused by the name clashing with coredump-filter.exp, and it can be reproduced, $ make check RUNTESTFLAGS='coredump-filter.exp dmsym.exp exception.exp stepi-random-signal.exp' as variable addr is used in all of them. This patch is to unset array addr, but manually unset variables isn't good to me. Is there any approaches we can do to avoid name clashing? gdb/testsuite: 2015-04-10 Yao Qi * gdb.base/coredump-filter.exp: Unset addr. --- gdb/testsuite/gdb.base/coredump-filter.exp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gdb/testsuite/gdb.base/coredump-filter.exp b/gdb/testsuite/gdb.base/coredump-filter.exp index f3203be..2deb7b3 100644 --- a/gdb/testsuite/gdb.base/coredump-filter.exp +++ b/gdb/testsuite/gdb.base/coredump-filter.exp @@ -196,3 +196,5 @@ foreach item $all_anon_corefiles { with_test_prefix "loading and testing corefile for non-Private-Shared-Anon-File" { test_disasm $non_private_shared_anon_file_core $main_addr 1 } + +unset addr