From patchwork Sat May 4 00:05:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thiago Jung Bauermann X-Patchwork-Id: 794555 Delivered-To: patch@linaro.org Received: by 2002:adf:a153:0:b0:34d:5089:5a9e with SMTP id r19csp985821wrr; Fri, 3 May 2024 17:06:17 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXDZUgxRmNLhFTN7F3+H+KgSpRhuxCaK76MtH+lHnbEOZDXjg5G6rxQ2UGlzFgWd7Ep2MpI0O8JLcVCdC++z7gv X-Google-Smtp-Source: AGHT+IERSxrs2kKczhtA2Kt1AO7SX2oOZCIu0LB8Qcgq83sk2XWA1LJLf/DKRgMT2np7KbDsSxko X-Received: by 2002:ac8:5d8f:0:b0:43b:7:6456 with SMTP id d15-20020ac85d8f000000b0043b00076456mr4322231qtx.34.1714781177123; Fri, 03 May 2024 17:06:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714781177; cv=pass; d=google.com; s=arc-20160816; b=jqoUiyTDfGKG+fz7+YF8DCnzZhajiIEgnSeufRbIrQCTjB4A/B29FaQ2MvA/UPiFob jqkZzy0Sg7KCW/FtGkGWwzegrr8mOd8iXsOJOgqYed1+SXll7/uQ2EQBT3r4UhZX8Tyg ptaxeRm0Xv/0WeM3IbHUsNY9GgNWZZyKDRW+ghyAP1HOXP5wjNuKOJyn6Pw5bvJ9zfrJ N8E1so9lAG4w8X0g4H6Rbm41nyxsr7JPJAG2hpiGTi7LJBW7jRAhmcy8OEPL1hTAp5nS xYivxlkDWHLJ2XhXSi+Nm8yjhLaIcVgOlo9/fhwkXCsY8BDpqtwkaiNx51sKB+AGALFD fr+Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=lC+iKXqzQE4y6lKv4irPrPxbDt9vEwmTnGIJRFVo0M0=; fh=72kqq0iQhigvR9Vv/oqX5ebs3Yyyw7XhzWxOOEPdupI=; b=HIEDn4C6jbafqoNHi/4LUBMeR0n+glWEtecvj+yHScDcVYtMWEepctUwagshn7V/MK YwRy7YSAfq1gC+oFFEcs0g2yq26iKPizlvdK8oJn7IiJpNOi4J/l6N6AGVsAVgo3yPBw Ss/9jJNZ6vO8y+Oa9Yo+v4oTI+Ocj5WXzJAeL+RV6bkDryLPTlkMK3kFXK29ATQRDwtw 0HO85PMfKf0Baw2wDMMQBqFF3TCTkinZdX3qsu9RX9awmmm8iz3rdF8Qt3TUh+pXmMDf Fks3eyglwj4haqfcbKVOhuoLUiQ+Hbqz+nLZyBlRrgyq42myQ2vQbOZt7dq+7gd2ZzPv r6yQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HPtszVX8; arc=pass (i=1); spf=pass (google.com: domain of gdb-patches-bounces+patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gdb-patches-bounces+patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id f4-20020ac859c4000000b0043af4300510si4381741qtf.348.2024.05.03.17.06.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 May 2024 17:06:17 -0700 (PDT) Received-SPF: pass (google.com: domain of gdb-patches-bounces+patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HPtszVX8; arc=pass (i=1); spf=pass (google.com: domain of gdb-patches-bounces+patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gdb-patches-bounces+patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B0FDF3844040 for ; Sat, 4 May 2024 00:06:16 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 26FA1384404C for ; Sat, 4 May 2024 00:05:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26FA1384404C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 26FA1384404C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714781147; cv=none; b=VyGthXwajls664EdG47eRmGX7n0ZQ+5tneKd2pb9IeLGoWED7G1sm/MJJpFyqo55FzXZEJ4DEuVUWwLk8N8kjNulIBs6v+UE6e/Ey/wDHNyKI8wcmyNYYdcFfBQk6HDfEuoofA9e93VKAeX0uJ8jfk30E8Eg9E/dc1wgG437cMw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714781147; c=relaxed/simple; bh=f4Tiahh2xJZ0ucs5/3fb9UyTCLa/mYTUbXxJXfEC+tU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vdPYGa3BCmlLNdY5NNHATI7iAW3DRAz8lyXetCHHWQJ5Hu6sGZ8/AuBNANP3Yn/v96WrDBfkWDFJ+WpE6ZmY0ZMBnSARLEp0+j1+hl1+Ajji1gGVpA4eX0qiC5hbs2CMF22/tZmYFj+jAaBlqRZQfEF6hMNZJo4KM/qJJxvYjTw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so132218a12.1 for ; Fri, 03 May 2024 17:05:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714781143; x=1715385943; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=lC+iKXqzQE4y6lKv4irPrPxbDt9vEwmTnGIJRFVo0M0=; b=HPtszVX8Kx78j6Ptl/mZVa420M0ixVU37iQmYhXEsQlvhxc5u5iFxnPNXpJJnuJf5U uzh3E2QnDUKbRwCkc6Avk2t9BQ86RKXRJc3kvoqscnI7UpgVro4DQJNWPL07aoj/za5E bjXoFjwL5vAvjquTHZZU2tyC8dUq+9y1jSVCuL1L5KOhrj4EaVUIub4+gtX3qF2Qysw6 CbPA73Mg03wh9pybwESjdqq+vf48ql7YVLA821ESH0FO0HfggivvKjkXNb8yyxBgUtNM fsSBV1PNeOg5a5D8G2Vr6lC238XzKbZIWNZE7PxQY/gK5RhNzvNZEGfoO151BeNFF2Vn mAKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714781143; x=1715385943; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lC+iKXqzQE4y6lKv4irPrPxbDt9vEwmTnGIJRFVo0M0=; b=iD5QfAils8uP+f4im8EuvAuLIw4U3a3wOpmvKsT9KKzl8qqtAMBtb62p+wJ1iWb8up SuxO/zjcCmT2nzfX6GfAoCmQF9xqdlpRzkqnRlnyxM+s0RVcDjVo/vVMxP63lbNepaoh fnPLRd+uBJ1dTg8HqWJ/3MlTlLDxj4TPLG9pKU7Vsne3QBP+eemYq7A2ymVrCIYVErPU jEYzA72uz6Mkjum1RhIzvz517UNi2yxAyOPLeaSiY0thGv2JYTMI8ZrZiX2x2tvymiHk q4VWGOLKZea/w4VakrsuX2+aCFJQfhyL+UwEmpHHcraJYIvWD0Mz2GvE/r1x3CKjq3aZ Sn5g== X-Gm-Message-State: AOJu0YzyuSLhAF3OIOnEKmkxj3TTnuwaTBRwvDdGVYgiEZL1qru4pDIb kgkrym2Y39h1n5Mx+dzmmeVLOBRK1w5hftc9e1vWFTF77I4SXiOFZjuyLkHGmK/dLZpI2DSjM+F y X-Received: by 2002:a17:90a:c481:b0:2a2:d498:eec2 with SMTP id j1-20020a17090ac48100b002a2d498eec2mr4074440pjt.40.1714781142928; Fri, 03 May 2024 17:05:42 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:50e3:94e0:79b0:c9f9]) by smtp.gmail.com with ESMTPSA id lt10-20020a17090b354a00b002a2f6da006csm3724056pjb.52.2024.05.03.17.05.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 May 2024 17:05:42 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH 5/5] gdb/testsuite: Add gdb.reverse/aarch64-mops.exp Date: Fri, 3 May 2024 21:05:21 -0300 Message-ID: <20240504000521.314531-6-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240504000521.314531-1-thiago.bauermann@linaro.org> References: <20240504000521.314531-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patch=linaro.org@sourceware.org The testcase verifies that MOPS instructions are recorded and correctly reversed. Not all variants of the copy and set instructions are tested, since there are many and the record and replay target processes them in the same way. --- gdb/testsuite/gdb.reverse/aarch64-mops.c | 71 +++++++++ gdb/testsuite/gdb.reverse/aarch64-mops.exp | 171 +++++++++++++++++++++ 2 files changed, 242 insertions(+) create mode 100644 gdb/testsuite/gdb.reverse/aarch64-mops.c create mode 100644 gdb/testsuite/gdb.reverse/aarch64-mops.exp diff --git a/gdb/testsuite/gdb.reverse/aarch64-mops.c b/gdb/testsuite/gdb.reverse/aarch64-mops.c new file mode 100644 index 000000000000..513f324b9dd6 --- /dev/null +++ b/gdb/testsuite/gdb.reverse/aarch64-mops.c @@ -0,0 +1,71 @@ +/* This test program is part of GDB, the GNU debugger. + + Copyright 2024 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#define TEST_STRING "Just a test string." +#define BUF_SIZE sizeof(TEST_STRING) + +int +main (void) +{ + char dest[BUF_SIZE]; + char source[BUF_SIZE] = TEST_STRING; + register char *p asm ("x19"); + register char *q asm ("x20"); + register long size asm ("x21"); + register long zero asm ("x22"); + + p = dest; + size = BUF_SIZE; + zero = 0; + /* Before setp. */ + /* memset implemented in MOPS instructions. */ + __asm__ volatile ("setp [%0]!, %1!, %2\n\t" + "setm [%0]!, %1!, %2\n\t" + "sete [%0]!, %1!, %2\n\t" + : "+&r"(p), "+&r"(size) + : "r"(zero) + : "memory"); + + /* After sete. */ + p = dest; + q = source; + size = BUF_SIZE; + /* Before cpyp. */ + /* memmove implemented in MOPS instructions. */ + __asm__ volatile ("cpyp [%0]!, [%1]!, %2!\n\t" + "cpym [%0]!, [%1]!, %2!\n\t" + "cpye [%0]!, [%1]!, %2!\n\t" + : "+&r" (p), "+&r" (q), "+&r" (size) + : + : "memory"); + /* After cpye. */ + p = dest; + q = source; + size = BUF_SIZE; + /* Before cpyfp. */ + /* memcpy implemented in MOPS instructions. */ + __asm__ volatile ("cpyfp [%0]!, [%1]!, %2!\n\t" + "cpyfm [%0]!, [%1]!, %2!\n\t" + "cpyfe [%0]!, [%1]!, %2!\n\t" + : "+&r" (p), "+&r" (q), "+&r" (size) + : + : "memory"); + /* After cpyfe. */ + p = dest; + + return 0; +} diff --git a/gdb/testsuite/gdb.reverse/aarch64-mops.exp b/gdb/testsuite/gdb.reverse/aarch64-mops.exp new file mode 100644 index 000000000000..f9c1257e0b11 --- /dev/null +++ b/gdb/testsuite/gdb.reverse/aarch64-mops.exp @@ -0,0 +1,171 @@ +# Copyright 2024 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test instruction record for AArch64 FEAT_MOPS instructions. +# Based on gdb.reverse/ppc_record_test_isa_3_1.exp +# +# The basic flow of the record tests are: +# 1) Stop before executing the instructions of interest. Record +# the initial value of the registers that the instruction will +# change, i.e. the destination register. +# 2) Execute the instructions. Record the new value of the +# registers that changed. +# 3) Reverse the direction of the execution and execute back to +# just before the instructions of interest. Record the final +# value of the registers of interest. +# 4) Check that the initial and new values of the registers are +# different, i.e. the instruction changed the registers as expected. +# 5) Check that the initial and final values of the registers are +# the same, i.e. GDB record restored the registers to their +# original values. + +require allow_aarch64_mops_tests + +standard_testfile + +if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ + [list debug additional_flags=-march=armv9.3-a]] } { + return -1 +} + +if ![runto_main] { + return -1 +} + +gdb_test_no_output "record full" + +proc do_test { insn_prefix } { + global decimal hex + + set before_seq [gdb_get_line_number "Before ${insn_prefix}p"] + set after_seq [gdb_get_line_number "After ${insn_prefix}e"] + + with_test_prefix $insn_prefix { + gdb_test "break $before_seq" \ + "Breakpoint $decimal at $hex: file .*/aarch64-mops.c, line $decimal\\." \ + "break before instruction sequence" + gdb_test "continue" \ + [multi_line \ + "Continuing\\." \ + "" \ + "Breakpoint $decimal, main \\(\\) at .*/aarch64-mops.c:$decimal" \ + "$decimal\[ \t\]+__asm__ volatile \\(\"${insn_prefix}p \[^\r\n\]+\""] \ + "about to execute instruction sequence" + + # Record the initial register values. + set x19_initial [capture_command_output "info register x19" ""] + set x21_initial [capture_command_output "info register x21" ""] + + # The set instructions use the ZERO variable, but not Q, and the other + # instructions are the opposite. + if {[string compare $insn_prefix "set"] == 0} { + set x22_initial [capture_command_output "info register x22" ""] + } else { + set x20_initial [capture_command_output "info register x20" ""] + } + + gdb_test "break $after_seq" \ + "Breakpoint $decimal at $hex: file .*/aarch64-mops.c, line $decimal\\." \ + "break after instruction sequence" + gdb_test "continue" \ + [multi_line \ + "Continuing\\." \ + "" \ + "Breakpoint $decimal, main \\(\\) at .*/aarch64-mops.c:$decimal" \ + "$decimal\[ \t\]+p = dest;"] \ + "executed instruction sequence" + + # Record the new register values. + set x19_new [capture_command_output "info register x19" ""] + set x21_new [capture_command_output "info register x21" ""] + + if {[string compare $insn_prefix "set"] == 0} { + set x22_new [capture_command_output "info register x22" ""] + } else { + set x20_new [capture_command_output "info register x20" ""] + } + + # Execute in reverse to before the instruction sequence. + gdb_test_no_output "set exec-direction reverse" + + gdb_test "continue" \ + [multi_line \ + "Continuing\\." \ + "" \ + "Breakpoint $decimal, main \\(\\) at .*/aarch64-mops.c:$decimal" \ + "$decimal\[ \t\]+__asm__ volatile \\(\"${insn_prefix}p \[^\r\n\]+\""] \ + "reversed execution of instruction sequence" + + # Record the final register values. + set x19_final [capture_command_output "info register x19" ""] + set x21_final [capture_command_output "info register x21" ""] + + if {[string compare $insn_prefix "set"] == 0} { + set x22_final [capture_command_output "info register x22" ""] + } else { + set x20_final [capture_command_output "info register x20" ""] + } + + # Check initial and new values of x19 are different. + gdb_assert [string compare $x19_initial $x19_new] \ + "check x19 initial value versus x19 new value" + + # Check initial and new values of x21 are different. + gdb_assert [string compare $x21_initial $x21_new] \ + "check x21 initial value versus x21 new value" + + if {[string compare $insn_prefix "set"] == 0} { + # Check initial and new values of x22 are the same. + # The register with the value to set shouldn't change. + gdb_assert ![string compare $x22_initial $x22_new] \ + "check x22 initial value versus x22 new value" + } else { + # Check initial and new values of x20 are different. + gdb_assert [string compare $x20_initial $x20_new] \ + "check x20 initial value versus x20 new value" + } + + # Check initial and final values of x19 are the same. + gdb_assert ![string compare $x19_initial $x19_final] \ + "check x19 initial value versus x19 final value" + + # Check initial and final values of x21 are the same. + gdb_assert ![string compare $x21_initial $x21_final] \ + "check x21 initial value versus x21 final value" + + if {[string compare $insn_prefix "set"] == 0} { + # Check initial and final values of x22 are the same. + # The register with the value to set shouldn't change. + gdb_assert ![string compare $x22_initial $x22_final] \ + "check x22 initial value versus x22 final value" + } else { + # Check initial and final values of x20 are the same. + gdb_assert ![string compare $x20_initial $x20_final] \ + "check x20 initial value versus x20 final value" + } + + # Restore forward execution and go to end of recording. + gdb_test_no_output "set exec-direction forward" + gdb_test "record goto end" \ + [multi_line \ + "Go forward to insn number $decimal" \ + "#0 main \\(\\) at .*/aarch64-mops.c:$decimal" \ + "$decimal\[ \t\]+p = dest;"] + } +} + +do_test "set" +do_test "cpy" +do_test "cpyf"