From patchwork Thu Jul 21 12:36:36 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: alexandros.frantzis@linaro.org X-Patchwork-Id: 2993 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 65EAE23F52 for ; Thu, 21 Jul 2011 12:44:05 +0000 (UTC) Received: from mail-qw0-f52.google.com (mail-qw0-f52.google.com [209.85.216.52]) by fiordland.canonical.com (Postfix) with ESMTP id 329B4A18398 for ; Thu, 21 Jul 2011 12:44:05 +0000 (UTC) Received: by mail-qw0-f52.google.com with SMTP id 8so853237qwb.11 for ; Thu, 21 Jul 2011 05:44:05 -0700 (PDT) Received: by 10.229.68.200 with SMTP id w8mr192016qci.114.1311252244962; Thu, 21 Jul 2011 05:44:04 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.229.217.78 with SMTP id hl14cs139573qcb; Thu, 21 Jul 2011 05:44:04 -0700 (PDT) Received: by 10.216.69.65 with SMTP id m43mr805385wed.4.1311251797559; Thu, 21 Jul 2011 05:36:37 -0700 (PDT) Received: from adelie.canonical.com (adelie.canonical.com [91.189.90.139]) by mx.google.com with ESMTP id t79si2367820weq.147.2011.07.21.05.36.37; Thu, 21 Jul 2011 05:36:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of bounces@canonical.com designates 91.189.90.139 as permitted sender) client-ip=91.189.90.139; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bounces@canonical.com designates 91.189.90.139 as permitted sender) smtp.mail=bounces@canonical.com Received: from loganberry.canonical.com ([91.189.90.37]) by adelie.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1QjsUW-0000Co-O6 for ; Thu, 21 Jul 2011 12:36:36 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id B3F182E84FB for ; Thu, 21 Jul 2011 12:36:36 +0000 (UTC) MIME-Version: 1.0 X-Launchpad-Project: glmark2 X-Launchpad-Branch: ~glmark2-dev/glmark2/trunk X-Launchpad-Message-Rationale: Subscriber X-Launchpad-Branch-Revision-Number: 91 X-Launchpad-Notification-Type: branch-revision To: Linaro Patch Tracker From: noreply@launchpad.net Subject: [Branch ~glmark2-dev/glmark2/trunk] Rev 91: Use a "safer" pixel for the validation of SceneTexture. Message-Id: <20110721123636.17019.40745.launchpad@loganberry.canonical.com> Date: Thu, 21 Jul 2011 12:36:36 -0000 Reply-To: noreply@launchpad.net Sender: bounces@canonical.com Errors-To: bounces@canonical.com Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="13475"; Instance="initZopeless config overlay" X-Launchpad-Hash: e30c6c05c41ba2ebf845ed2da20e7ff8f89e2354 ------------------------------------------------------------ revno: 91 committer: Alexandros Frantzis timestamp: Fri 2011-06-24 11:04:32 +0300 message: Use a "safer" pixel for the validation of SceneTexture. Some implementations (eg SGX) introduce some small artifacts when texturing, especially when using nearest filtering, that confuse our validation. The artifacts are present along the edges of a grid-like form on the texture, so we can (and do) select a pixel that is not affected by this. modified: src/scene-texture.cpp --- lp:glmark2 https://code.launchpad.net/~glmark2-dev/glmark2/trunk You are subscribed to branch lp:glmark2. To unsubscribe from this branch go to https://code.launchpad.net/~glmark2-dev/glmark2/trunk/+edit-subscription === modified file 'src/scene-texture.cpp' --- src/scene-texture.cpp 2011-06-23 12:48:15 +0000 +++ src/scene-texture.cpp 2011-06-24 08:04:32 +0000 @@ -185,17 +185,17 @@ Screen::Pixel ref; - Screen::Pixel pixel = mScreen.read_pixel(mScreen.mWidth / 2, - mScreen.mHeight / 2); + Screen::Pixel pixel = mScreen.read_pixel(mScreen.mWidth / 2 - 3, + mScreen.mHeight / 2 - 3); const std::string &filter = mOptions["texture-filter"].value; if (filter == "nearest") - ref = Screen::Pixel(0x3a, 0x3a, 0x3b, 0xff); + ref = Screen::Pixel(0x2b, 0x2a, 0x28, 0xff); else if (filter == "linear") - ref = Screen::Pixel(0x34, 0x34, 0x35, 0xff); + ref = Screen::Pixel(0x2c, 0x2b, 0x29, 0xff); else if (filter == "mipmap") - ref = Screen::Pixel(0x33, 0x33, 0x35, 0xff); + ref = Screen::Pixel(0x2d, 0x2c, 0x2a, 0xff); else return Scene::ValidationUnknown;