From patchwork Tue Oct 18 03:04:09 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael-Doyle Hudson X-Patchwork-Id: 4719 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 3B2F523FBE for ; Tue, 18 Oct 2011 03:04:15 +0000 (UTC) Received: from mail-bw0-f52.google.com (mail-bw0-f52.google.com [209.85.214.52]) by fiordland.canonical.com (Postfix) with ESMTP id 1AA26A180A7 for ; Tue, 18 Oct 2011 03:04:15 +0000 (UTC) Received: by bkbzs2 with SMTP id zs2so360560bkb.11 for ; Mon, 17 Oct 2011 20:04:14 -0700 (PDT) Received: by 10.223.60.73 with SMTP id o9mr1018303fah.18.1318907054742; Mon, 17 Oct 2011 20:04:14 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.152.1.71 with SMTP id 7cs29551lak; Mon, 17 Oct 2011 20:04:14 -0700 (PDT) Received: by 10.216.134.157 with SMTP id s29mr190522wei.57.1318907050454; Mon, 17 Oct 2011 20:04:10 -0700 (PDT) Received: from indium.canonical.com (indium.canonical.com. [91.189.90.7]) by mx.google.com with ESMTPS id h50si302394wed.110.2011.10.17.20.04.10 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 17 Oct 2011 20:04:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of bounces@canonical.com designates 91.189.90.7 as permitted sender) client-ip=91.189.90.7; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bounces@canonical.com designates 91.189.90.7 as permitted sender) smtp.mail=bounces@canonical.com Received: from ackee.canonical.com ([91.189.89.26]) by indium.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1RFzyL-0008LO-Ue for ; Tue, 18 Oct 2011 03:04:09 +0000 Received: from ackee.canonical.com (localhost [127.0.0.1]) by ackee.canonical.com (Postfix) with ESMTP id DD6F7E06D6 for ; Tue, 18 Oct 2011 03:04:09 +0000 (UTC) MIME-Version: 1.0 X-Launchpad-Project: lava-dispatcher X-Launchpad-Branch: ~linaro-validation/lava-dispatcher/trunk X-Launchpad-Message-Rationale: Subscriber X-Launchpad-Branch-Revision-Number: 138 X-Launchpad-Notification-Type: branch-revision To: Linaro Patch Tracker From: noreply@launchpad.net Subject: [Branch ~linaro-validation/lava-dispatcher/trunk] Rev 138: record why os.link failed too Message-Id: <20111018030409.3153.64001.launchpad@ackee.canonical.com> Date: Tue, 18 Oct 2011 03:04:09 -0000 Reply-To: noreply@launchpad.net Sender: bounces@canonical.com Errors-To: bounces@canonical.com Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="14157"; Instance="launchpad-lazr.conf" X-Launchpad-Hash: 079c67bcfda315f183c5606b81a79de1ff84bc92 ------------------------------------------------------------ revno: 138 committer: Michael Hudson-Doyle branch nick: trunk timestamp: Tue 2011-10-18 16:02:02 +1300 message: record why os.link failed too modified: lava_dispatcher/utils.py --- lp:lava-dispatcher https://code.launchpad.net/~linaro-validation/lava-dispatcher/trunk You are subscribed to branch lp:lava-dispatcher. To unsubscribe from this branch go to https://code.launchpad.net/~linaro-validation/lava-dispatcher/trunk/+edit-subscription === modified file 'lava_dispatcher/utils.py' --- lava_dispatcher/utils.py 2011-10-18 02:38:34 +0000 +++ lava_dispatcher/utils.py 2011-10-18 03:02:02 +0000 @@ -52,6 +52,8 @@ except OSError, err: if err.errno == 18: shutil.copy(cache_loc, file_location) + else: + logging.exception("os.link failed") else: file_location = download(url, path) try: @@ -63,9 +65,8 @@ #errno 18 is Invalid cross-device link if err.errno == 18: shutil.copy(file_location, cache_loc) - #If this fails for any other reason, it will be because - #another test is pulling the same image at the same time, - #so ignore + else: + logging.exception("os.link failed") return file_location def url_to_cache(url, cachedir):