From patchwork Tue Dec 17 21:47:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 181926 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp6351617ile; Tue, 17 Dec 2019 13:50:12 -0800 (PST) X-Google-Smtp-Source: APXvYqwM5KIptFGxTY6u8bECKiVXW1Yha6riQAHeyf9giQsGiacz0Z7gXD39DChTopXb97j0ohUj X-Received: by 2002:a05:6830:1704:: with SMTP id 4mr38852466otk.294.1576619412470; Tue, 17 Dec 2019 13:50:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576619412; cv=none; d=google.com; s=arc-20160816; b=B8/Q/q58b+ymAYtUyJpJ6z/LDOqj7XDJRNSvZKIyqqD9bQjIEs3fzGVPsRZxS4KTTg tpDOeIx80FxXVsdWvqdd338hVhLbsFrsyhYutVImFtwY583bg4MoPE2JPxMRzbGItrQO ju30NZyPj8qp7ARHS+Q7UtGZz/mNtgNULCfYaDueTp43leiq8OFEXE8KU5j+NNUgvo/J /BHP4GpwEtN2UwE4nlwF6dERhR7CrrqqIeECRyBey77dluXXiV3upDS9r5Ff6hNoLDAS hwQZWiX1KnhescQIsCwrigwNjkmKy+ZYtPX2yMcmKwg6sVnbPTQWNeejXHYrRrhQh7sK qK/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to:sender:list-help:list-post:list-archive :list-subscribe:list-unsubscribe:list-id:precedence:mailing-list :dkim-signature:domainkey-signature; bh=EbVlLte6cM3D+rEIFJmkDeBnjV3lHOp6fJKNaMCCY8s=; b=Z/xi4d2N5UzM8TdHS3ci7tkBDHXrHONudOzcrhVgLc6iriugif4GtJnmhbJTxcPZXY 11KWG3XJted5IyfMCeZ58sexIy1PMYziUI9yupqRoy4KRPXMNmySPtc0nTSDcH5IlN0W LyPGkcgxrSex9QHijNrGmqoByHMjVnL0RWP8Af4Hc7fJShUC+gn4Q3OSkLKn7jXp927q c2TbbcWxGpHVk5uU8mqs2Uzeb74w5KbjRLSl7vnnj47e6dlxOzHyIuJoEFDbLhyMkjJV u4NvTqATCstsK2cx9zBgZKxFkrJlslafzpjhgbrHuarBJPMJUEV0tC4sSz8Y9t5sW+m1 ugsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=BrEiTGpP; dkim=pass header.i=@linaro.org header.s=google header.b=Fwkmz7HY; spf=pass (google.com: domain of libc-alpha-return-108178-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-108178-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id r14si12422980oic.12.2019.12.17.13.50.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Dec 2019 13:50:12 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-return-108178-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=BrEiTGpP; dkim=pass header.i=@linaro.org header.s=google header.b=Fwkmz7HY; spf=pass (google.com: domain of libc-alpha-return-108178-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-108178-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=LofgWv/6vhoqTWyHbVhTg7QimurHXF5 pGPsmPOzlQbW/PwBK4aa9JnAe9SceUzjcvpyl8eupr1KHsKBwo4ujk6MoZRb5IGc N9er9AM/xi6oxcO0HFOiBT17+ezfHVHg3VpIZS+d0SWgo9kSh2sG4Eykor6AuYD1 IS5w5vCmZH8E= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=nWhrlHpJkWRQuIfMax4pY1zjrUE=; b=BrEiT GpPhQ6/qjSWgkTGx/ujcleRZN+Gsq6Dy8zBodJtiA3Yi3OKH1XY8vMkJ2XaGSV12 trYx3dK4SVqIZVZeNKl8Gl4RMtGjnhtj0D8MfNn2XQzPnCDkILIQrlOpW+HX00xe 7MkCGX3n078dvpoaUAUSCk53sn9zf/amID98cA= Received: (qmail 112794 invoked by alias); 17 Dec 2019 21:48:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 112106 invoked by uid 89); 17 Dec 2019 21:48:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2092 X-HELO: mail-pj1-f65.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=EbVlLte6cM3D+rEIFJmkDeBnjV3lHOp6fJKNaMCCY8s=; b=Fwkmz7HYFhKXJpiNY5gDRdsMRBfSO6Vxg33ZvHf8KH9JMqBL3t/RgbMc8FL176NbCg MKSDluHrcdJ1u18KPFaz8mQzTit0AbWo/4hQwz1yu2mO9+81gFIaMyF5t178sEymojWo 2ud2BJNZ/ibu+w3WRfdE0PQiMIbFv16NPGNuhEUYFLyOPgVdgIny3lyPM5VlTlKINPsG UZHC7gipe3XOU3AXnamIZE4qAl6WTLtoAKTpGWPQ0Ua5wn4P3fLMdkT9YHy+DfQSj5ub xnU/kuKrpGgCFIfPekWP66WgMfAN5Vsr33KKigZUnf38lrhUtEG1+9rFPphgXJwMhmA7 w3FQ== Return-Path: From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH 16/16] linux: Optimize fallback 32-bit clock_getres Date: Tue, 17 Dec 2019 18:47:28 -0300 Message-Id: <20191217214728.2886-16-adhemerval.zanella@linaro.org> In-Reply-To: <20191217214728.2886-1-adhemerval.zanella@linaro.org> References: <20191217214728.2886-1-adhemerval.zanella@linaro.org> This patch avoid probing the __NR_clock_getttime64 syscall each time __clock_gettime64 is issued on a kernel without 64 bit time support. Once ENOSYS is obtained, only 32-bit clock_gettime are used. The following snippet: clock_getres (CLOCK_REALTIME, &(struct timespec) { 0 }); clock_getres (CLOCK_MONOTONIC, &(struct timespec) { 0 }); clock_getres (CLOCK_BOOTTIME, &(struct timespec) { 0 }); clock_getres (20, &(struct timespec) { 0 }); On a kernel without 64 bit time support issues the syscalls: syscall_0x196(0, 0xffb83330, [...]) = -1 ENOSYS (Function not implemented) clock_getres(CLOCK_REALTIME, {tv_sec=0, tv_nsec=1}) = 0 clock_getres(CLOCK_MONOTONIC, {tv_sec=0, tv_nsec=1}) = 0 clock_getres(CLOCK_BOOTTIME, {tv_sec=0, tv_nsec=1}) = 0 Checked on i686-linux-gnu on 4.15 kernel. --- sysdeps/unix/sysv/linux/clock_getres.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) -- 2.17.1 diff --git a/sysdeps/unix/sysv/linux/clock_getres.c b/sysdeps/unix/sysv/linux/clock_getres.c index 3d59f11d71..c1e1cf60c6 100644 --- a/sysdeps/unix/sysv/linux/clock_getres.c +++ b/sysdeps/unix/sysv/linux/clock_getres.c @@ -42,13 +42,21 @@ __clock_getres64 (clockid_t clock_id, struct __timespec64 *res) int r; /* Old 32-bit ABI with possible 64-bit time_t support. */ # ifdef __NR_clock_getres_time64 + /* Avoid issue a __NR_clock_getres_time64 syscall on kernels that do not + support 64-bit time_t. */ + static int time64_support = 1; + if (atomic_load_relaxed (&time64_support) == 1) + { # ifdef HAVE_CLOCK_GETRES64_VSYSCALL - r = INLINE_VSYSCALL (clock_getres_time64, 2, clock_id, res); + r = INLINE_VSYSCALL (clock_getres_time64, 2, clock_id, res); # else - r = INLINE_SYSCALL_CALL (clock_getres_time64, clock_id, res); + r = INLINE_SYSCALL_CALL (clock_getres_time64, clock_id, res); # endif - if (r == 0 || errno != ENOSYS) - return r; + if (r == 0 || errno != ENOSYS) + return r; + + atomic_store_relaxed (&time64_support, 0); + } # endif /* Fallback code that uses 32-bit support. */ struct timespec ts32;