From patchwork Sun Dec 22 00:04:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 852902 Delivered-To: patch@linaro.org Received: by 2002:a5d:4888:0:b0:385:e875:8a9e with SMTP id g8csp2775952wrq; Sat, 21 Dec 2024 16:41:00 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVOulSLbKV4P8NzKGBtnrzCz+/LeMh8/zV+hGSougwzslCAFzM65osVAVyQk1QJXRVE9HX8XA==@linaro.org X-Google-Smtp-Source: AGHT+IFV2Jx7LCdJgG2Gh7kCMpS3dDz/cALiUet3qUADeCED3INqHopNCueRRLeymhmp8PUP97MU X-Received: by 2002:a05:620a:31a8:b0:7b8:70b2:5093 with SMTP id af79cd13be357-7b9ba7f6879mr1206815185a.42.1734828060428; Sat, 21 Dec 2024 16:41:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1734828060; cv=pass; d=google.com; s=arc-20240605; b=Gn8WJ4Vy1OJfVZq4+8yAd+AS7uZuJGPHn8T3TziOz470BcDvudhDiEjOnnQl/Q7U2k Clr4JFAGu7LppZikZ1EJNClpxl7ZpmvXNp57PeXuaJ/+H1Kcoe92srR5t5FrE6gepsn1 NbdD5xH3rLve3NJeytl+MtTN3SMtfkQR+e8sVG/lZuTZ+4gzsNfRBEDRvt1IFF/Xbky4 EN1NP+VYu5nlds6FyfvOACEztTSQbm8/BN3jV2Hf1o0lZAKADKA2g+VkGVT7YC82nih9 fVUvfvC16zuZVJPFgw1rjODt/1hmZSfVBljg88duF7PD+hkZr5KT6tkFfUA8952cVF+e HsdA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-filter:arc-filter:dmarc-filter :delivered-to:dkim-filter; bh=/eoQG2VwCdm3jrQmhGROqbPOjaFcULIkd6yr8nvjpIw=; fh=uKlFkH9AUukvL1xmvBA9M7Oe4ntiJIR8HCR4+3TPd4w=; b=SQ8a13zcM4ynFXbhDur4Lm47Wp6RG4xvZW5YsXvlkQ4C2zW+GUrwQI1i6Ambjna394 ZV44RMr574RkCYBZhVlIdqFG8zwwyyymJj8Hmq4G0hKHFNdFTZzGXdLW3BJV2Q0T2wII 1luc0MgLDlnWRQo5yu74O76PYXg7wt/kJCbnfVmeYlMhpekk9q7OgXR9J4hM2kVu7HE2 9oXFfaCmiF3PwYH4jzke6Ncy0HVBDF2LmyaG+l8cQsdS5iiQKF/vKtgAJXoiMhNu1ium j2uKrk4xnfn+I3DgWfiNUGK7bP3lJtUJrLt7/uzTZTKvFnofLOHdVQBUgYwBkrIuStf4 EwJQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=UoiR9Bn9; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id af79cd13be357-7b9ac2ad369si806761385a.22.2024.12.21.16.41.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Dec 2024 16:41:00 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=UoiR9Bn9; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EFD2C3858408 for ; Sun, 22 Dec 2024 00:40:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EFD2C3858408 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=UoiR9Bn9 X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 8CE323858288 for ; Sun, 22 Dec 2024 00:05:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8CE323858288 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8CE323858288 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734825931; cv=none; b=t/c/CWeNSSI+Q0X180Sy+UYXcqFav6PoFU7SSBXaBWx6ohFQVbAH5QMJFUt7CqpCgDrAW9tdoyDtRh7Q6qZwmpf8A2V7Q+gTxZXTAcmozPU8UraklCDoscNEY0etBfgwvFo2BxJ2jyo2g3FqO2N+5zVOhiFp3ylwK3aS5yl42HQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734825931; c=relaxed/simple; bh=dqecXDurbaU1EBRtbrVLgH6cejlBLKSUTvyJied0Rak=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vxJ+6r6z8lfTi8svDftSRGnuPpeK+RFiZk4D9dWa6/FYpFLJ6hltoa055RjsRVelfkNBZsLSmF6T71/SktEoQm5/00puJROMTQqC/jQkOp83J3pCk010CcGXZCZgJ/LGrj7GaLNJhaM/tGcww7zbmlFTfPuKF928GsxqmnhAMXs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8CE323858288 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-7ea9739647bso2001607a12.0 for ; Sat, 21 Dec 2024 16:05:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734825925; x=1735430725; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/eoQG2VwCdm3jrQmhGROqbPOjaFcULIkd6yr8nvjpIw=; b=UoiR9Bn9ij0BxR3kOmuNGcKGPHoyKzd1xtV/YW+MG4nIXjGRPMWhUf2YoN7iJsMCuw /I95t9vwySiG+lJKXGnxKnNJylwgRGXmHWr1N3437YU6IfXD4e5hCwmjAzDUcPCy7M4e yyOG8dIw5fvDtISu+Gkne0jtonH/olXAPTExNEd+1aSMyhV6Het0UGGjeBdIqocwIRHy G3DQFsE41Pqva3WGZIn42gj2nKi/tt3MdB1m86GvKY+K0UbPdGb3HRwEnd8Z0C06j+dy 9lr/5F061CA5Rj9N+icRQT6/diLQ/TN15Oc6f1+X0nnEWWjcsbSxoYXjeG40VXN5f72m IXnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734825925; x=1735430725; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/eoQG2VwCdm3jrQmhGROqbPOjaFcULIkd6yr8nvjpIw=; b=EPbOoKKYyrzytjz4f+dU/xi4AKbioMg552mwHrBwCbhP7HM9mCzoszFPSH0dXMF1Fk s1olYlktl5RLQL8rrFoJ4Vy2ovt4pyDR072wKJju95QtiMlwiPh8NXcNr9UZ63BBcHVo hVAMVw7LbAjwkRDY6Ia3HRZObdAX+D4+mwVS55NMzBgtnjaqc/qxAaUv8KaRhmo/xH7c 8nYZOcePGIliXf7pYumtn1pN00AyhVe9v2M8ZFZsN6z3dGpftKluYvFnw8pUu36aLpE/ 9bu4YkWoSnddtuZ87T46q0SL+mJmtehDpuaCVhFxwH7OBDvk/1rtzWThzgATWRvLlrdw X3+A== X-Gm-Message-State: AOJu0YyQT7Bs6JnpsOkpFgDmq232AMv6TjIZbtFleO9aCyL9FepgXsLD 3Lt2dAdSuUKw8IbyAWjB7njWJHfDEAA2kgy15gR54XDPZwLcs1M1 X-Gm-Gg: ASbGncuhAhyGClq7ukhIl5M9SnQXShxEfYmKxf5osFpHx+qJyVun9ebuUG19TH+fF3s efjxJB53ecxok2b3RRpXT04PgiAK7K7FbDik1vUHLUqZZxn3SlD9wmiOMi/4B8t2v5MZveEXzh0 tcjfWFR0yNWy8q2aRbU0PWvCiPaEOtcZSEEc9F9tAx/RYGNWhMicxnJkriaHYuswxSPATy8+UyG mTOj6kBUKhlPN+e2RIlVw0QPxg3jmQkpqHid6sBDlypzebxrQR7kMvU4Cxx6tCIAS5ph6s= X-Received: by 2002:a17:90a:c2c4:b0:2ee:f076:20f1 with SMTP id 98e67ed59e1d1-2f452d259fbmr14178600a91.0.1734825924842; Sat, 21 Dec 2024 16:05:24 -0800 (PST) Received: from gnu-tgl-3.localdomain ([120.204.185.181]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f4477c852csm5572443a91.22.2024.12.21.16.05.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Dec 2024 16:05:24 -0800 (PST) Received: from gnu-tgl-3.lan (localhost [IPv6:::1]) by gnu-tgl-3.localdomain (Postfix) with ESMTP id 4373CC0AE0; Sun, 22 Dec 2024 08:05:15 +0800 (CST) From: "H.J. Lu" To: libc-alpha@sourceware.org Cc: sam@gentoo.org, Adhemerval Zanella Subject: [PATCH 25/39] stdio: Suppress clang warnings for tst-unlockedio.c Date: Sun, 22 Dec 2024 08:04:48 +0800 Message-ID: <20241222000509.2205895-26-hjl.tools@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241222000509.2205895-1-hjl.tools@gmail.com> References: <20241222000509.2205895-1-hjl.tools@gmail.com> MIME-Version: 1.0 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patch=linaro.org@sourceware.org From: Adhemerval Zanella Suppress the following -Wgnu-folding-constant and -Wliteral-conversion warnings from Clang: tst-unlockedio.c:35:12: error: variable length array folded to constant array as an extension [-Werror,-Wgnu-folding-constant] 35 | char buf[strlen (blah) + 1]; | ^~~~~~~~~~~~~~~~~ tst-unlockedio.c:63:36: error: implicit conversion from 'double' to 'size_t' (aka 'unsigned long') changes value from -0 to 0 [-Werror,-Wliteral-conversion] || fwrite_unlocked (blah, 0, -0.0, fp) != 0 ~~~~~~~~~~~~~~~ ^~~~ tst-unlockedio.c:61:33: error: implicit conversion from 'double' to 'size_t' (aka 'unsigned long') changes value from 0.25 to 0 [-Werror,-Wliteral-conversion] || fwrite_unlocked (--cp, 0.25, 16, fp) != 0 ~~~~~~~~~~~~~~~ ^~~~ tst-unlockedio.c:59:37: error: implicit conversion from 'double' to 'size_t' (aka 'unsigned long') changes value from 0.25 to 0 [-Werror,-Wliteral-conversion] || fwrite_unlocked (cp++, 16, 0.25, fp) != 0 ~~~~~~~~~~~~~~~ ^~~~ tst-unlockedio.c:116:34: error: implicit conversion from 'double' to 'size_t' (aka 'unsigned long') changes value from -0 to 0 [-Werror,-Wliteral-conversion] || fread_unlocked (buf, 0, -0.0, fp) != 0 ~~~~~~~~~~~~~~ ^~~~ tst-unlockedio.c:114:32: error: implicit conversion from 'double' to 'size_t' (aka 'unsigned long') changes value from 0.25 to 0 [-Werror,-Wliteral-conversion] || fread_unlocked (--wp, 0.25, 16, fp) != 0 ~~~~~~~~~~~~~~ ^~~~ tst-unlockedio.c:112:36: error: implicit conversion from 'double' to 'size_t' (aka 'unsigned long') changes value from 0.25 to 0 [-Werror,-Wliteral-conversion] || fread_unlocked (wp++, 16, 0.25, fp) != 0 ~~~~~~~~~~~~~~ ^~~~ Co-Authored-By: H.J. Lu Reviewed-by: Sam James --- stdio-common/tst-unlockedio.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/stdio-common/tst-unlockedio.c b/stdio-common/tst-unlockedio.c index 8ff6b074b0..7f156b3c11 100644 --- a/stdio-common/tst-unlockedio.c +++ b/stdio-common/tst-unlockedio.c @@ -32,7 +32,10 @@ static int do_test (void) { const char blah[] = "BLAH"; + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (3.4, "-Wgnu-folding-constant"); char buf[strlen (blah) + 1]; + DIAG_POP_NEEDS_COMMENT_CLANG; FILE *fp, *f; const char *cp; char *wp; @@ -51,6 +54,9 @@ do_test (void) fread_unlocked below as well. */ DIAG_PUSH_NEEDS_COMMENT; DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wdiv-by-zero"); + /* clang warns about the implicit conversion from double to size_t, + which is required by this tests. */ + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wliteral-conversion"); if (ftello (fp) != 0 || fwrite_unlocked (blah, blah - blah, strlen (blah), f++) != 0 || f != fp + 1 @@ -104,6 +110,7 @@ do_test (void) /* See explanation above. */ DIAG_PUSH_NEEDS_COMMENT; DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wdiv-by-zero"); + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wliteral-conversion"); if (ftello (fp) != 0 || fread_unlocked (buf, buf - buf, strlen (blah), f++) != 0 || f != fp + 1