From patchwork Mon Mar 7 17:02:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 63646 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp1564897lbc; Mon, 7 Mar 2016 09:02:47 -0800 (PST) X-Received: by 10.98.72.213 with SMTP id q82mr5067683pfi.164.1457370167644; Mon, 07 Mar 2016 09:02:47 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id yj6si4157405pab.164.2016.03.07.09.02.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Mar 2016 09:02:47 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-return-67884-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libc-alpha-return-67884-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=libc-alpha-return-67884-patch=linaro.org@sourceware.org; dkim=pass header.i=@sourceware.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:cc:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=cAu6/BnKd1aoIr5g SwFFouFw5LYVsojuQeB/aotDC2X+GKCryJhDBIByEEAOlGKMhE7NfEbdOa6ICeY/ 7QlNDwxSMxq2venQfA+HazyY+EWQ30G9o2ceZCQ1lXazEan9dgTYqETT8sBJ7bNZ JSLb1GGQD7meb0bkegAMuLZPfXI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:cc:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=URHSnO/zgzCB5VrpiVCISr 1ropg=; b=dc+pOhCCosUB2Xt+VW2ar9xz+1cOmoNo7Lm05zQsD3GXMucrIasZh4 zm0B0b8AlkiiOS2VV+iE/6rJxiIbhisacviTi+QYOpYu6bddbrFvXT81o+Fcy4NM DT/sItGAsg5Q1i3T1+cqhJeXSFBUviUAq7NM1h9xzt1kRc1y/eq30= Received: (qmail 119850 invoked by alias); 7 Mar 2016 17:02:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 119815 invoked by uid 89); 7 Mar 2016 17:02:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f173.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=O8zshp7+h9D7+3Ibq1BHfQSNzYMfcwl4o/zLQXa7zVs=; b=Dpco1c7zORdmUYdwiZ0qoL+kHKaGiQqhQuoDF0OViMpbdazIRpegujsCgVEabxUwv9 5qFp4nC6LkNcaSh5XcThyhDiPWP3h0VHeDXONu6tqYcSQclIGEWjT0Uv9BLvkVlAAcbu zvrkPyD3slglo40y1pCrSC/qXaAeKgSxdBOC2Fj8gUzwB2cMuuwrOmqteEXDiBeAyKP6 BfSKBBsBMeT+vVC3qVew3ruBJkxur/pMtUq1ETPYonUcO/FgVHZQteQEPPxsLIJrYadt 5UXurcUIGXOKdrPWOIFHUGpTSgEtnFPl/kDJjiwarHw1qvPdt4U4bQJ3M5zXlvaTLO63 Nieg== X-Gm-Message-State: AD7BkJJqE/cmrhobn4vIFYtRHjpcOcJ32FzOqrgeT+/MjLftLaLQ1nnFFUQ3fFdXCtM6J2v5 X-Received: by 10.98.72.193 with SMTP id q62mr35184760pfi.117.1457370146025; Mon, 07 Mar 2016 09:02:26 -0800 (PST) Subject: Re: [PATCH v5 0/3] posix: Execute file function fixes To: "H.J. Lu" References: <1456770820-21341-1-git-send-email-adhemerval.zanella@linaro.org> <56D73535.9030708@linaro.org> <56DDA03F.8010600@linaro.org> <56DDA80B.2000706@linaro.org> Cc: GNU C Library From: Adhemerval Zanella Message-ID: <56DDB41E.1000701@linaro.org> Date: Tue, 8 Mar 2016 00:02:22 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56DDA80B.2000706@linaro.org> On 07-03-2016 23:10, Adhemerval Zanella wrote: > > > On 07-03-2016 22:50, H.J. Lu wrote: >> On Mon, Mar 7, 2016 at 7:37 AM, Adhemerval Zanella >> wrote: >>> >>> >>> On 07-03-2016 21:46, H.J. Lu wrote: >>>> On Wed, Mar 2, 2016 at 10:47 AM, Adhemerval Zanella >>>> wrote: >>>>> I believe with latest comments from Paul Eggert I see these patchset is ok >>>>> for master. So I would like to commit it shortly if no one opposes it. >>>>> >>>> >>>> On x86-64, I got >>>> >>>> FAIL: posix/tst-execvpe5 >>>> >>>> # cat posix/tst-execvpe5.out >>>> Wrong number of arguments (4) >>>> >>> >>> Could you paste the result of strace -f with test running in your environment? >>> I am trying to reproduce it, but without much success. Also the buildbot is >>> not showing the issue. >> >> Please configure glibc with >> >> --enable-hardcoded-path-in-tests >> > > Right, the testcase does not handle this scenario. I will fix it. > This fixes the issue on tst-execvpe5 with --enable-hardcoded-path-in-tests: I will commit this tomorrow (since I on UTC+7). diff --git a/posix/tst-execvpe5.c b/posix/tst-execvpe5.c index ffd764a..3473330 100644 --- a/posix/tst-execvpe5.c +++ b/posix/tst-execvpe5.c @@ -88,13 +88,16 @@ do_test (int argc, char *argv[]) + "--library-path" optional + the library path optional + the application name + + if --enable-hardcoded-path-in-tests is used, just + + the application name */ if (restart) { if (argc != 1) { - printf ("Wrong number of arguments (%d)\n", argc); + printf ("Wrong number of arguments (%d) in restart\n", argc); exit (EXIT_FAILURE); } @@ -125,7 +128,7 @@ do_test (int argc, char *argv[]) } else { - char *args[] = { argv[1], argv[1], + char *args[] = { argv[0], (char *) "--direct", (char *) "--restart", NULL }; execvpe (args[0], args, envs); }