From patchwork Fri May 26 16:53:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 685921 Delivered-To: patch@linaro.org Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1025148wrt; Fri, 26 May 2023 09:54:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6oti7cCmEOR6Rvz4gwq9KYmiGPNPA0FkcBDeFI9XlLNeTjJKnzPIpKuFo2ZiUpt9z5Cj0v X-Received: by 2002:a05:622a:144:b0:3f5:45c2:467f with SMTP id v4-20020a05622a014400b003f545c2467fmr3136233qtw.5.1685120056372; Fri, 26 May 2023 09:54:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685120056; cv=none; d=google.com; s=arc-20160816; b=w6ov0wXQFZmE1+o+TWxVaaEttZmuYhZvg1rr4pl0qJM3ASrQoVSc5wL9fc8o8Dh8Rp /kjgE302kPNjS++JCsnwK0lXLmS+tMB9dPnu2oztkvzCvugMQZ37KwG8Vp5Nnf1sS0vP LU20E5mlHiv0Ba6B1UqjgAUs4GSpF2VGVmhlfk0IXLksTah1/opiFHP494e+ZQJLr+Z8 zIy2wGyQ2LhWLJS48LADz5rYlUOnQnqwHQ0f/E4sIr6O+itoX2G7ydEJT29H1Ik7HO6j ddFelI0SujxT1rb+pRmUqS4vVChhaJ6rtqlb70VKYWC67nRdYVrF4Ac0e9nm91ChKUiV iDNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:sender:errors-to:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :delivered-to:delivered-to:dkim-signature; bh=aNgvF1U6DPPWVuKO08h1QsvUdyYGXngalDac3kMNIfs=; b=SFXVxcGjPAEd1jGQ8npE51TiBDLkDKblVeoBhr6LWJ7jGn/1L5TkMhUwzSLsnqBqy1 VeEInosOX5beROXuQsFcQfltVO5yUywPAwUZnw3Liirjknh04tcL5zjpIZFan34uHFYr G2KstwykX6vh8ZyjSeW/fq4Ann05U7WmRVpTrNqob3VTX1NZkeIsHsk3NKXfRAJyXs0y jJFLKBHM3ffpf5KkKupNYiHno7oyecXgcJAV7Gsa5jp0EbKO8j+7GNbiPyDmGkRJTPtk LFchjeMtNZuEgabIrE+F6ves3v85mZK3ekJCmb6fUTRbFGTX0AoE2jnHaS6j+JwcTqV0 Zf3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=N+fQGb3O; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com. [170.10.129.124]) by mx.google.com with ESMTPS id c4-20020ac87dc4000000b003f69b11812dsi1515465qte.777.2023.05.26.09.54.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 09:54:16 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=N+fQGb3O; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685120055; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=aNgvF1U6DPPWVuKO08h1QsvUdyYGXngalDac3kMNIfs=; b=N+fQGb3OGFm7sX9B4tNxmrLBinYLi4GHMo4OMu6oteZWTrnmn76sNH3KqidWft7+CURE3y nbU0FKgPz6ZcLYzz1q2ggWKneZfX8PNbhT6sVq5FbukBcB5keDtvSSJr5gGFcVS0ichae6 e+NljElKgASTC8kYZslbeb9mJy55D+k= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-353-urRYTrHrNnGdWgYVdXhXTg-1; Fri, 26 May 2023 12:54:11 -0400 X-MC-Unique: urRYTrHrNnGdWgYVdXhXTg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 49D888032EF; Fri, 26 May 2023 16:54:09 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 66191400E13A; Fri, 26 May 2023 16:54:07 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2B64619465A4; Fri, 26 May 2023 16:54:07 +0000 (UTC) X-Original-To: libvir-list@listman.corp.redhat.com Delivered-To: libvir-list@listman.corp.redhat.com Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5AACE19465A0 for ; Fri, 26 May 2023 16:54:06 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EF1D9492B0B; Fri, 26 May 2023 16:54:05 +0000 (UTC) Delivered-To: libvir-list@redhat.com Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7CF7492B0A for ; Fri, 26 May 2023 16:54:05 +0000 (UTC) Received: from us-smtp-inbound-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CB5C9811E7C for ; Fri, 26 May 2023 16:54:05 +0000 (UTC) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-F0c6oUbVP_GIIT_4AjczRQ-1; Fri, 26 May 2023 12:54:03 -0400 X-MC-Unique: F0c6oUbVP_GIIT_4AjczRQ-1 Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-30ad8f33f1aso550466f8f.0 for ; Fri, 26 May 2023 09:54:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685120043; x=1687712043; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aNgvF1U6DPPWVuKO08h1QsvUdyYGXngalDac3kMNIfs=; b=dZ6g+4kMHk7KrxeCiI1yTd0XlgYtmiX9eXggBQjuX0UVXJBgx1iRG/yjGHrS10mcAh EugEDsNUYrvonBKhqQS+cdzL0n+SiSFIVwE/59WS/q2a7xAM/C+IiN8uWpuamYd0+2os gTLuoYUgTk5sMW8tosXSuzWaF8SBATi4JhrbJKuGlBuqeuj9VQkdnJZT/yj+lPceMB4F P5+6W5dIWNN8LYretfxwDzPr29MyO6+TS3pPK8hQs86LbfHScDvhdmW+feGzp7Znc597 U9VTMHDG7evpY19VAP/mb3zA3cwDU6HZuthshhJkb/rqdcsoB5LihKaIzM9T71eDixq5 7Hpg== X-Gm-Message-State: AC+VfDzEoRJAEpdzGkZrJGl0ypRkQEqI/B3R+KVFttYl/94ZSW0VVxnt 1tDXKEa1vNGLmC03x5P+Zj9dKw== X-Received: by 2002:adf:f603:0:b0:305:ed26:8576 with SMTP id t3-20020adff603000000b00305ed268576mr2095682wrp.9.1685120042772; Fri, 26 May 2023 09:54:02 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id c2-20020adfed82000000b003078a3f3a24sm5647501wro.114.2023.05.26.09.54.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 09:54:02 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id ECDAA1FFBB; Fri, 26 May 2023 17:54:01 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org, Stefan Hajnoczi Subject: [PATCH v6 00/11] tracing: remove dynamic vcpu state Date: Fri, 26 May 2023 17:53:50 +0100 Message-Id: <20230526165401.574474-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , =?utf-8?q?Alex_Benn=C3=A9e?= , libvir-list@redhat.com, Kyle Evans , Riku Voipio , Richard Henderson , Markus Armbruster , Greg Kurz , Yanan Wang , Marcel Apfelbaum , Michael Roth , Paolo Bonzini , Christian Schoenebeck , Eric Blake , Warner Losh Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: linaro.org Hi Stefan, The references dynamic vcpu tracing support was removed when the original TCG trace points where removed. However there was still a legacy of dynamic trace state to track this in cpu.h and extra hash variables to track TBs. While the removed vcpu tracepoints are not in generated code (or helpers) they still bring in a bunch of machinery to manage the state so I've pulled them out. We keep and rename one (cpu_reset) to a static trace points which dump vcpu->index as it is useful to f4bug. v6 new patch to shuffle deprecated, added rth's rb, qapi doc cleanups Please queue into your tree. Alex Bennée (11): *-user: remove the guest_user_syscall tracepoints trace-events: remove the remaining vcpu trace events trace: remove vcpu_id from the TraceEvent structure scripts/qapi: document the tool that generated the file docs/deprecated: move QMP events bellow QMP command section qapi: make the vcpu parameters deprecated for 8.1 trace: remove code that depends on setting vcpu trace: remove control-vcpu.h tcg: remove the final vestiges of dstate hw/9pfs: use qemu_xxhash4 accel/tcg: include cs_base in our hash calculations docs/about/deprecated.rst | 25 +++++--- qapi/trace.json | 40 ++++++------- accel/tcg/tb-hash.h | 6 +- include/exec/exec-all.h | 3 - include/hw/core/cpu.h | 5 -- include/qemu/xxhash.h | 23 +++++-- include/user/syscall-trace.h | 4 -- trace/control-internal.h | 10 ---- trace/control-vcpu.h | 63 -------------------- trace/control.h | 48 --------------- trace/event-internal.h | 2 - accel/tcg/cpu-exec.c | 7 +-- accel/tcg/tb-maint.c | 5 +- accel/tcg/translate-all.c | 6 -- bsd-user/freebsd/os-syscall.c | 2 - hw/9pfs/9p.c | 5 +- hw/core/cpu-common.c | 6 +- stubs/trace-control.c | 13 ---- trace/control-target.c | 109 +++------------------------------- trace/control.c | 28 --------- trace/qmp.c | 76 +++--------------------- trace/trace-hmp-cmds.c | 18 +----- util/qsp.c | 2 +- hw/core/trace-events | 3 + scripts/qapi/gen.py | 9 ++- scripts/tracetool/format/c.py | 6 -- scripts/tracetool/format/h.py | 16 +---- trace-events | 50 ---------------- 28 files changed, 94 insertions(+), 496 deletions(-) delete mode 100644 trace/control-vcpu.h