| Message ID | cover.1498499391.git.crobinso@redhat.com |
|---|---|
| Headers | show |
| Series | qemu: support chardev for all machvirt config | expand |
Hi Cole, On Mon, Jun 26, 2017 at 02:01:41PM -0400, Cole Robinson wrote: > Drew pointed out that we can use -chardev with machvirt platform > serial devices like: > > -chardev pty,id=foo > -serial chardev:foo > > And indeed it looks like qemu has supported this for as long as -chardev > has been around. Wiring this up will enable all the modern -chardev > features for every machvirt config (and some other arch/machine types). > > However just enabling that change is going to cause a lot of unneeded > test suite churn, due to the fact that some code is still checking for > qemu -chardev support, even though our minimum qemu version always has > chardev nowadays. So take the opportunity to exorcise QEMU_CAPS_CHARDEV I tried with two mainline QEMU versions (the default old one packaged with Debian and a recent upstream commit) and this series seems to work as intended, so: Tested-by: Christoffer Dall <cdall@linaro.org> > > * Patch 1 reverts Christopher's recent patch, to unbreak existing configs Sorry about that one, I realized when I came back from holiday that my test setup was broken and I was testing using the system install of libvirt, not the deveopment one, and I happened to have created a VM with the same name in both instances, whoops. Thanks a lot for picking this up and fixing it properly. -Christoffer > * Patch 2-3 make pci-serial work for machvirt and demonstrate it with a > test suite change. > * Patch 4-10 slowly strip out QEMU_CAPS_DEVICE > * Patch 11 adds -chardev support for platform serial devices > * Patch 12 is a cleanup > > Cole Robinson (12): > Revert "qemu: Support chardevs with ARM virt machines" > qemu: caps: Tweak arm conditional in SupportsChardev > tests: qemuxml2argv: Add an aarch64 pci-serial test > qemu: command: Remove old style -parallel building > qemu: command: Drop some QEMU_CAPS_CHARDEV checks > qemu: command: always use -chardev for monitor config > tests: qemuxml2argv: drop redundant serial testing > tests: qemuxml2argv: Drop old style serial testing > tests: qemuxml2argv: Add some QEMU_CAPS_CHARDEV annotations > qemu: caps: blacklist QEMU_CAPS_CHARDEV > qemu: command: support -chardev for platform devices > qemu: Rename SupportsChardev to IsPlatformDevice > > src/qemu/qemu_capabilities.c | 46 +--- > src/qemu/qemu_capabilities.h | 6 +- > src/qemu/qemu_command.c | 243 ++++++--------------- > src/qemu/qemu_process.c | 9 +- > tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml | 1 - > tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml | 1 - > tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml | 1 - > tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - > tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 - > tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 - > tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 - > tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 - > tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 - > .../caps_2.6.0-gicv2.aarch64.xml | 1 - > .../caps_2.6.0-gicv3.aarch64.xml | 1 - > tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 - > tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 - > tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 - > tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 - > tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 - > tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 - > tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 - > tests/qemucapabilitiesdata/caps_2.9.50.s390x.xml | 1 - > tests/qemuhelptest.c | 5 - > .../qemuxml2argv-aarch64-aavmf-virtio-mmio.args | 4 +- > .../qemuxml2argv-aarch64-acpi-uefi.args | 4 +- > .../qemuxml2argv-aarch64-cpu-passthrough.args | 4 +- > .../qemuxml2argv-aarch64-gic-host.args | 4 +- > .../qemuxml2argv-aarch64-gic-none-tcg.args | 4 +- > .../qemuxml2argv-aarch64-gic-v2.args | 4 +- > .../qemuxml2argv-aarch64-gic-v3.args | 4 +- > .../qemuxml2argv-aarch64-kvm-32-on-64.args | 7 +- > .../qemuxml2argv-aarch64-noacpi-nouefi.args | 4 +- > .../qemuxml2argv-aarch64-noacpi-uefi.args | 4 +- > .../qemuxml2argv-aarch64-pci-serial.args | 26 +++ > .../qemuxml2argv-aarch64-pci-serial.xml | 17 ++ > ...muxml2argv-aarch64-usb-controller-nec-xhci.args | 4 +- > ...uxml2argv-aarch64-usb-controller-qemu-xhci.args | 4 +- > .../qemuxml2argv-aarch64-video-virtio-gpu-pci.args | 4 +- > ...l2argv-aarch64-virt-2.6-virtio-pci-default.args | 7 +- > .../qemuxml2argv-aarch64-virt-default-nic.args | 5 +- > .../qemuxml2argv-aarch64-virt-virtio.args | 7 +- > .../qemuxml2argv-aarch64-virtio-pci-default.args | 7 +- > ...l2argv-aarch64-virtio-pci-manual-addresses.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-acpi-table.args | 4 +- > .../qemuxml2argv-arm-vexpressa9-basic.args | 7 +- > .../qemuxml2argv-arm-vexpressa9-nodevs.args | 4 +- > .../qemuxml2argv-arm-vexpressa9-virtio.args | 7 +- > .../qemuxml2argv-arm-virt-virtio.args | 7 +- > tests/qemuxml2argvdata/qemuxml2argv-autoindex.args | 4 +- > .../qemuxml2argv-balloon-ccw-deflate.args | 4 +- > .../qemuxml2argv-balloon-device-auto.args | 4 +- > .../qemuxml2argv-balloon-device-deflate-off.args | 4 +- > .../qemuxml2argv-balloon-device-deflate.args | 4 +- > .../qemuxml2argv-balloon-device-period.args | 4 +- > .../qemuxml2argv-balloon-device.args | 4 +- > .../qemuxml2argv-balloon-mmio-deflate.args | 4 +- > .../qemuxml2argv-bios-nvram-secure.args | 5 +- > .../qemuxml2argv-bios-nvram-secure.xml | 6 - > .../qemuxml2argvdata/qemuxml2argv-bios-nvram.args | 5 +- > tests/qemuxml2argvdata/qemuxml2argv-bios-nvram.xml | 6 - > tests/qemuxml2argvdata/qemuxml2argv-bios.args | 7 +- > .../qemuxml2argv-blkdeviotune-group-num.args | 4 +- > .../qemuxml2argv-blkdeviotune-max-length.args | 4 +- > .../qemuxml2argv-blkdeviotune-max.args | 4 +- > .../qemuxml2argv-blkdeviotune.args | 4 +- > .../qemuxml2argv-blkiotune-device.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-blkiotune.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-boot-cdrom.args | 4 +- > .../qemuxml2argv-boot-complex-bootindex.args | 4 +- > .../qemuxml2argv-boot-complex.args | 4 +- > .../qemuxml2argv-boot-floppy-q35.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-boot-floppy.args | 4 +- > ...xml2argv-boot-menu-disable-drive-bootindex.args | 4 +- > .../qemuxml2argv-boot-menu-disable-drive.args | 4 +- > .../qemuxml2argv-boot-menu-disable.args | 4 +- > .../qemuxml2argv-boot-menu-enable-bootindex.args | 4 +- > ...qemuxml2argv-boot-menu-enable-with-timeout.args | 4 +- > .../qemuxml2argv-boot-menu-enable.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-boot-multi.args | 4 +- > .../qemuxml2argv-boot-network.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-boot-order.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-boot-strict.args | 4 +- > .../qemuxml2argv-bootindex-floppy-q35.args | 4 +- > .../qemuxml2argv-channel-spicevmc-old.args | 4 +- > .../qemuxml2argv-channel-spicevmc.args | 4 +- > .../qemuxml2argv-clock-catchup.args | 4 +- > .../qemuxml2argv-clock-france.args | 4 +- > .../qemuxml2argv-clock-hpet-off.args | 4 +- > ...muxml2argv-clock-localtime-basis-localtime.args | 4 +- > .../qemuxml2argv-clock-localtime.args | 4 +- > .../qemuxml2argv-clock-timer-hyperv-rtc.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-clock-utc.args | 4 +- > .../qemuxml2argv-clock-variable.args | 4 +- > .../qemuxml2argv-console-compat-auto.args | 7 +- > .../qemuxml2argv-console-compat.args | 7 +- > .../qemuxml2argv-cpu-Haswell-noTSX.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-cpu-Haswell.args | 4 +- > .../qemuxml2argv-cpu-Haswell2.args | 4 +- > .../qemuxml2argv-cpu-Haswell3.args | 4 +- > .../qemuxml2argv-cpu-cache-disable.args | 4 +- > .../qemuxml2argv-cpu-cache-disable2.args | 4 +- > .../qemuxml2argv-cpu-cache-disable3.args | 4 +- > .../qemuxml2argv-cpu-cache-emulate-l3.args | 4 +- > .../qemuxml2argv-cpu-cache-passthrough.args | 4 +- > .../qemuxml2argv-cpu-cache-passthrough2.args | 4 +- > .../qemuxml2argv-cpu-check-default-none.args | 4 +- > .../qemuxml2argv-cpu-check-default-none2.args | 4 +- > .../qemuxml2argv-cpu-check-default-partial.args | 4 +- > .../qemuxml2argv-cpu-check-default-partial2.args | 4 +- > .../qemuxml2argv-cpu-check-none.args | 4 +- > .../qemuxml2argv-cpu-eoi-disabled.args | 4 +- > .../qemuxml2argv-cpu-eoi-enabled.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-cpu-exact1.args | 4 +- > .../qemuxml2argv-cpu-exact2-nofallback.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-cpu-exact2.args | 4 +- > .../qemuxml2argv-cpu-fallback.args | 4 +- > .../qemuxml2argv-cpu-host-kvmclock.args | 4 +- > .../qemuxml2argv-cpu-host-model-cmt.args | 4 +- > .../qemuxml2argv-cpu-host-model-fallback.args | 4 +- > .../qemuxml2argv-cpu-host-model-vendor.args | 4 +- > .../qemuxml2argv-cpu-host-model.args | 4 +- > ...qemuxml2argv-cpu-host-passthrough-features.args | 4 +- > .../qemuxml2argv-cpu-host-passthrough.args | 4 +- > .../qemuxml2argv-cpu-hotplug-startup.args | 4 +- > .../qemuxml2argv-cpu-kvmclock.args | 4 +- > .../qemuxml2argv-cpu-minimum1.args | 4 +- > .../qemuxml2argv-cpu-minimum2.args | 4 +- > .../qemuxml2argv-cpu-numa-disjoint.args | 4 +- > .../qemuxml2argv-cpu-numa-memshared.args | 4 +- > .../qemuxml2argv-cpu-numa-no-memory-element.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-cpu-numa1.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-cpu-numa2.args | 4 +- > .../qemuxml2argv-cpu-s390-features.args | 4 +- > .../qemuxml2argv-cpu-s390-zEC12.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-cpu-strict1.args | 4 +- > .../qemuxml2argv-cpu-topology1.args | 4 +- > .../qemuxml2argv-cpu-topology2.args | 4 +- > .../qemuxml2argv-cpu-topology3.args | 4 +- > .../qemuxml2argv-cpu-tsc-frequency.args | 4 +- > .../qemuxml2argv-cputune-numatune.args | 4 +- > .../qemuxml2argv-cputune-zero-shares.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-cputune.args | 4 +- > .../qemuxml2argv-debug-threads.args | 4 +- > .../qemuxml2argv-default-kvm-host-arch.args | 4 +- > .../qemuxml2argv-default-qemu-host-arch.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-disk-aio.args | 4 +- > .../qemuxml2argv-disk-blockio.args | 4 +- > .../qemuxml2argv-disk-cdrom-empty.args | 4 +- > .../qemuxml2argv-disk-cdrom-network-ftp.args | 4 +- > .../qemuxml2argv-disk-cdrom-network-ftps.args | 4 +- > .../qemuxml2argv-disk-cdrom-network-http.args | 4 +- > .../qemuxml2argv-disk-cdrom-network-https.args | 4 +- > .../qemuxml2argv-disk-cdrom-network-tftp.args | 4 +- > ...qemuxml2argv-disk-cdrom-tray-no-device-cap.args | 4 +- > .../qemuxml2argv-disk-cdrom-tray.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-disk-cdrom.args | 4 +- > .../qemuxml2argv-disk-copy_on_read.args | 5 +- > .../qemuxml2argv-disk-copy_on_read.xml | 6 - > .../qemuxml2argv-disk-drive-boot-cdrom.args | 4 +- > .../qemuxml2argv-disk-drive-boot-disk.args | 4 +- > .../qemuxml2argv-disk-drive-cache-directsync.args | 4 +- > .../qemuxml2argv-disk-drive-cache-unsafe.args | 4 +- > .../qemuxml2argv-disk-drive-cache-v2-none.args | 4 +- > .../qemuxml2argv-disk-drive-cache-v2-wb.args | 4 +- > .../qemuxml2argv-disk-drive-cache-v2-wt.args | 4 +- > .../qemuxml2argv-disk-drive-copy-on-read.args | 4 +- > .../qemuxml2argv-disk-drive-detect-zeroes.args | 4 +- > .../qemuxml2argv-disk-drive-discard.args | 4 +- > ...uxml2argv-disk-drive-error-policy-enospace.args | 4 +- > .../qemuxml2argv-disk-drive-error-policy-stop.args | 4 +- > ...gv-disk-drive-error-policy-wreport-rignore.args | 4 +- > .../qemuxml2argv-disk-drive-fmt-qcow.args | 4 +- > .../qemuxml2argv-disk-drive-network-gluster.args | 4 +- > ...qemuxml2argv-disk-drive-network-iscsi-auth.args | 4 +- > .../qemuxml2argv-disk-drive-network-iscsi-lun.args | 4 +- > .../qemuxml2argv-disk-drive-network-iscsi.args | 4 +- > ...qemuxml2argv-disk-drive-network-nbd-export.args | 4 +- > ...ml2argv-disk-drive-network-nbd-ipv6-export.args | 4 +- > .../qemuxml2argv-disk-drive-network-nbd-ipv6.args | 4 +- > .../qemuxml2argv-disk-drive-network-nbd-unix.args | 4 +- > .../qemuxml2argv-disk-drive-network-nbd.args | 4 +- > ...muxml2argv-disk-drive-network-rbd-auth-AES.args | 4 +- > .../qemuxml2argv-disk-drive-network-rbd-auth.args | 4 +- > .../qemuxml2argv-disk-drive-network-rbd-ipv6.args | 4 +- > .../qemuxml2argv-disk-drive-network-rbd.args | 4 +- > .../qemuxml2argv-disk-drive-network-sheepdog.args | 4 +- > .../qemuxml2argv-disk-drive-no-boot.args | 4 +- > .../qemuxml2argv-disk-drive-readonly-disk.args | 4 +- > ...qemuxml2argv-disk-drive-readonly-no-device.args | 4 +- > .../qemuxml2argv-disk-drive-shared.args | 4 +- > ...emuxml2argv-disk-floppy-tray-no-device-cap.args | 4 +- > .../qemuxml2argv-disk-floppy-tray.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-disk-floppy.args | 4 +- > .../qemuxml2argv-disk-geometry.args | 4 +- > .../qemuxml2argv-disk-ide-drive-split.args | 4 +- > .../qemuxml2argv-disk-ide-wwn.args | 4 +- > .../qemuxml2argv-disk-ioeventfd.args | 5 +- > .../qemuxml2argv-disk-ioeventfd.xml | 6 - > .../qemuxml2argvdata/qemuxml2argv-disk-iscsi.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-disk-many.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-disk-order.args | 4 +- > .../qemuxml2argv-disk-sata-device.args | 4 +- > .../qemuxml2argv-disk-scsi-device-auto.args | 4 +- > .../qemuxml2argv-disk-scsi-device.args | 4 +- > .../qemuxml2argv-disk-scsi-disk-split.args | 4 +- > .../qemuxml2argv-disk-scsi-disk-vpd.args | 4 +- > .../qemuxml2argv-disk-scsi-disk-wwn.args | 4 +- > .../qemuxml2argv-disk-scsi-lun-passthrough.args | 4 +- > .../qemuxml2argv-disk-scsi-megasas.args | 4 +- > .../qemuxml2argv-disk-scsi-mptsas1068.args | 4 +- > .../qemuxml2argv-disk-scsi-virtio-scsi.args | 4 +- > .../qemuxml2argv-disk-scsi-vscsi.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-disk-serial.args | 4 +- > .../qemuxml2argv-disk-snapshot.args | 4 +- > .../qemuxml2argv-disk-source-pool-mode.args | 4 +- > .../qemuxml2argv-disk-source-pool.args | 4 +- > .../qemuxml2argv-disk-usb-device-removable.args | 4 +- > .../qemuxml2argv-disk-usb-device.args | 4 +- > .../qemuxml2argv-disk-virtio-ccw-many.args | 4 +- > .../qemuxml2argv-disk-virtio-ccw.args | 4 +- > .../qemuxml2argv-disk-virtio-s390.args | 4 +- > .../qemuxml2argv-disk-virtio-scsi-ccw.args | 4 +- > .../qemuxml2argv-disk-virtio-scsi-cmd_per_lun.args | 4 +- > .../qemuxml2argv-disk-virtio-scsi-ioeventfd.args | 4 +- > .../qemuxml2argv-disk-virtio-scsi-max_sectors.args | 4 +- > .../qemuxml2argv-disk-virtio-scsi-num_queues.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-disk-virtio.args | 4 +- > .../qemuxml2argv-encrypted-disk-usage.args | 4 +- > .../qemuxml2argv-encrypted-disk.args | 4 +- > .../qemuxml2argv-eoi-disabled.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-eoi-enabled.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-event_idx.args | 5 +- > tests/qemuxml2argvdata/qemuxml2argv-event_idx.xml | 6 - > .../qemuxml2argv-fd-memory-no-numa-topology.args | 4 +- > .../qemuxml2argv-fd-memory-numa-topology.args | 4 +- > .../qemuxml2argv-fd-memory-numa-topology2.args | 4 +- > .../qemuxml2argv-fd-memory-numa-topology3.args | 4 +- > .../qemuxml2argv-fips-enabled.args | 4 +- > .../qemuxml2argv-floppy-drive-fat.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-fs9p-ccw.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-fs9p.args | 4 +- > .../qemuxml2argv-graphics-sdl-fullscreen.args | 4 +- > .../qemuxml2argv-graphics-sdl.args | 4 +- > ...emuxml2argv-graphics-spice-agent-file-xfer.args | 4 +- > .../qemuxml2argv-graphics-spice-agentmouse.args | 4 +- > ...emuxml2argv-graphics-spice-auto-socket-cfg.args | 4 +- > .../qemuxml2argv-graphics-spice-auto-socket.args | 4 +- > .../qemuxml2argv-graphics-spice-compression.args | 4 +- > .../qemuxml2argv-graphics-spice-no-args.args | 4 +- > .../qemuxml2argv-graphics-spice-qxl-vga.args | 4 +- > .../qemuxml2argv-graphics-spice-sasl.args | 4 +- > .../qemuxml2argv-graphics-spice-socket.args | 4 +- > .../qemuxml2argv-graphics-spice-timeout.args | 5 +- > .../qemuxml2argv-graphics-spice-timeout.xml | 6 - > .../qemuxml2argv-graphics-spice.args | 4 +- > .../qemuxml2argv-graphics-vnc-auto-socket-cfg.args | 4 +- > .../qemuxml2argv-graphics-vnc-auto-socket.args | 4 +- > .../qemuxml2argv-graphics-vnc-no-listen-attr.args | 4 +- > .../qemuxml2argv-graphics-vnc-none.args | 4 +- > .../qemuxml2argv-graphics-vnc-policy.args | 4 +- > ...2argv-graphics-vnc-remove-generated-socket.args | 4 +- > .../qemuxml2argv-graphics-vnc-sasl.args | 4 +- > .../qemuxml2argv-graphics-vnc-socket.args | 4 +- > .../qemuxml2argv-graphics-vnc-tls.args | 4 +- > .../qemuxml2argv-graphics-vnc-websocket.args | 4 +- > .../qemuxml2argv-graphics-vnc.args | 4 +- > .../qemuxml2argv-hostdev-mdev-precreated.args | 4 +- > .../qemuxml2argv-hostdev-pci-address-device.args | 4 +- > .../qemuxml2argv-hostdev-pci-address.args | 4 +- > .../qemuxml2argv-hostdev-scsi-lsi-iscsi-auth.args | 4 +- > .../qemuxml2argv-hostdev-scsi-lsi-iscsi.args | 4 +- > .../qemuxml2argv-hostdev-scsi-lsi.args | 4 +- > .../qemuxml2argv-hostdev-scsi-readonly.args | 4 +- > .../qemuxml2argv-hostdev-scsi-vhost-scsi-ccw.args | 4 +- > .../qemuxml2argv-hostdev-scsi-vhost-scsi-pci.args | 4 +- > ...emuxml2argv-hostdev-scsi-virtio-iscsi-auth.args | 4 +- > .../qemuxml2argv-hostdev-scsi-virtio-iscsi.args | 4 +- > .../qemuxml2argv-hostdev-scsi-virtio-scsi.args | 4 +- > ...muxml2argv-hostdev-usb-address-device-boot.args | 4 +- > .../qemuxml2argv-hostdev-usb-address-device.args | 4 +- > .../qemuxml2argv-hostdev-usb-address.args | 4 +- > .../qemuxml2argv-hostdev-vfio-multidomain.args | 4 +- > .../qemuxml2argv-hostdev-vfio.args | 4 +- > .../qemuxml2argv-hotplug-base.args | 4 +- > .../qemuxml2argv-hugepages-memaccess.args | 4 +- > .../qemuxml2argv-hugepages-memaccess2.args | 4 +- > .../qemuxml2argv-hugepages-numa.args | 5 +- > .../qemuxml2argv-hugepages-numa.xml | 6 - > .../qemuxml2argv-hugepages-pages.args | 4 +- > .../qemuxml2argv-hugepages-pages2.args | 5 +- > .../qemuxml2argv-hugepages-pages3.args | 5 +- > .../qemuxml2argv-hugepages-pages5.args | 5 +- > .../qemuxml2argv-hugepages-pages6.args | 5 +- > .../qemuxml2argv-hugepages-shared.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-hugepages.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-hyperv-off.args | 4 +- > .../qemuxml2argv-hyperv-panic.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-hyperv.args | 4 +- > .../qemuxml2argv-input-usbmouse-addr.args | 4 +- > .../qemuxml2argv-input-usbmouse.args | 4 +- > .../qemuxml2argv-input-usbtablet.args | 4 +- > .../qemuxml2argv-intel-iommu-caching-mode.args | 4 +- > .../qemuxml2argv-intel-iommu-device-iotlb.args | 4 +- > .../qemuxml2argv-intel-iommu-eim.args | 4 +- > .../qemuxml2argv-intel-iommu-ioapic.args | 4 +- > .../qemuxml2argv-intel-iommu-machine.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-intel-iommu.args | 4 +- > .../qemuxml2argv-iothreads-disk-virtio-ccw.args | 4 +- > .../qemuxml2argv-iothreads-disk.args | 4 +- > .../qemuxml2argv-iothreads-ids-partial.args | 4 +- > .../qemuxml2argv-iothreads-ids.args | 4 +- > .../qemuxml2argv-iothreads-virtio-scsi-ccw.args | 4 +- > .../qemuxml2argv-iothreads-virtio-scsi-pci.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-iothreads.args | 4 +- > .../qemuxml2argv-kvm-features-off.args | 4 +- > .../qemuxml2argv-kvm-features.args | 4 +- > .../qemuxml2argv-kvm-pit-delay.args | 4 +- > .../qemuxml2argv-kvm-pit-discard.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-kvm.args | 4 +- > .../qemuxml2argv-kvmclock+eoi-disabled.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-kvmclock.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-luks-disks.args | 4 +- > .../qemuxml2argv-machine-aeskeywrap-off-cap.args | 4 +- > .../qemuxml2argv-machine-aeskeywrap-off-caps.args | 4 +- > .../qemuxml2argv-machine-aeskeywrap-on-cap.args | 4 +- > .../qemuxml2argv-machine-aeskeywrap-on-caps.args | 4 +- > .../qemuxml2argv-machine-aliases1.args | 4 +- > .../qemuxml2argv-machine-aliases2.args | 4 +- > .../qemuxml2argv-machine-core-cfg-off.args | 4 +- > .../qemuxml2argv-machine-core-off.args | 4 +- > .../qemuxml2argv-machine-core-on.args | 4 +- > .../qemuxml2argv-machine-deakeywrap-off-cap.args | 4 +- > .../qemuxml2argv-machine-deakeywrap-off-caps.args | 4 +- > .../qemuxml2argv-machine-deakeywrap-on-cap.args | 4 +- > .../qemuxml2argv-machine-deakeywrap-on-caps.args | 4 +- > .../qemuxml2argv-machine-keywrap-none-caps.args | 4 +- > .../qemuxml2argv-machine-keywrap-none.args | 4 +- > ...-machine-loadparm-multiple-disks-nets-s390.args | 4 +- > .../qemuxml2argv-machine-loadparm-net-s390.args | 4 +- > .../qemuxml2argv-machine-loadparm-s390.args | 4 +- > .../qemuxml2argv-machine-smm-opt.args | 4 +- > .../qemuxml2argv-machine-usb-opt.args | 4 +- > .../qemuxml2argv-machine-vmport-opt.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-master-key.args | 4 +- > .../qemuxml2argv-memory-hotplug-dimm-addr.args | 4 +- > .../qemuxml2argv-memory-hotplug-dimm.args | 4 +- > .../qemuxml2argv-memory-hotplug-nvdimm-access.args | 4 +- > .../qemuxml2argv-memory-hotplug-nvdimm-label.args | 4 +- > .../qemuxml2argv-memory-hotplug-nvdimm.args | 4 +- > .../qemuxml2argv-memory-hotplug-ppc64-nonuma.args | 5 +- > .../qemuxml2argv-memory-hotplug-ppc64-nonuma.xml | 6 - > .../qemuxml2argv-memory-hotplug.args | 4 +- > .../qemuxml2argv-memtune-unlimited.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-memtune.args | 4 +- > .../qemuxml2argv-migrate-numa-unaligned.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-migrate.args | 4 +- > .../qemuxml2argv-minimal-msg-timestamp.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-minimal.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-misc-acpi.args | 4 +- > .../qemuxml2argv-misc-disable-s3.args | 4 +- > .../qemuxml2argv-misc-disable-suspends.args | 4 +- > .../qemuxml2argv-misc-enable-s4.args | 4 +- > .../qemuxml2argv-misc-no-reboot.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-mlock-off.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-mlock-on.args | 4 +- > .../qemuxml2argv-mlock-unsupported.args | 4 +- > .../qemuxml2argv-multifunction-pci-device.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-net-client.args | 4 +- > .../qemuxml2argv-net-eth-hostip.args | 4 +- > .../qemuxml2argv-net-eth-ifname.args | 4 +- > .../qemuxml2argv-net-eth-names.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-net-eth.args | 4 +- > .../qemuxml2argv-net-hostdev-multidomain.args | 4 +- > .../qemuxml2argv-net-hostdev-vfio-multidomain.args | 4 +- > .../qemuxml2argv-net-hostdev-vfio.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-net-hostdev.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-net-mcast.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-net-server.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-net-udp.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-net-user.args | 4 +- > .../qemuxml2argv-net-vhostuser-multiq.args | 4 +- > .../qemuxml2argv-net-vhostuser.args | 4 +- > .../qemuxml2argv-net-virtio-ccw.args | 4 +- > .../qemuxml2argv-net-virtio-device.args | 4 +- > .../qemuxml2argv-net-virtio-disable-offloads.args | 4 +- > .../qemuxml2argv-net-virtio-netdev.args | 4 +- > .../qemuxml2argv-net-virtio-rxqueuesize.args | 4 +- > .../qemuxml2argv-net-virtio-s390.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-net-virtio.args | 4 +- > .../qemuxml2argv-no-kvm-pit-device.args | 4 +- > .../qemuxml2argv-nographics-display.args | 4 +- > .../qemuxml2argv-nographics-vga.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-nographics.args | 4 +- > .../qemuxml2argv-nosharepages.args | 4 +- > ...qemuxml2argv-numad-auto-memory-vcpu-cpuset.args | 4 +- > ...d-auto-memory-vcpu-no-cpuset-and-placement.args | 4 +- > ...muxml2argv-numad-auto-vcpu-static-numatune.args | 4 +- > ...qemuxml2argv-numad-static-memory-auto-vcpu.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-numad.args | 4 +- > ...qemuxml2argv-numatune-auto-nodeset-invalid.args | 4 +- > .../qemuxml2argv-numatune-auto-prefer.args | 4 +- > .../qemuxml2argv-numatune-memnode-no-memory.args | 4 +- > .../qemuxml2argv-numatune-memnode.args | 4 +- > .../qemuxml2argv-numatune-memory.args | 4 +- > .../qemuxml2argv-panic-double.args | 4 +- > .../qemuxml2argv-panic-no-address.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-panic.args | 4 +- > .../qemuxml2argv-parallel-tcp.args | 22 -- > .../qemuxml2argvdata/qemuxml2argv-parallel-tcp.xml | 35 --- > .../qemuxml2argv-pci-autoadd-addr.args | 4 +- > .../qemuxml2argv-pci-autoadd-idx.args | 4 +- > .../qemuxml2argv-pci-autofill-addr.args | 4 +- > .../qemuxml2argv-pci-bridge-many-disks.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-pci-bridge.args | 4 +- > .../qemuxml2argv-pci-expander-bus.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-pci-many.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-pci-rom.args | 4 +- > .../qemuxml2argv-pcie-expander-bus.args | 5 +- > .../qemuxml2argv-pcie-root-port-model-generic.args | 4 +- > .../qemuxml2argv-pcie-root-port-model-ioh3420.args | 4 +- > .../qemuxml2argv-pcie-root-port.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-pcie-root.args | 4 +- > .../qemuxml2argv-pcie-switch-downstream-port.args | 4 +- > .../qemuxml2argv-pcie-switch-upstream-port.args | 4 +- > .../qemuxml2argv-pcihole64-q35.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-pcihole64.args | 4 +- > .../qemuxml2argv-pmu-feature-off.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-pmu-feature.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-ppc-dtb.args | 7 +- > .../qemuxml2argv-ppc64-usb-controller-legacy.args | 4 +- > ...emuxml2argv-ppc64-usb-controller-qemu-xhci.args | 4 +- > .../qemuxml2argv-ppc64-usb-controller.args | 4 +- > .../qemuxml2argv-ppce500-serial.args | 3 +- > .../qemuxml2argv-pseries-nvram.args | 4 +- > .../qemuxml2argv-pv-spinlock-disabled.args | 4 +- > .../qemuxml2argv-pv-spinlock-enabled.args | 4 +- > .../qemuxml2argv-q35-acpi-nouefi.args | 4 +- > .../qemuxml2argv-q35-acpi-uefi.args | 4 +- > .../qemuxml2argv-q35-default-devices-only.args | 4 +- > .../qemuxml2argv-q35-multifunction.args | 4 +- > .../qemuxml2argv-q35-noacpi-nouefi.args | 4 +- > .../qemuxml2argv-q35-pci-force-address.args | 4 +- > .../qemuxml2argv-q35-pcie-autoadd.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-q35-pcie.args | 4 +- > .../qemuxml2argv-q35-pm-disable-fallback.args | 4 +- > .../qemuxml2argv-q35-pm-disable.args | 4 +- > .../qemuxml2argv-q35-usb2-multi.args | 4 +- > .../qemuxml2argv-q35-usb2-reorder.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-q35-usb2.args | 4 +- > .../qemuxml2argv-q35-virt-manager-basic.args | 7 +- > .../qemuxml2argv-q35-virtio-pci.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-q35.args | 4 +- > .../qemuxml2argv-qemu-ns-commandline-ns0.args | 4 +- > .../qemuxml2argv-qemu-ns-commandline-ns1.args | 4 +- > .../qemuxml2argv-qemu-ns-commandline.args | 4 +- > ...emuxml2argv-qemu-ns-domain-commandline-ns0.args | 4 +- > .../qemuxml2argv-qemu-ns-domain-commandline.args | 4 +- > .../qemuxml2argv-qemu-ns-domain-ns0.args | 4 +- > .../qemuxml2argv-qemu-ns-no-env.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-qemu-ns.args | 4 +- > .../qemuxml2argv-reboot-timeout-disabled.args | 4 +- > .../qemuxml2argv-reboot-timeout-enabled.args | 4 +- > .../qemuxml2argv-restore-v2-fd.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-restore-v2.args | 4 +- > .../qemuxml2argv-seclabel-dac-none.args | 4 +- > .../qemuxml2argv-seclabel-dynamic-baselabel.args | 4 +- > .../qemuxml2argv-seclabel-dynamic-labelskip.args | 4 +- > .../qemuxml2argv-seclabel-dynamic-override.args | 4 +- > .../qemuxml2argv-seclabel-dynamic-relabel.args | 4 +- > .../qemuxml2argv-seclabel-dynamic.args | 4 +- > .../qemuxml2argv-seclabel-none.args | 4 +- > .../qemuxml2argv-seclabel-static-labelskip.args | 4 +- > .../qemuxml2argv-seclabel-static-relabel.args | 4 +- > .../qemuxml2argv-seclabel-static.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-serial-dev.args | 22 -- > tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml | 38 ---- > .../qemuxml2argvdata/qemuxml2argv-serial-file.args | 22 -- > .../qemuxml2argvdata/qemuxml2argv-serial-file.xml | 38 ---- > .../qemuxml2argvdata/qemuxml2argv-serial-many.args | 23 -- > .../qemuxml2argvdata/qemuxml2argv-serial-many.xml | 40 ---- > .../qemuxml2argvdata/qemuxml2argv-serial-pty.args | 4 +- > .../qemuxml2argv-serial-spiceport-nospice.args | 4 +- > .../qemuxml2argv-serial-tcp-telnet.args | 22 -- > .../qemuxml2argv-serial-tcp-telnet.xml | 40 ---- > .../qemuxml2argvdata/qemuxml2argv-serial-tcp.args | 22 -- > tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.xml | 40 ---- > .../qemuxml2argvdata/qemuxml2argv-serial-udp.args | 23 -- > tests/qemuxml2argvdata/qemuxml2argv-serial-udp.xml | 44 ---- > .../qemuxml2argvdata/qemuxml2argv-serial-unix.args | 22 -- > .../qemuxml2argvdata/qemuxml2argv-serial-unix.xml | 38 ---- > tests/qemuxml2argvdata/qemuxml2argv-serial-vc.args | 22 -- > tests/qemuxml2argvdata/qemuxml2argv-serial-vc.xml | 36 --- > .../qemuxml2argv-shmem-plain-doorbell.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-shmem.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-smbios.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-smp.args | 4 +- > .../qemuxml2argv-sound-device.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-sound.args | 4 +- > .../qemuxml2argv-tpm-passthrough.args | 4 +- > .../qemuxml2argv-usb-controller-default-q35.args | 4 +- > .../qemuxml2argv-usb-controller-explicit-q35.args | 4 +- > .../qemuxml2argv-usb-controller-qemu-xhci.args | 4 +- > .../qemuxml2argv-vcpu-placement-static.args | 4 +- > .../qemuxml2argv-video-device-pciaddr-default.args | 4 +- > .../qemuxml2argv-video-qxl-device-vgamem.args | 4 +- > .../qemuxml2argv-video-qxl-device.args | 4 +- > .../qemuxml2argv-video-qxl-heads.args | 4 +- > .../qemuxml2argv-video-qxl-nodevice.args | 4 +- > .../qemuxml2argv-video-qxl-noheads.args | 4 +- > .../qemuxml2argv-video-qxl-sec-device-vgamem.args | 4 +- > .../qemuxml2argv-video-qxl-sec-device.args | 4 +- > .../qemuxml2argv-video-vga-device-vgamem.args | 4 +- > .../qemuxml2argv-video-vga-device.args | 4 +- > .../qemuxml2argv-video-vga-nodevice.args | 4 +- > .../qemuxml2argv-video-vga-qxl-heads.args | 4 +- > .../qemuxml2argv-video-virtio-gpu-device.args | 4 +- > .../qemuxml2argv-video-virtio-gpu-secondary.args | 4 +- > .../qemuxml2argv-video-virtio-gpu-spice-gl.args | 4 +- > .../qemuxml2argv-video-virtio-gpu-virgl.args | 4 +- > .../qemuxml2argv-video-virtio-vga.args | 4 +- > .../qemuxml2argv-virtio-input-passthrough.args | 4 +- > .../qemuxml2argv-virtio-input.args | 4 +- > .../qemuxml2argvdata/qemuxml2argv-virtio-lun.args | 5 +- > tests/qemuxml2argvdata/qemuxml2argv-virtio-lun.xml | 6 - > .../qemuxml2argv-virtio-options.args | 4 +- > .../qemuxml2argv-virtio-rng-default.args | 4 +- > .../qemuxml2argv-virtio-rng-egd.args | 4 +- > .../qemuxml2argv-virtio-rng-multiple.args | 4 +- > .../qemuxml2argv-virtio-rng-random.args | 4 +- > .../qemuxml2argv-watchdog-device.args | 4 +- > .../qemuxml2argv-watchdog-dump.args | 4 +- > .../qemuxml2argv-watchdog-injectnmi.args | 4 +- > tests/qemuxml2argvdata/qemuxml2argv-watchdog.args | 4 +- > tests/qemuxml2argvtest.c | 200 ++++++++--------- > .../qemuxml2xmlout-bios-nvram.xml | 6 - > .../qemuxml2xmlout-disk-copy_on_read.xml | 6 - > .../qemuxml2xmlout-event_idx.xml | 6 - > .../qemuxml2xmlout-graphics-spice-timeout.xml | 6 - > .../qemuxml2xmlout-virtio-lun.xml | 6 - > tests/qemuxml2xmltest.c | 10 - > 542 files changed, 1683 insertions(+), 1509 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-pci-serial.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-pci-serial.xml > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-parallel-tcp.args > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-parallel-tcp.xml > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-dev.args > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-file.args > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-file.xml > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-many.args > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-many.xml > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.args > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.xml > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.args > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.xml > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-udp.args > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-udp.xml > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-unix.args > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-unix.xml > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-vc.args > delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-vc.xml > > -- > 2.13.0 > -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, 2017-06-26 at 14:01 -0400, Cole Robinson wrote: > Drew pointed out that we can use -chardev with machvirt platform > serial devices like: > > -chardev pty,id=foo > -serial chardev:foo > > And indeed it looks like qemu has supported this for as long as -chardev > has been around. Wiring this up will enable all the modern -chardev > features for every machvirt config (and some other arch/machine types). > > However just enabling that change is going to cause a lot of unneeded > test suite churn, due to the fact that some code is still checking for > qemu -chardev support, even though our minimum qemu version always has > chardev nowadays. So take the opportunity to exorcise QEMU_CAPS_CHARDEV > > * Patch 1 reverts Christopher's recent patch, to unbreak existing configs > * Patch 2-3 make pci-serial work for machvirt and demonstrate it with a > test suite change. > * Patch 4-10 slowly strip out QEMU_CAPS_DEVICE > * Patch 11 adds -chardev support for platform serial devices > * Patch 12 is a cleanup Things that I forgot to mention during review: * patch 11/12 fixes [1], a fact that should be mentioned in the commit message; * you need to update the release notes as well. Thanks for taking on this! :) [1] https://bugzilla.redhat.com/show_bug.cgi?id=1435681 -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 07/07/2017 12:47 PM, Andrea Bolognani wrote: > On Mon, 2017-06-26 at 14:01 -0400, Cole Robinson wrote: >> Drew pointed out that we can use -chardev with machvirt platform >> serial devices like: >> >> -chardev pty,id=foo >> -serial chardev:foo >> >> And indeed it looks like qemu has supported this for as long as -chardev >> has been around. Wiring this up will enable all the modern -chardev >> features for every machvirt config (and some other arch/machine types). >> >> However just enabling that change is going to cause a lot of unneeded >> test suite churn, due to the fact that some code is still checking for >> qemu -chardev support, even though our minimum qemu version always has >> chardev nowadays. So take the opportunity to exorcise QEMU_CAPS_CHARDEV >> >> * Patch 1 reverts Christopher's recent patch, to unbreak existing configs >> * Patch 2-3 make pci-serial work for machvirt and demonstrate it with a >> test suite change. >> * Patch 4-10 slowly strip out QEMU_CAPS_DEVICE >> * Patch 11 adds -chardev support for platform serial devices >> * Patch 12 is a cleanup > > Things that I forgot to mention during review: > > * patch 11/12 fixes [1], a fact that should be mentioned > in the commit message; > > * you need to update the release notes as well. > > Thanks for taking on this! :) > Thanks for the review :) I've pushed the series with (hopefully) all your comments addressed, minus the bit I mentioned in patch #10. I'll send follow up patches for news and dropping unused qemuCaps Thanks, Cole -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, 2017-07-04 at 11:25 +0200, Christoffer Dall wrote: > I tried with two mainline QEMU versions (the default old one packaged > with Debian and a recent upstream commit) and this series seems to work > as intended, so: > > Tested-by: Christoffer Dall <cdall@linaro.org> Christoffer, now that the series has been merged, would you mind updating https://bugs.linaro.org/show_bug.cgi?id=2777 with the relevant information? Thanks :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Hi Andrea, On Wed, Jul 19, 2017 at 03:07:25PM +0200, Andrea Bolognani wrote: > On Tue, 2017-07-04 at 11:25 +0200, Christoffer Dall wrote: > > I tried with two mainline QEMU versions (the default old one packaged > > with Debian and a recent upstream commit) and this series seems to work > > as intended, so: > > > > Tested-by: Christoffer Dall <cdall@linaro.org> > > Christoffer, > > now that the series has been merged, would you mind updating > > https://bugs.linaro.org/show_bug.cgi?id=2777 > > with the relevant information? I have updated the bug documenting that this works for me with upstream now. Which would be the next libvirt release number that contains this fix, and when is that expected to be released? I think my colleague tried to backport the changes to the libvirt version used in some Linaro packaged software, but it didn't work for him. Do you have any straight-forward thoughts on why that wouldn't work? Thanks, -Christoffer -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, 2017-07-20 at 12:55 +0200, Christoffer Dall wrote: > > Christoffer, > > > > now that the series has been merged, would you mind updating > > > > https://bugs.linaro.org/show_bug.cgi?id=2777 > > > > with the relevant information? > > I have updated the bug documenting that this works for me with upstream > now. Thanks :) > Which would be the next libvirt release number that contains this fix, > and when is that expected to be released? libvirt 3.6.0, scheduled to be released in the first week of August, will contain the fix. > I think my colleague tried to backport the changes to the libvirt > version used in some Linaro packaged software, but it didn't work for > him. Do you have any straight-forward thoughts on why that wouldn't > work? Can't think of anything specific, but when I backported the fixes to libvirt 3.2.0 there were quite a few conflicts to take care of, so if Linaro is using a much older libvirt version I can imagine the backport would get even trickier. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Jul 20, 2017 at 1:16 PM, Andrea Bolognani <abologna@redhat.com> wrote: > On Thu, 2017-07-20 at 12:55 +0200, Christoffer Dall wrote: >> > Christoffer, >> > >> > now that the series has been merged, would you mind updating >> > >> > https://bugs.linaro.org/show_bug.cgi?id=2777 >> > >> > with the relevant information? >> >> I have updated the bug documenting that this works for me with upstream >> now. > > Thanks :) > >> Which would be the next libvirt release number that contains this fix, >> and when is that expected to be released? > > libvirt 3.6.0, scheduled to be released in the first week > of August, will contain the fix. > Thanks, I'll update the ticket with this info. >> I think my colleague tried to backport the changes to the libvirt >> version used in some Linaro packaged software, but it didn't work for >> him. Do you have any straight-forward thoughts on why that wouldn't >> work? > > Can't think of anything specific, but when I backported > the fixes to libvirt 3.2.0 there were quite a few conflicts > to take care of, so if Linaro is using a much older libvirt > version I can imagine the backport would get even trickier. > Is the 3.2.0 backport available somewhere public? Thanks, -Christoffer -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, 2017-07-20 at 13:17 +0200, Christoffer Dall wrote: > > Can't think of anything specific, but when I backported > > the fixes to libvirt 3.2.0 there were quite a few conflicts > > to take care of, so if Linaro is using a much older libvirt > > version I can imagine the backport would get even trickier. > > Is the 3.2.0 backport available somewhere public? I'm afraid that's not yet the case. I see you're using 3.4.0 as your base version, so it wouldn't be of much help anyway. I took a quick peek at the git tree pointed to in the bug report and it looks like the backport was created not through cherry-picking of the relevant upstream commits, but by applying the patches straight off the mailing list. That is *not* the correct way to perform a backport, for a number or reasons: * you lose metadata such as R-b tags; * you don't have any information linking the downstream commit to the respective upstream commit, which will make it more difficult to figure out which commits can be dropped during the next rebase; * most importantly, any issue pointed out during review that has a straightforward enough fix not to warrant a respin will *still be present* in the backport. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Jul 20, 2017 at 4:27 PM, Andrea Bolognani <abologna@redhat.com> wrote: > On Thu, 2017-07-20 at 13:17 +0200, Christoffer Dall wrote: >> > Can't think of anything specific, but when I backported >> > the fixes to libvirt 3.2.0 there were quite a few conflicts >> > to take care of, so if Linaro is using a much older libvirt >> > version I can imagine the backport would get even trickier. >> >> Is the 3.2.0 backport available somewhere public? > > I'm afraid that's not yet the case. I see you're using 3.4.0 > as your base version, so it wouldn't be of much help anyway. > > I took a quick peek at the git tree pointed to in the bug > report and it looks like the backport was created not through > cherry-picking of the relevant upstream commits, but by > applying the patches straight off the mailing list. > > That is *not* the correct way to perform a backport, for a > number or reasons: > > * you lose metadata such as R-b tags; > > * you don't have any information linking the downstream > commit to the respective upstream commit, which will > make it more difficult to figure out which commits can > be dropped during the next rebase; > > * most importantly, any issue pointed out during review > that has a straightforward enough fix not to warrant > a respin will *still be present* in the backport. > Sure, in Riku's defense, I think the backport was done before the patches were committed upstream. But we'll give it another go. Thanks, -Christoffer -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list