From patchwork Tue Jun 19 16:40:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 139222 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp5428481lji; Tue, 19 Jun 2018 09:41:19 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJ13CUPCxm1gMAHJMJrcJAxkRFwt52r6HSpb0uEfKC3jzkdlUZ5OfV4jTHMy3YaZjdAljYM X-Received: by 2002:a9d:449c:: with SMTP id v28-v6mr9964636ote.395.1529426479497; Tue, 19 Jun 2018 09:41:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529426479; cv=none; d=google.com; s=arc-20160816; b=IYhTb7j3T15f+oI+C/xt4pYRpO2dJlsE/P8DqEtjJnntff3R2deqgz3KkNlX9OJnUo OixNY+kKnb5UJ6EuCbxscomAkkjMkmor+XFYVWeffAojB1DPdHUk55fTZ5HrxuF4Jy8P wxnkUrLW0Qt7HfBAk+AYOTWTnnpU7Uf/EFIkNzFHsyibkal6eg4QhW40dXFYV42NVexD U+eMYfjpA4QPE04e+aorCVC3YE0dqKr8jgZ8KrxnYuJk/08npwcnN8EfFo3rF/65qLdd mcxlKGExWkIkKAP0KoPP47JcpW3AqYnHtSZkSPOOtSCzhjUf1RDZ17D3CMUYQhoL6zCC WoCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to :arc-authentication-results; bh=3qwDxIHJ41yiCpRhWNMQnSV3T0Z5YHKc0yJ83gQshgg=; b=TqK7m1+1+GJxolI5e78e+tkSYBKFFPmcdx3rknqCJJIHkStjbnGxLw5LrB+pBxsvFx 347I47oE5bfwc0QJSovSz/izEM1GFw1ziijcM6+dacd7nwPfZzXo2PWr1zBo/2zOsqbM o1yqSrtfijiopQF/qtr+Dd1o36u0rKP1GHHDBOT7j1TGEnjHdoTn3JdCBTGXNn8O875U mUGxYjCAVYsLLutXE6MXkO9ko7Ou86TvyGvW0z0MTjFf39RnUkDh25OWgs1Hwq+NmbQU kVh9jvoKV88SkCN3arYaTu3YASMTROULEQ1eS41mjbUX3e3N0d/1xwSNHv42WK/ZtLCx 6Nzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id 35-v6si37773otk.402.2018.06.19.09.41.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jun 2018 09:41:19 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0A6B537E60; Tue, 19 Jun 2018 16:41:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C4C4E308BDB0; Tue, 19 Jun 2018 16:41:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7BE37180613A; Tue, 19 Jun 2018 16:41:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5JGfDjP011274 for ; Tue, 19 Jun 2018 12:41:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id C97352026D6C; Tue, 19 Jun 2018 16:41:13 +0000 (UTC) Delivered-To: libvirt-list@redhat.com Received: from worklaptop.bos.redhat.com (dhcp-17-157.bos.redhat.com [10.18.17.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id B01562026D68; Tue, 19 Jun 2018 16:41:13 +0000 (UTC) From: Cole Robinson To: libvirt-list@redhat.com Date: Tue, 19 Jun 2018 12:40:46 -0400 Message-Id: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 0/6] qemu: command: Replace vlan= with netdev= X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 19 Jun 2018 16:41:18 +0000 (UTC) Most VMs libvirt knows how to launch will have qemu network config like: -netdev $NETDEV_OPTS,id=netdev1 -device e1000,id=netdev1 However for machine types with built-in platform network devices, we currently do: -net nic,model=e1000,vlan=1 -net $NETDEV_OPTS,vlan=1 However for the platform case, all qemu versions we support can do: -netdev $NETDEV_OPTS,id=netdev1 -net nic,model=e1000,netdev=netdev1 Which simplifies our code, and is more future proof as qemu has deprecated the vlan= option. This series switches to the netdev= method, and performs some cleanups in related code. Thanks, Cole Cole Robinson (6): qemu: command: Make qemuBuildNicStr static qemu: command: Rename BuildNicStr to BuildLegacyNicStr qemu: command: remove unused LegacyNicStr arg 'prefix' qemu: command: replace vlan= with netdev= for legacy nic qemu: Remove vlan function arguments qemu: command: vhost: cleanup error reporting src/qemu/qemu_command.c | 99 ++++++------------- src/qemu/qemu_command.h | 8 -- src/qemu/qemu_hotplug.c | 3 +- .../arm-vexpressa9-basic.args | 4 +- 4 files changed, 33 insertions(+), 81 deletions(-) -- 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list