From patchwork Fri Feb 8 22:47:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 157893 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp27943jaa; Fri, 8 Feb 2019 14:47:46 -0800 (PST) X-Google-Smtp-Source: AHgI3IbQ/HNvgiSYV/6r6+3gxb65iZtrrxdgb7CgpkuebtO1g30UyjivhKetVGF6E0QA/Y7U58dX X-Received: by 2002:a0c:d80f:: with SMTP id h15mr18511070qvj.228.1549666066308; Fri, 08 Feb 2019 14:47:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549666066; cv=none; d=google.com; s=arc-20160816; b=r7D+rmyXOMKfD7YmUvIcDR39JblI3OlcgAn8bpXfM8ax5aaj3+hcMz0HvLtbXmbc68 ugXXe6OcG1yTQ7IG1iOJpsV9SJUcHVvyJ52E2V6KFpO+zI3k/ZV7So65Latq6L3IpvAQ abyQUgVLdOdCQWBi1gBhUjnV2MbQUMWLYibcy+6CMp4uwnGip9XC870hEKui9fRx0sk9 vsOrCc7k33NINEtFgIXbBKiyKGUDg8X9qoQcCBAUt+H09R56hPimAnz0Xdxc8Rp5sL6P Bc068yOIY2+7fXVfJ7k7gSlcJv+tjiE0FM+tYc4qcnc4hwm0QZYGJd7EnvtdwpVAE9qP PTUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:delivered-to; bh=iwW4QnlvC9+KeflR4oiX2CB/H+4bhpYnAYZg6NQbZ1E=; b=C8xG4G2MuyMJGZFf2UArdeZJfRG67hruiSNKwBukeBRPebuy+zR08C4eqoEZcpwC9h YvdfJrz2oMxVqvF8EJW0G7yZINUQn7l0Ko3prpvxATk9ICYs0niIsWrP6jKrBSMsET+W 6fBJgrRgRyVomZvBTrVlxxAtJ+bWL/EJt/z3TlXhPesk0E4ZRJy+P+z8B7n3JeWPOIH3 Nmeua/Zw2ksgWdXT9s6/ZKyB7o17Ivt8BlnGZdjaH7CBTspg+o2TLc5z316uardM+NVj Jxkx+c/qEJvSxQi0So8GThH6AiZZha01JpTKxje4L1emRa+069ncC12v7A9kynAsJfRy 9e3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id l8si2273288qkk.114.2019.02.08.14.47.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Feb 2019 14:47:46 -0800 (PST) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6872988E63; Fri, 8 Feb 2019 22:47:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 37F286116C; Fri, 8 Feb 2019 22:47:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DE9023F954; Fri, 8 Feb 2019 22:47:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x18MlKdM014256 for ; Fri, 8 Feb 2019 17:47:20 -0500 Received: by smtp.corp.redhat.com (Postfix) id 312B654505; Fri, 8 Feb 2019 22:47:20 +0000 (UTC) Delivered-To: libvirt-list@redhat.com Received: from worklaptop.redhat.com (ovpn-123-115.rdu2.redhat.com [10.10.123.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id 933B65B682; Fri, 8 Feb 2019 22:47:16 +0000 (UTC) From: Cole Robinson To: libvirt-list@redhat.com Date: Fri, 8 Feb 2019 17:47:09 -0500 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 0/4] libxl: override HAVE_PVUSB in test suite X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 08 Feb 2019 22:47:45 +0000 (UTC) There's two different domain capabilities test cases for libxl, depending on whether host libxl supports PVUSB or not. This causes pain when extending domain capabilities XML, because at least one file always needs to be updated by hand. This series adds a wrapper function for checking PVUSB, and adjusts the libxl driver to use it when building domaincapabilities output. We then mock the new function in the test suite to always return true, and ditch the !PVUSB test cases Cole Robinson (4): tests: Rename virmocklibxl.c -> libxlmock.c tests: Create a shared library with libxl driver libxl: Break out libxlCapsHasPVUSB tests: domcaps: Remove dependency on libxl PVUSB support src/libxl/libxl_capabilities.c | 16 +++- src/libxl/libxl_capabilities.h | 1 + tests/Makefile.am | 22 +++--- tests/domaincapsmock.c | 11 +++ .../domaincapsschemadata/libxl-xenfv-usb.xml | 78 ------------------- tests/domaincapsschemadata/libxl-xenfv.xml | 1 + .../domaincapsschemadata/libxl-xenpv-usb.xml | 68 ---------------- tests/domaincapsschemadata/libxl-xenpv.xml | 1 + tests/domaincapstest.c | 12 +-- tests/{virmocklibxl.c => libxlmock.c} | 2 +- tests/libxlxml2domconfigtest.c | 2 +- 11 files changed, 43 insertions(+), 171 deletions(-) delete mode 100644 tests/domaincapsschemadata/libxl-xenfv-usb.xml delete mode 100644 tests/domaincapsschemadata/libxl-xenpv-usb.xml rename tests/{virmocklibxl.c => libxlmock.c} (98%) -- 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list Reviewed-by: Ján Tomko