From patchwork Wed Apr 10 18:29:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 162034 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp6527109jan; Wed, 10 Apr 2019 11:30:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqxWaMCePULvI+Hz89/M+OLbvdiyFZZCtckfIsDpz9RIfE3ygdb/4oDoXnLgCD6MvZZYJyLt X-Received: by 2002:a0c:d20d:: with SMTP id m13mr37346376qvh.165.1554921003119; Wed, 10 Apr 2019 11:30:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554921003; cv=none; d=google.com; s=arc-20160816; b=jnxwlLwbNgow3s+2ieZS8uafNQD5wBmfOEEY9WT9r2Sz/QXivsgHUwnQ+xgfFlPPRj EHhmwmzNozrou12izjtCFp0I6cLHQmg1qyMDrf/XG11ZPbrxUFaQ/xPuapSnMmxOyoLP D4v2JNQ/5btcSZ5NEJFl/aYKGPVskDI45kGkUP/nDd5gCjIG04LaHcclYGwakDIelMbD KfrAy27MfdVixBXXDAlqjxeNzIMbQe+sx1Wg1aS60TMAnJhWAapeCsfRCTrBA6CiVDnq pwR0BH6lwHU5MEFKFGpjS98tK2qMqcT6wVOBtdLjddusU4OyAS1vUK7UtW9H2nOwPzhI 17pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:delivered-to; bh=+29t57pugwpi0XYsNAdtnmLuh+MFOQIUasp1RcLTOkE=; b=hxsfTioa/HjzQ+T0vlnMehVBY3Tr6m9pZ5VkNxNUPMQQeNiDyIr/kX+PMrDeGlQ5Pi 46+LgJLMYRQzXixScExis6/LELv17E0CDlWcB5m2PYvbwRXJhyHCcOby5j1U66p1pBSY xwoPZHy38SrzLBz776UDUzizJ0msNv3aayOEZJdiHGLMFb0N8cCDqVIsi7nO0wrXpjIS kM8Px3vCQkpC46A/9uhWcPyNge/JJP0SbNNMpXYXd1iaXO6796HYDpeWXuwNNFXPKTMB f3JTYqvQYHTMErACRH3xG530zJ/U5IvIZkTK7GB4nZbC1M537b0ltRFS0z+uKCJPHjQ0 MjTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id b43si2559743qta.356.2019.04.10.11.30.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Apr 2019 11:30:03 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF0C330FE5D7; Wed, 10 Apr 2019 18:30:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BAD2E277B5; Wed, 10 Apr 2019 18:30:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 41FD83FB13; Wed, 10 Apr 2019 18:30:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x3AITkUQ002688 for ; Wed, 10 Apr 2019 14:29:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3C7831A7EB; Wed, 10 Apr 2019 18:29:46 +0000 (UTC) Delivered-To: libvirt-list@redhat.com Received: from worklaptop.redhat.com (ovpn-123-233.rdu2.redhat.com [10.10.123.233]) by smtp.corp.redhat.com (Postfix) with ESMTP id 86DCB272CD; Wed, 10 Apr 2019 18:29:42 +0000 (UTC) From: Cole Robinson To: libvirt-list@redhat.com Date: Wed, 10 Apr 2019 14:29:34 -0400 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 0/3] qemu: monitor: detect more snapshot errors X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 10 Apr 2019 18:30:02 +0000 (UTC) qemu in Fedora 30 rejects migration if the VM has nested VMX configured. This means managedsave and snapshots are rejected too. Unfortunately the scraping we need to resort to with the text monitor snapshot commands is not detecting that 'savevm' actually failed, so the snapshot appears to succeed. https://bugzilla.redhat.com/show_bug.cgi?id=1697997 qemu 4.0.0 will add an 'Error: ' prefix to most hmp command errors (qemu commit 66363e9a43f), let's use that to detect error as well Cole Robinson (3): qemu: monitor: cleanup loadvm error handling qemu: monitor cleanup delvm error handling qemu: monitor: check for common 'Error: ' string src/qemu/qemu_monitor_text.c | 39 ++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 19 deletions(-) -- 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list