From patchwork Tue Jun 19 18:42:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 139236 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp5556200lji; Tue, 19 Jun 2018 11:42:20 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIfUCxyv02hzZgsSeH7hMAFF+MRsm3jAV9tASs0KXJqwi4AZfJJnh8VSsq1jqOILUPI3DyK X-Received: by 2002:aca:e4c8:: with SMTP id b191-v6mr9241127oih.106.1529433740721; Tue, 19 Jun 2018 11:42:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529433740; cv=none; d=google.com; s=arc-20160816; b=UxG82dWKdfJOQRmvxmPFcF19LklJqJhWQabzz38Zx7RDJ03W7ci4w+orSQLxdqj+be LVQCepgo4TaTuXVJ4e9YD3RdT5dOyIRdULJMaBh2/o10+NXPEhY6nOpj4wCme2cyirzv iDG3biNbt+/fyrDygjjrv19ZBKjLAs5zwX1B/KvYGmxS0aUh+pJlBJpxufKv7A2zPqEW 7ASUZfIHq8v55W03h/R+7XcLIJSBmC09ZXrVorXPtVyDKi3DcIzodAy2GwxqBSlqk3Ze 6++ddbvKu9jN9jeOOMLU+xH3QeOD0yl3cuQI+DdPjE4yPbWG3V4kcPpWGGIqbskmjt14 1Pqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to :arc-authentication-results; bh=g2OpewNLDK0hoH7Msf0iYoUdSv24gTaGmQNr6lLsAT0=; b=pIydI5TM0DrtBr30re/gMAJr14yRTW5cXgCvlhtB6gfJ8JwJZM7aDbxuiUw80V+Hi6 rR5nn9T0RkadQH2hxJf5h/USFSCI7iq7X66Dby5X5jIUiAPVBmnkdvfmxNccN6HPl1At FkyqIvKwvoUn01L38Sm2Yy44T6rCyKa3uyMUwmF6NpNfcT7ZK7wzaWsx9jWRGLkouuhx gPuyb3lqZBoKeskm8UmPoVjFsVUq3lffNIuvQPiGC3iRkzyf1GrMgox8EBC9PKSpSzLs fkwFhd2IXc1RO93HYKQrQ/xTJDOqRoB1CDd85Vdm78Wt2Ga/5jXHCgQNOvgdw75jvXPL evjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id r39-v6si125489ota.302.2018.06.19.11.42.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jun 2018 11:42:20 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0BB9D796FC; Tue, 19 Jun 2018 18:42:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8FAF860BE3; Tue, 19 Jun 2018 18:42:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B56691800538; Tue, 19 Jun 2018 18:42:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5JIgBb4026850 for ; Tue, 19 Jun 2018 14:42:11 -0400 Received: by smtp.corp.redhat.com (Postfix) id 12E88215670B; Tue, 19 Jun 2018 18:42:11 +0000 (UTC) Delivered-To: libvirt-list@redhat.com Received: from worklaptop.bos.redhat.com (dhcp-17-157.bos.redhat.com [10.18.17.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id E943E2156700; Tue, 19 Jun 2018 18:42:10 +0000 (UTC) From: Cole Robinson To: libvirt-list@redhat.com Date: Tue, 19 Jun 2018 14:42:06 -0400 Message-Id: <841c8e100dd2de70abc9aedd686c7222b542db43.1529433703.git.crobinso@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] conf: Remove unused virDomainDefNewFull X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 19 Jun 2018 18:42:19 +0000 (UTC) The last usages were removed with the xend driver in 1dac5fbbbb0 Signed-off-by: Cole Robinson --- src/conf/domain_conf.c | 22 ---------------------- src/conf/domain_conf.h | 3 --- src/libvirt_private.syms | 1 - 3 files changed, 26 deletions(-) -- 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list Reviewed-by: Erik Skultety diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 522e0c2bf3..f0b604e125 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3241,28 +3241,6 @@ virDomainDefNew(void) } -virDomainDefPtr -virDomainDefNewFull(const char *name, - const unsigned char *uuid, - int id) -{ - virDomainDefPtr def; - - if (!(def = virDomainDefNew())) - return NULL; - - if (VIR_STRDUP(def->name, name) < 0) { - VIR_FREE(def); - return NULL; - } - - memcpy(def->uuid, uuid, VIR_UUID_BUFLEN); - def->id = id; - - return def; -} - - void virDomainObjAssignDef(virDomainObjPtr domain, virDomainDefPtr def, bool live, diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 6344c02d1c..8cefef535a 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2919,9 +2919,6 @@ virDomainChrSourceDefNew(virDomainXMLOptionPtr xmlopt); virDomainChrDefPtr virDomainChrDefNew(virDomainXMLOptionPtr xmlopt); virDomainDefPtr virDomainDefNew(void); -virDomainDefPtr virDomainDefNewFull(const char *name, - const unsigned char *uuid, - int id); void virDomainObjAssignDef(virDomainObjPtr domain, virDomainDefPtr def, diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index ea24f2847c..98913a577a 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -287,7 +287,6 @@ virDomainDefMaybeAddController; virDomainDefMaybeAddInput; virDomainDefNeedsPlacementAdvice; virDomainDefNew; -virDomainDefNewFull; virDomainDefParseFile; virDomainDefParseNode; virDomainDefParseString;