From patchwork Tue Apr 5 11:22:45 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guilherme Salgado X-Patchwork-Id: 906 Return-Path: Delivered-To: unknown Received: from imap.gmail.com (74.125.159.109) by localhost6.localdomain6 with IMAP4-SSL; 08 Jun 2011 14:47:16 -0000 Delivered-To: patches@linaro.org Received: by 10.68.42.132 with SMTP id o4cs142443pbl; Tue, 5 Apr 2011 04:22:49 -0700 (PDT) Received: by 10.227.2.148 with SMTP id 20mr1774693wbj.220.1302002568259; Tue, 05 Apr 2011 04:22:48 -0700 (PDT) Received: from adelie.canonical.com (adelie.canonical.com [91.189.90.139]) by mx.google.com with ESMTP id g26si11894687wbe.41.2011.04.05.04.22.46; Tue, 05 Apr 2011 04:22:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of bounces@canonical.com designates 91.189.90.139 as permitted sender) client-ip=91.189.90.139; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bounces@canonical.com designates 91.189.90.139 as permitted sender) smtp.mail=bounces@canonical.com Received: from loganberry.canonical.com ([91.189.90.37]) by adelie.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1Q74LN-0000JD-Q9 for ; Tue, 05 Apr 2011 11:22:45 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id C47312E84F6 for ; Tue, 5 Apr 2011 11:22:45 +0000 (UTC) MIME-Version: 1.0 X-Launchpad-Project: linaro-image-tools X-Launchpad-Branch: ~linaro-maintainers/linaro-image-tools/trunk X-Launchpad-Message-Rationale: Subscriber X-Launchpad-Branch-Revision-Number: 313 X-Launchpad-Notification-Type: branch-revision To: Linaro Patch Tracker From: noreply@launchpad.net Subject: [Branch ~linaro-maintainers/linaro-image-tools/trunk] Rev 313: Add a couple XXX/TODO comments for things that need to be fixed. Message-Id: <20110405112245.6051.88234.launchpad@loganberry.canonical.com> Date: Tue, 05 Apr 2011 11:22:45 -0000 Reply-To: noreply@launchpad.net Sender: bounces@canonical.com Errors-To: bounces@canonical.com Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="12734"; Instance="initZopeless config overlay" X-Launchpad-Hash: 07c7f536cb235204abae85734986c3f6eea79175 ------------------------------------------------------------ revno: 313 committer: Guilherme Salgado branch nick: trunk timestamp: Tue 2011-04-05 08:06:49 -0300 message: Add a couple XXX/TODO comments for things that need to be fixed. modified: linaro_image_tools/media_create/boards.py linaro_image_tools/media_create/partitions.py --- lp:linaro-image-tools https://code.launchpad.net/~linaro-maintainers/linaro-image-tools/trunk You are subscribed to branch lp:linaro-image-tools. To unsubscribe from this branch go to https://code.launchpad.net/~linaro-maintainers/linaro-image-tools/trunk/+edit-subscription === modified file 'linaro_image_tools/media_create/boards.py' --- linaro_image_tools/media_create/boards.py 2011-04-05 09:26:47 +0000 +++ linaro_image_tools/media_create/boards.py 2011-04-05 11:06:49 +0000 @@ -195,6 +195,9 @@ return '%s,%s,%s,*\n%s,,,-' % ( boot_start, boot_len, partition_type, root_start) + # TODO: Create separate config classes for android and move this method + # into them, also renaming it to get_sfdisk_cmd() so that we don't need + # the image_type check in partitions.py. @classmethod def get_android_sfdisk_cmd(cls, should_align_boot_part=False): if cls.fat_size == 32: === modified file 'linaro_image_tools/media_create/partitions.py' --- linaro_image_tools/media_create/partitions.py 2011-03-31 18:44:16 +0000 +++ linaro_image_tools/media_create/partitions.py 2011-04-05 11:06:49 +0000 @@ -407,6 +407,8 @@ ['parted', '-s', media.path, 'mklabel', 'msdos'], as_root=True) proc.wait() + # XXX: We should get rid of this by using separate config classes for + # android -- see comment in get_android_sfdisk_cmd() for more details. if image_type == "ANDROID": sfdisk_cmd = board_config.get_android_sfdisk_cmd( should_align_boot_part=should_align_boot_part)