From patchwork Fri Feb 28 13:08:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liviu Dudau X-Patchwork-Id: 25548 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pb0-f70.google.com (mail-pb0-f70.google.com [209.85.160.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4118520567 for ; Fri, 28 Feb 2014 13:12:39 +0000 (UTC) Received: by mail-pb0-f70.google.com with SMTP id rp16sf1569925pbb.1 for ; Fri, 28 Feb 2014 05:12:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=8y5aHDmdBh8lgGGViQy2tXsjoO25BySGg5/oawkaKSk=; b=R4jbiK44I29T/5Xl+kM4epOcbdtCyoW2OmlYQk/TloCkhqP1auuvR4x5tasXgS47u7 CKG/K7E9sTBQ4alohUSvVkpAMgzP31jz9PKBrtz93f8T1QrpJ4uLKpWfqQtVj4cWwBb+ 94HXvjpJduEqc6/kSpYYD+v2nkwek1BniaBuqzhBvef2QK88lvNJ8pQsYZzwDRkumgpg ZBc7avD/y5RRU7fCiHJaJjc6eLelmpy7jTZQlnyxPyzk8yTE1DjVJglst9h6wY6CDjoV PerIEnd5RAh9ZCuRmb9Q5UXf1GFq/a76vVQwBIb5hhse4SiVv6sXzHO68eS9Zgf15gb5 6bSQ== X-Gm-Message-State: ALoCoQnXI0z657y4T7xNzeQqGvOqUCNuyIZIP5G946LZ+PI1skIAYkAbIHupYiV9QEhkUdNpxub+ X-Received: by 10.66.189.228 with SMTP id gl4mr1185598pac.26.1393593158262; Fri, 28 Feb 2014 05:12:38 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.81.209 with SMTP id f75ls1151647qgd.48.gmail; Fri, 28 Feb 2014 05:12:38 -0800 (PST) X-Received: by 10.58.91.101 with SMTP id cd5mr1157555veb.5.1393593158098; Fri, 28 Feb 2014 05:12:38 -0800 (PST) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx.google.com with ESMTPS id b7si242510vej.146.2014.02.28.05.12.38 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 28 Feb 2014 05:12:38 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.182; Received: by mail-vc0-f182.google.com with SMTP id id10so691556vcb.13 for ; Fri, 28 Feb 2014 05:12:38 -0800 (PST) X-Received: by 10.58.86.230 with SMTP id s6mr2547640vez.16.1393593157980; Fri, 28 Feb 2014 05:12:37 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.130.193 with SMTP id u1csp52672vcs; Fri, 28 Feb 2014 05:12:37 -0800 (PST) X-Received: by 10.67.23.135 with SMTP id ia7mr3343689pad.5.1393593134703; Fri, 28 Feb 2014 05:12:14 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i7si2035283pav.43.2014.02.28.05.12.14; Fri, 28 Feb 2014 05:12:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752284AbaB1NMF (ORCPT + 26 others); Fri, 28 Feb 2014 08:12:05 -0500 Received: from fw-tnat.cambridge.arm.com ([217.140.96.21]:53575 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751682AbaB1NI6 (ORCPT ); Fri, 28 Feb 2014 08:08:58 -0500 Received: from e106497-lin.cambridge.arm.com (e106497-lin.cambridge.arm.com [10.1.195.170]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id s1SD8MJE022677; Fri, 28 Feb 2014 13:08:22 GMT From: Liviu Dudau To: linux-pci , Bjorn Helgaas , Catalin Marinas , Will Deacon , linaro-kernel Cc: Benjamin Herrenschmidt , LKML , "devicetree@vger.kernel.org" , LAKML Subject: [PATCH v3 2/5] pci: OF: Fix the conversion of IO ranges into IO resources. Date: Fri, 28 Feb 2014 13:08:19 +0000 Message-Id: <1393592902-24750-3-git-send-email-Liviu.Dudau@arm.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1393592902-24750-1-git-send-email-Liviu.Dudau@arm.com> References: <1393592902-24750-1-git-send-email-Liviu.Dudau@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: liviu.dudau@arm.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The ranges property for a host bridge controller in DT describes the mapping between the PCI bus address and the CPU physical address. The resources framework however expects that the IO resources start at a pseudo "port" address 0 (zero) and have a maximum size of IO_SPACE_LIMIT. The conversion from pci ranges to resources failed to take that into account. In the process move the function into drivers/of/address.c as it now depends on pci_address_to_pio() code. Signed-off-by: Liviu Dudau diff --git a/drivers/of/address.c b/drivers/of/address.c index d1bb30f..d595d98 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c @@ -724,3 +724,37 @@ void __iomem *of_iomap(struct device_node *np, int index) return ioremap(res.start, resource_size(&res)); } EXPORT_SYMBOL(of_iomap); + +/** + * of_pci_range_to_resource - Create a resource from an of_pci_range + * @range: the PCI range that describes the resource + * @np: device node where the range belongs to + * @res: pointer to a valid resource that will be updated to + * reflect the values contained in the range. + * Note that if the range is an IO range, the resource will be converted + * using pci_address_to_pio() which can fail if it is called too early or + * if the range cannot be matched to any host bridge IO space (our case here). + * To guard against that we try to register the IO range first. + * If that fails we know that pci_address_to_pio() will do too. + */ +void of_pci_range_to_resource(struct of_pci_range *range, + struct device_node *np, struct resource *res) +{ + res->flags = range->flags; + if (res->flags & IORESOURCE_IO) { + unsigned long port = -1; + if (!pci_register_io_range(range->cpu_addr, range->size)) + port = pci_address_to_pio(range->cpu_addr); + if (port == (unsigned long)-1) { + res->start = (resource_size_t)OF_BAD_ADDR; + res->end = (resource_size_t)OF_BAD_ADDR; + return; + } + res->start = port; + } else { + res->start = range->cpu_addr; + } + res->end = res->start + range->size - 1; + res->parent = res->child = res->sibling = NULL; + res->name = np->full_name; +} diff --git a/include/linux/of_address.h b/include/linux/of_address.h index 40c418d..3fe500a 100644 --- a/include/linux/of_address.h +++ b/include/linux/of_address.h @@ -23,17 +23,8 @@ struct of_pci_range { #define for_each_of_pci_range(parser, range) \ for (; of_pci_range_parser_one(parser, range);) -static inline void of_pci_range_to_resource(struct of_pci_range *range, - struct device_node *np, - struct resource *res) -{ - res->flags = range->flags; - res->start = range->cpu_addr; - res->end = range->cpu_addr + range->size - 1; - res->parent = res->child = res->sibling = NULL; - res->name = np->full_name; -} - +extern void of_pci_range_to_resource(struct of_pci_range *range, + struct device_node *np, struct resource *res); /* Translate a DMA address from device space to CPU space */ extern u64 of_translate_dma_address(struct device_node *dev, const __be32 *in_addr);