From patchwork Wed Apr 2 15:43:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 27635 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f199.google.com (mail-vc0-f199.google.com [209.85.220.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E6EFD20341 for ; Wed, 2 Apr 2014 15:44:16 +0000 (UTC) Received: by mail-vc0-f199.google.com with SMTP id lh14sf845011vcb.2 for ; Wed, 02 Apr 2014 08:44:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=pteWSZQfRnwhqaK/SW9MPsCZQY9EGyrpCv//o702rK0=; b=el4ZFIMsP0O2ds3BJGTX9t0Fx6bnb9UFb/bqYwReL4aFsI+lYwm3/yTyaYa1oEjQ0d pegPwBATzfa1Awp5T7sVvUdL3AKmAhPay6r0mObc/+R0i2fgV+n2XJXK8IoUkFykEmCL iNbEiHR30ATOixVg1v5our6oc4ZUdqtDhLj3xFfrN5S2kXjegKt3+dKtFqWwGuxVLdQW OBslaaOOxz/qJ0TDja2HL2jBo+kobl8XZUR0CYZQ/mjZ9Aw/aB++UakeBLODokcwxK51 pGCDVP77+EZNXduNpE06l+vIEMQgRsNyXiFavnBXVFXaTFrygn6hhLl10FVPi4P/4fXg twDw== X-Gm-Message-State: ALoCoQmApSv3oPaM4qkQJRK1/qdrWzHuuva0yjtXLUGRp48sn77/Fh1GrGuzVjF/K7t1TiHDPxLz X-Received: by 10.236.180.2 with SMTP id i2mr648258yhm.4.1396453456597; Wed, 02 Apr 2014 08:44:16 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.86.170 with SMTP id p39ls360001qgd.49.gmail; Wed, 02 Apr 2014 08:44:16 -0700 (PDT) X-Received: by 10.52.51.226 with SMTP id n2mr1195839vdo.57.1396453456469; Wed, 02 Apr 2014 08:44:16 -0700 (PDT) Received: from mail-vc0-f175.google.com (mail-vc0-f175.google.com [209.85.220.175]) by mx.google.com with ESMTPS id wy9si632817vdc.73.2014.04.02.08.44.16 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 02 Apr 2014 08:44:16 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.175 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.175; Received: by mail-vc0-f175.google.com with SMTP id lh14so570745vcb.34 for ; Wed, 02 Apr 2014 08:44:16 -0700 (PDT) X-Received: by 10.52.95.135 with SMTP id dk7mr1297055vdb.32.1396453456378; Wed, 02 Apr 2014 08:44:16 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.12.8 with SMTP id v8csp334236vcv; Wed, 2 Apr 2014 08:44:15 -0700 (PDT) X-Received: by 10.194.24.74 with SMTP id s10mr1765236wjf.43.1396453455580; Wed, 02 Apr 2014 08:44:15 -0700 (PDT) Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by mx.google.com with ESMTPS id j9si1065999wjs.41.2014.04.02.08.44.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 02 Apr 2014 08:44:15 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.212.179 is neither permitted nor denied by best guess record for domain of daniel.thompson@linaro.org) client-ip=209.85.212.179; Received: by mail-wi0-f179.google.com with SMTP id z2so789072wiv.12 for ; Wed, 02 Apr 2014 08:44:15 -0700 (PDT) X-Received: by 10.180.84.73 with SMTP id w9mr3088189wiy.58.1396453454890; Wed, 02 Apr 2014 08:44:14 -0700 (PDT) Received: from sundance.lan (cpc4-aztw19-0-0-cust157.18-1.cable.virginm.net. [82.33.25.158]) by mx.google.com with ESMTPSA id dg7sm3450581wjc.4.2014.04.02.08.44.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Apr 2014 08:44:14 -0700 (PDT) From: Daniel Thompson To: kgdb-bugreport@lists.sourceforge.net, Jason Wessel Cc: patches@linaro.org, linaro-kernel@lists.linaro.org, Anton Vorontsov , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Steven Rostedt , Frederic Weisbecker , Ingo Molnar , John Stultz , Colin Cross , kernel-team@android.com, Daniel Thompson Subject: [RFC v2 02/10] kdb: Remove currently unused kdbtab_t->cmd_flags Date: Wed, 2 Apr 2014 16:43:52 +0100 Message-Id: <1396453440-16445-3-git-send-email-daniel.thompson@linaro.org> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1396453440-16445-1-git-send-email-daniel.thompson@linaro.org> References: <1396453440-16445-1-git-send-email-daniel.thompson@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.thompson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.175 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Anton Vorontsov The struct member is never used in the code, so we can remove it. We will introduce real flags soon by renaming cmd_repeat to cmd_flags. Signed-off-by: Anton Vorontsov Signed-off-by: John Stultz Signed-off-by: Daniel Thompson --- kernel/debug/kdb/kdb_main.c | 1 - kernel/debug/kdb/kdb_private.h | 1 - 2 files changed, 2 deletions(-) diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index f39f926..938c47b 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -2694,7 +2694,6 @@ int kdb_register_repeat(char *cmd, kp->cmd_func = func; kp->cmd_usage = usage; kp->cmd_help = help; - kp->cmd_flags = 0; kp->cmd_minlen = minlen; kp->cmd_repeat = repeat; diff --git a/kernel/debug/kdb/kdb_private.h b/kernel/debug/kdb/kdb_private.h index 7afd3c8..c4c46c7 100644 --- a/kernel/debug/kdb/kdb_private.h +++ b/kernel/debug/kdb/kdb_private.h @@ -172,7 +172,6 @@ typedef struct _kdbtab { kdb_func_t cmd_func; /* Function to execute command */ char *cmd_usage; /* Usage String for this command */ char *cmd_help; /* Help message for this command */ - short cmd_flags; /* Parsing flags */ short cmd_minlen; /* Minimum legal # command * chars required */ kdb_repeat_t cmd_repeat; /* Does command auto repeat on enter? */