From patchwork Fri Apr 25 16:29:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 29103 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ve0-f199.google.com (mail-ve0-f199.google.com [209.85.128.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2A6CB203AC for ; Fri, 25 Apr 2014 16:29:52 +0000 (UTC) Received: by mail-ve0-f199.google.com with SMTP id jy13sf15288417veb.2 for ; Fri, 25 Apr 2014 09:29:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=6QfvuFOZCzt+QneBzPeB1i9wFIU04wl8XL6aELeBbdY=; b=jerD+8X/pXPiLDWx8CPHvkUGJcr1o3vzoI+UY/OlgQnRn31IXl+evorNvRIvlcYib1 ZGHr1Rge+3akmnrEmMep2vXq8zEj5km3yVmquR4qWjlBKW9gcADDnVa2lZRKiZY0mioC P9aJc5c4wjZAvvwn4P0tCYtYXLN3eDOTZ3UfGeoT6b7aLMTdlaKIwLvrv/gO6t6VE9xI VfdaXIMf5xZGBwIks/ERTawrUdpf8gXX9ShjMjDKMSLETgBlQpBOgTJfeIFZU2Uy5wFB HcSziVp1jH4spk949Vkf2L3kfLats8puA2gNdWMsskNnGRzPf3+rXI2RIio81DaMr2cN yZbg== X-Gm-Message-State: ALoCoQlxNfKQ6JPalKav7a2uj8P1jWOYXlzyrRmZzhsvHH/h/Mn1fO/Z3batvqHPU2y/oNCMcV9L X-Received: by 10.236.35.33 with SMTP id t21mr4419212yha.11.1398443391907; Fri, 25 Apr 2014 09:29:51 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.32.203 with SMTP id h69ls1609454qgh.56.gmail; Fri, 25 Apr 2014 09:29:51 -0700 (PDT) X-Received: by 10.58.185.244 with SMTP id ff20mr665601vec.40.1398443391681; Fri, 25 Apr 2014 09:29:51 -0700 (PDT) Received: from mail-vc0-f177.google.com (mail-vc0-f177.google.com [209.85.220.177]) by mx.google.com with ESMTPS id tm8si1816382vdc.80.2014.04.25.09.29.51 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 25 Apr 2014 09:29:51 -0700 (PDT) Received-SPF: none (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) client-ip=209.85.220.177; Received: by mail-vc0-f177.google.com with SMTP id if17so5008715vcb.22 for ; Fri, 25 Apr 2014 09:29:51 -0700 (PDT) X-Received: by 10.52.166.18 with SMTP id zc18mr57776vdb.65.1398443391605; Fri, 25 Apr 2014 09:29:51 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp110886vcb; Fri, 25 Apr 2014 09:29:51 -0700 (PDT) X-Received: by 10.180.7.133 with SMTP id j5mr4397565wia.55.1398443390778; Fri, 25 Apr 2014 09:29:50 -0700 (PDT) Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by mx.google.com with ESMTPS id e11si1888036wik.80.2014.04.25.09.29.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 25 Apr 2014 09:29:50 -0700 (PDT) Received-SPF: none (google.com: daniel.thompson@linaro.org does not designate permitted sender hosts) client-ip=74.125.82.51; Received: by mail-wg0-f51.google.com with SMTP id z12so2671132wgg.22 for ; Fri, 25 Apr 2014 09:29:50 -0700 (PDT) X-Received: by 10.180.185.100 with SMTP id fb4mr4445988wic.11.1398443390380; Fri, 25 Apr 2014 09:29:50 -0700 (PDT) Received: from sundance.lan (cpc4-aztw19-0-0-cust157.18-1.cable.virginm.net. [82.33.25.158]) by mx.google.com with ESMTPSA id fw13sm6881026wic.6.2014.04.25.09.29.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Apr 2014 09:29:49 -0700 (PDT) From: Daniel Thompson To: kgdb-bugreport@lists.sourceforge.net, Jason Wessel Cc: patches@linaro.org, linaro-kernel@lists.linaro.org, Anton Vorontsov , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Steven Rostedt , Frederic Weisbecker , Ingo Molnar , John Stultz , Colin Cross , kernel-team@android.com Subject: [RFC v3 2/9] kdb: Remove currently unused kdbtab_t->cmd_flags Date: Fri, 25 Apr 2014 17:29:23 +0100 Message-Id: <1398443370-12668-3-git-send-email-daniel.thompson@linaro.org> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1398443370-12668-1-git-send-email-daniel.thompson@linaro.org> References: <1396453440-16445-1-git-send-email-daniel.thompson@linaro.org> <1398443370-12668-1-git-send-email-daniel.thompson@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.thompson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Anton Vorontsov The struct member is never used in the code, so we can remove it. We will introduce real flags soon by renaming cmd_repeat to cmd_flags. Signed-off-by: Anton Vorontsov Signed-off-by: John Stultz --- kernel/debug/kdb/kdb_main.c | 1 - kernel/debug/kdb/kdb_private.h | 1 - 2 files changed, 2 deletions(-) diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index f39f926..938c47b 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -2694,7 +2694,6 @@ int kdb_register_repeat(char *cmd, kp->cmd_func = func; kp->cmd_usage = usage; kp->cmd_help = help; - kp->cmd_flags = 0; kp->cmd_minlen = minlen; kp->cmd_repeat = repeat; diff --git a/kernel/debug/kdb/kdb_private.h b/kernel/debug/kdb/kdb_private.h index 7afd3c8..c4c46c7 100644 --- a/kernel/debug/kdb/kdb_private.h +++ b/kernel/debug/kdb/kdb_private.h @@ -172,7 +172,6 @@ typedef struct _kdbtab { kdb_func_t cmd_func; /* Function to execute command */ char *cmd_usage; /* Usage String for this command */ char *cmd_help; /* Help message for this command */ - short cmd_flags; /* Parsing flags */ short cmd_minlen; /* Minimum legal # command * chars required */ kdb_repeat_t cmd_repeat; /* Does command auto repeat on enter? */