From patchwork Fri Oct 9 15:04:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 54710 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f200.google.com (mail-lb0-f200.google.com [209.85.217.200]) by patches.linaro.org (Postfix) with ESMTPS id BB00923027 for ; Fri, 9 Oct 2015 15:04:41 +0000 (UTC) Received: by lbos8 with SMTP id s8sf39977125lbo.2 for ; Fri, 09 Oct 2015 08:04:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=lakCxRzsLEuxexfq9l1LVqSvRhFS18BZE/w0kKhVGv0=; b=CHLrYB+EzwmQoQBS8yX/tHQoY2gdH21ucJmnLc5tDPCy5TOAnb3k5G8Kkr1wLloXFo qSs4oGDOE0FYun+MYO3Qku1Qn562gr4WfG4JoUATFf25JwaS0NgBq83Tk6AaufJv9SOT R2vp4/7dIg38Q6LF5mWOzGNGNwqcKj5PFc6lGp1cRPZ25eNpXx1pvTBl4EoeSTOvaXIl WuKWpfddQr9WPqy6rnUZfwlTJG6v1cMjCD0Bq8GVHnX8Bi3pDomepqU1zJiJ3xPnUr4h rl1obY8VL9IuhNC47nAM5WgLHyqiftG27+DouJbjpK+dw8Sw+lWYRH9o2avE1Kb2rG1C 4B/w== X-Gm-Message-State: ALoCoQngDoEtKBU58P2M6qEI5NW3sp5a6ZRkv/rdOmOxZbsH3Xae49RYdHUUcHtOjDjE1EXwigNd X-Received: by 10.180.81.165 with SMTP id b5mr2034359wiy.1.1444403080722; Fri, 09 Oct 2015 08:04:40 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.25.170.72 with SMTP id t69ls282847lfe.56.gmail; Fri, 09 Oct 2015 08:04:40 -0700 (PDT) X-Received: by 10.25.87.9 with SMTP id l9mr3734604lfb.99.1444403080567; Fri, 09 Oct 2015 08:04:40 -0700 (PDT) Received: from mail-lb0-f180.google.com (mail-lb0-f180.google.com. [209.85.217.180]) by mx.google.com with ESMTPS id qi7si1535499lbb.13.2015.10.09.08.04.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Oct 2015 08:04:40 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.180 as permitted sender) client-ip=209.85.217.180; Received: by lbcao8 with SMTP id ao8so84764205lbc.3 for ; Fri, 09 Oct 2015 08:04:40 -0700 (PDT) X-Received: by 10.25.210.206 with SMTP id j197mr4500169lfg.86.1444403080236; Fri, 09 Oct 2015 08:04:40 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp44098lbq; Fri, 9 Oct 2015 08:04:39 -0700 (PDT) X-Received: by 10.66.66.196 with SMTP id h4mr15754742pat.38.1444403077687; Fri, 09 Oct 2015 08:04:37 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id uh5si3182523pab.115.2015.10.09.08.04.37; Fri, 09 Oct 2015 08:04:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752750AbbJIPEg (ORCPT + 12 others); Fri, 9 Oct 2015 11:04:36 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:36036 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbbJIPEf (ORCPT ); Fri, 9 Oct 2015 11:04:35 -0400 Received: by pablk4 with SMTP id lk4so89173170pab.3 for ; Fri, 09 Oct 2015 08:04:35 -0700 (PDT) X-Received: by 10.68.216.135 with SMTP id oq7mr7837420pbc.9.1444403074940; Fri, 09 Oct 2015 08:04:34 -0700 (PDT) Received: from localhost ([122.171.124.154]) by smtp.gmail.com with ESMTPSA id lo9sm2998861pab.19.2015.10.09.08.04.33 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 09 Oct 2015 08:04:34 -0700 (PDT) From: Viresh Kumar To: Greg Kroah-Hartman Cc: linaro-kernel@lists.linaro.org, Rafael Wysocki , linux-kernel@vger.kernel.org, arnd@arndb.de, sboyd@codeaurora.org, linux-pm@vger.kernel.org, linux@arm.linux.org.uk, stern@rowland.harvard.edu, Viresh Kumar Subject: [PATCH] debugfs: Add debugfs_create_ulong() Date: Fri, 9 Oct 2015 20:34:27 +0530 Message-Id: <3a48d2bb4320bba82f91354d7165c300ef8108bd.1444402709.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.4.0 Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.180 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add debugfs_create_ulong() for the users of type 'unsigned long'. These will be 32 bits long on a 32 bit machine and 64 bits long on a 64 bit machine and so can't use the traditional debugfs_create_u64() or debugfs_create_u32() APIs. Signed-off-by: Viresh Kumar --- Hi Greg, I thought there were few supporters of this interface and I need it for the OPP debugfs stuff. So this is an attempt to move the discussion out of the closed thread, to an open one where others can join. And if all goes well, then you can apply it directly. Its tested with the OPP debugfs stuff :) fs/debugfs/file.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++ include/linux/debugfs.h | 4 ++++ 2 files changed, 59 insertions(+) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index b70c20fae502..28a7fe6ea618 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -251,6 +251,60 @@ struct dentry *debugfs_create_u64(const char *name, umode_t mode, } EXPORT_SYMBOL_GPL(debugfs_create_u64); +static int debugfs_ulong_set(void *data, u64 val) +{ + *(unsigned long *)data = val; + return 0; +} + +static int debugfs_ulong_get(void *data, u64 *val) +{ + *val = *(unsigned long *)data; + return 0; +} +DEFINE_SIMPLE_ATTRIBUTE(fops_ulong, debugfs_ulong_get, debugfs_ulong_set, "%llu\n"); +DEFINE_SIMPLE_ATTRIBUTE(fops_ulong_ro, debugfs_ulong_get, NULL, "%llu\n"); +DEFINE_SIMPLE_ATTRIBUTE(fops_ulong_wo, NULL, debugfs_ulong_set, "%llu\n"); + +/** + * debugfs_create_ulong - create a debugfs file that is used to read and write + * an unsigned long value. + * @name: a pointer to a string containing the name of the file to create. + * @mode: the permission that the file should have + * @parent: a pointer to the parent dentry for this file. This should be a + * directory dentry if set. If this parameter is %NULL, then the + * file will be created in the root of the debugfs filesystem. + * @value: a pointer to the variable that the file should read to and write + * from. + * + * This function creates a file in debugfs with the given name that + * contains the value of the variable @value. If the @mode variable is so + * set, it can be read from, and written to. + * + * This function will return a pointer to a dentry if it succeeds. This + * pointer must be passed to the debugfs_remove() function when the file is + * to be removed (no automatic cleanup happens if your module is unloaded, + * you are responsible here.) If an error occurs, %NULL will be returned. + * + * If debugfs is not enabled in the kernel, the value -%ENODEV will be + * returned. It is not wise to check for this value, but rather, check for + * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling + * code. + */ +struct dentry *debugfs_create_ulong(const char *name, umode_t mode, + struct dentry *parent, unsigned long *value) +{ + /* if there are no write bits set, make read only */ + if (!(mode & S_IWUGO)) + return debugfs_create_file(name, mode, parent, value, &fops_ulong_ro); + /* if there are no read bits set, make write only */ + if (!(mode & S_IRUGO)) + return debugfs_create_file(name, mode, parent, value, &fops_ulong_wo); + + return debugfs_create_file(name, mode, parent, value, &fops_ulong); +} +EXPORT_SYMBOL_GPL(debugfs_create_ulong); + DEFINE_SIMPLE_ATTRIBUTE(fops_x8, debugfs_u8_get, debugfs_u8_set, "0x%02llx\n"); DEFINE_SIMPLE_ATTRIBUTE(fops_x8_ro, debugfs_u8_get, NULL, "0x%02llx\n"); DEFINE_SIMPLE_ATTRIBUTE(fops_x8_wo, NULL, debugfs_u8_set, "0x%02llx\n"); @@ -264,6 +318,7 @@ DEFINE_SIMPLE_ATTRIBUTE(fops_x32_ro, debugfs_u32_get, NULL, "0x%08llx\n"); DEFINE_SIMPLE_ATTRIBUTE(fops_x32_wo, NULL, debugfs_u32_set, "0x%08llx\n"); DEFINE_SIMPLE_ATTRIBUTE(fops_x64, debugfs_u64_get, debugfs_u64_set, "0x%016llx\n"); +DEFINE_SIMPLE_ATTRIBUTE(fops_xlong, debugfs_ulong_get, debugfs_ulong_set, "0x%016llx\n"); /* * debugfs_create_x{8,16,32,64} - create a debugfs file that is used to read and write an unsigned {8,16,32,64}-bit value diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h index 8321fe3058d6..60b150248b54 100644 --- a/include/linux/debugfs.h +++ b/include/linux/debugfs.h @@ -79,6 +79,8 @@ struct dentry *debugfs_create_u32(const char *name, umode_t mode, struct dentry *parent, u32 *value); struct dentry *debugfs_create_u64(const char *name, umode_t mode, struct dentry *parent, u64 *value); +struct dentry *debugfs_create_ulong(const char *name, umode_t mode, + struct dentry *parent, unsigned long *value); struct dentry *debugfs_create_x8(const char *name, umode_t mode, struct dentry *parent, u8 *value); struct dentry *debugfs_create_x16(const char *name, umode_t mode, @@ -87,6 +89,8 @@ struct dentry *debugfs_create_x32(const char *name, umode_t mode, struct dentry *parent, u32 *value); struct dentry *debugfs_create_x64(const char *name, umode_t mode, struct dentry *parent, u64 *value); +struct dentry *debugfs_create_xlong(const char *name, umode_t mode, + struct dentry *parent, unsigned long *value); struct dentry *debugfs_create_size_t(const char *name, umode_t mode, struct dentry *parent, size_t *value); struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,