From patchwork Sun Oct 18 09:15:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 55172 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f200.google.com (mail-wi0-f200.google.com [209.85.212.200]) by patches.linaro.org (Postfix) with ESMTPS id 8ADD622F11 for ; Sun, 18 Oct 2015 09:16:23 +0000 (UTC) Received: by wikv3 with SMTP id v3sf8463910wik.1 for ; Sun, 18 Oct 2015 02:16:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=CzYp2XX8wdxS/DBpfbUiw65HZkuIgFIb3V4m5t5ROV8=; b=ie13SZ5IFZNeItfj2hZRcrzziG0JwlaCixITbegjaEtsPzSZ5Oj2uNoGKjjqlZHasF pp7BjqxCnVK1+OsKMek9sl6zTdgUoSokO9/ooUyJmcKiZndyZzAEtHGTdvJH4YaQnhHf Yq889m6E2A4Bdok4HZ8T872vyF9z6BuiZfQpZTyY7WjxEbiRrH4OytMLCLx+u6LLmwlq hpXV5BUNDKlAQ3gmTwaGtwPp2mHrnLcoRLJla0aQs12TbPIDJ/w3wZEqYGgS4wb4LRzn w6/A+kaDhajQ0JRoQFqCbaW0Un2VtYQnWKc4MTiw6zOM9PnM8xqmHWMZBqOySwt/YGPY h+1g== X-Gm-Message-State: ALoCoQnB1rceM5YgsWXOXuHHBm8G+3FR6Ia4nP3oYUQW+RqrDqNWkCv9XLORLtGLLhBaNe9v394z X-Received: by 10.112.173.170 with SMTP id bl10mr2684511lbc.7.1445159782760; Sun, 18 Oct 2015 02:16:22 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.25.159.212 with SMTP id i203ls478918lfe.61.gmail; Sun, 18 Oct 2015 02:16:22 -0700 (PDT) X-Received: by 10.112.170.70 with SMTP id ak6mr11703109lbc.107.1445159782623; Sun, 18 Oct 2015 02:16:22 -0700 (PDT) Received: from mail-lb0-f169.google.com (mail-lb0-f169.google.com. [209.85.217.169]) by mx.google.com with ESMTPS id o196si18856687lfb.9.2015.10.18.02.16.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Oct 2015 02:16:22 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.169 as permitted sender) client-ip=209.85.217.169; Received: by lbbwb3 with SMTP id wb3so62433103lbb.1 for ; Sun, 18 Oct 2015 02:16:22 -0700 (PDT) X-Received: by 10.112.129.202 with SMTP id ny10mr11799480lbb.112.1445159782030; Sun, 18 Oct 2015 02:16:22 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp870027lbq; Sun, 18 Oct 2015 02:16:20 -0700 (PDT) X-Received: by 10.66.141.42 with SMTP id rl10mr27283588pab.18.1445159780787; Sun, 18 Oct 2015 02:16:20 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id te5si43432730pab.28.2015.10.18.02.16.20; Sun, 18 Oct 2015 02:16:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752265AbbJRJPi (ORCPT + 11 others); Sun, 18 Oct 2015 05:15:38 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:35944 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbbJRJPg (ORCPT ); Sun, 18 Oct 2015 05:15:36 -0400 Received: by pacfv9 with SMTP id fv9so63829218pac.3 for ; Sun, 18 Oct 2015 02:15:36 -0700 (PDT) X-Received: by 10.68.216.135 with SMTP id oq7mr27565486pbc.9.1445159736091; Sun, 18 Oct 2015 02:15:36 -0700 (PDT) Received: from localhost ([120.59.73.188]) by smtp.gmail.com with ESMTPSA id pk2sm30197682pbb.21.2015.10.18.02.15.34 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 18 Oct 2015 02:15:35 -0700 (PDT) From: Viresh Kumar To: Greg Kroah-Hartman Cc: linaro-kernel@lists.linaro.org, Rafael Wysocki , linux-kernel@vger.kernel.org, arnd@arndb.de, sboyd@codeaurora.org, linux-pm@vger.kernel.org, linux@arm.linux.org.uk, stern@rowland.harvard.edu, Viresh Kumar Subject: [PATCH V3] debugfs: Add debugfs_create_ulong() Date: Sun, 18 Oct 2015 14:45:27 +0530 Message-Id: <6d786424835b514b92f847e6f9af21b01244de85.1445159433.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.4.0 Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.169 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add debugfs_create_ulong() for the users of type 'unsigned long'. These will be 32 bits long on a 32 bit machine and 64 bits long on a 64 bit machine. Signed-off-by: Viresh Kumar --- V2->V3: - Rebased over driver-core tree. - Also add missing fops_xlong_ro/wo. fs/debugfs/file.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++++ include/linux/debugfs.h | 4 +++ 2 files changed, 73 insertions(+) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 8450549d54a9..d2f93ceef78c 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -243,6 +243,54 @@ struct dentry *debugfs_create_u64(const char *name, umode_t mode, } EXPORT_SYMBOL_GPL(debugfs_create_u64); +static int debugfs_ulong_set(void *data, u64 val) +{ + *(unsigned long *)data = val; + return 0; +} + +static int debugfs_ulong_get(void *data, u64 *val) +{ + *val = *(unsigned long *)data; + return 0; +} +DEFINE_SIMPLE_ATTRIBUTE(fops_ulong, debugfs_ulong_get, debugfs_ulong_set, "%llu\n"); +DEFINE_SIMPLE_ATTRIBUTE(fops_ulong_ro, debugfs_ulong_get, NULL, "%llu\n"); +DEFINE_SIMPLE_ATTRIBUTE(fops_ulong_wo, NULL, debugfs_ulong_set, "%llu\n"); + +/** + * debugfs_create_ulong - create a debugfs file that is used to read and write + * an unsigned long value. + * @name: a pointer to a string containing the name of the file to create. + * @mode: the permission that the file should have + * @parent: a pointer to the parent dentry for this file. This should be a + * directory dentry if set. If this parameter is %NULL, then the + * file will be created in the root of the debugfs filesystem. + * @value: a pointer to the variable that the file should read to and write + * from. + * + * This function creates a file in debugfs with the given name that + * contains the value of the variable @value. If the @mode variable is so + * set, it can be read from, and written to. + * + * This function will return a pointer to a dentry if it succeeds. This + * pointer must be passed to the debugfs_remove() function when the file is + * to be removed (no automatic cleanup happens if your module is unloaded, + * you are responsible here.) If an error occurs, %NULL will be returned. + * + * If debugfs is not enabled in the kernel, the value -%ENODEV will be + * returned. It is not wise to check for this value, but rather, check for + * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling + * code. + */ +struct dentry *debugfs_create_ulong(const char *name, umode_t mode, + struct dentry *parent, unsigned long *value) +{ + return debugfs_create_mode(name, mode, parent, value, &fops_ulong, + &fops_ulong_ro, &fops_ulong_wo); +} +EXPORT_SYMBOL_GPL(debugfs_create_ulong); + DEFINE_SIMPLE_ATTRIBUTE(fops_x8, debugfs_u8_get, debugfs_u8_set, "0x%02llx\n"); DEFINE_SIMPLE_ATTRIBUTE(fops_x8_ro, debugfs_u8_get, NULL, "0x%02llx\n"); DEFINE_SIMPLE_ATTRIBUTE(fops_x8_wo, NULL, debugfs_u8_set, "0x%02llx\n"); @@ -258,6 +306,9 @@ DEFINE_SIMPLE_ATTRIBUTE(fops_x32_wo, NULL, debugfs_u32_set, "0x%08llx\n"); DEFINE_SIMPLE_ATTRIBUTE(fops_x64, debugfs_u64_get, debugfs_u64_set, "0x%016llx\n"); DEFINE_SIMPLE_ATTRIBUTE(fops_x64_ro, debugfs_u64_get, NULL, "0x%016llx\n"); DEFINE_SIMPLE_ATTRIBUTE(fops_x64_wo, NULL, debugfs_u64_set, "0x%016llx\n"); +DEFINE_SIMPLE_ATTRIBUTE(fops_xlong, debugfs_ulong_get, debugfs_ulong_set, "0x%016llx\n"); +DEFINE_SIMPLE_ATTRIBUTE(fops_xlong_ro, debugfs_ulong_get, NULL, "0x%016llx\n"); +DEFINE_SIMPLE_ATTRIBUTE(fops_xlong_wo, NULL, debugfs_ulong_set, "0x%016llx\n"); /* * debugfs_create_x{8,16,32,64} - create a debugfs file that is used to read and write an unsigned {8,16,32,64}-bit value @@ -339,6 +390,24 @@ struct dentry *debugfs_create_x64(const char *name, umode_t mode, } EXPORT_SYMBOL_GPL(debugfs_create_x64); +/** + * debugfs_create_xlong - create a debugfs file that is used to read and write an unsigned long value + * @name: a pointer to a string containing the name of the file to create. + * @mode: the permission that the file should have + * @parent: a pointer to the parent dentry for this file. This should be a + * directory dentry if set. If this parameter is %NULL, then the + * file will be created in the root of the debugfs filesystem. + * @value: a pointer to the variable that the file should read to and write + * from. + */ +struct dentry *debugfs_create_xlong(const char *name, umode_t mode, + struct dentry *parent, unsigned long *value) +{ + return debugfs_create_mode(name, mode, parent, value, &fops_xlong, + &fops_xlong_ro, &fops_xlong_wo); +} +EXPORT_SYMBOL_GPL(debugfs_create_xlong); + static int debugfs_size_t_set(void *data, u64 val) { diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h index 8321fe3058d6..60b150248b54 100644 --- a/include/linux/debugfs.h +++ b/include/linux/debugfs.h @@ -79,6 +79,8 @@ struct dentry *debugfs_create_u32(const char *name, umode_t mode, struct dentry *parent, u32 *value); struct dentry *debugfs_create_u64(const char *name, umode_t mode, struct dentry *parent, u64 *value); +struct dentry *debugfs_create_ulong(const char *name, umode_t mode, + struct dentry *parent, unsigned long *value); struct dentry *debugfs_create_x8(const char *name, umode_t mode, struct dentry *parent, u8 *value); struct dentry *debugfs_create_x16(const char *name, umode_t mode, @@ -87,6 +89,8 @@ struct dentry *debugfs_create_x32(const char *name, umode_t mode, struct dentry *parent, u32 *value); struct dentry *debugfs_create_x64(const char *name, umode_t mode, struct dentry *parent, u64 *value); +struct dentry *debugfs_create_xlong(const char *name, umode_t mode, + struct dentry *parent, unsigned long *value); struct dentry *debugfs_create_size_t(const char *name, umode_t mode, struct dentry *parent, size_t *value); struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,