From patchwork Wed Jan 29 18:00:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Pitre X-Patchwork-Id: 23896 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yk0-f199.google.com (mail-yk0-f199.google.com [209.85.160.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D4E7E202FA for ; Wed, 29 Jan 2014 18:01:31 +0000 (UTC) Received: by mail-yk0-f199.google.com with SMTP id 142sf10877744ykq.2 for ; Wed, 29 Jan 2014 10:01:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:subject:in-reply-to :message-id:references:user-agent:mime-version:cc:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=2uNANVCzeeh1nr6G2dCyYJM2b1gO18//CgMnG4FYWsk=; b=iAcgAOCsULnwCloXha6yFfTyvi6V9cECw4OG6rLQpHdv85hgg1ZpvrqEWsQCSjmmam iuSezkvCaReg9AXd4wyhe4m60VbmuhISGY8KYA76gKhQDVRTLuJ290liK6hazKtyVL/G 7SRMwmNIqghOj2w2s+muVrmuRzWCqo6GkJEyEeFCLRZK1ipbebuDSQ/w73puqg4ko7KP AGYdah9V9E/L/2eo3y26OAVBJ1nuhT1BX4JPTy99TJZOjkH2jUDSFkgMlyAkBYU6lMRA zUNIWj30lxe1x+BSQMHzvSZOk2Ehh/ScGfqiNOOY9DOCILezGbls49Da1lvaWUkiUNC+ Ng8g== X-Gm-Message-State: ALoCoQmjJzJqPCG7FyL+39hcT0PpJEOaoZBBIyPo1qwzDkfzI0qDQjz4hwc+bzAh3dx0Vc9w9+3p X-Received: by 10.58.155.36 with SMTP id vt4mr2333875veb.31.1391018490857; Wed, 29 Jan 2014 10:01:30 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.109.137 with SMTP id l9ls276807qgf.40.gmail; Wed, 29 Jan 2014 10:01:30 -0800 (PST) X-Received: by 10.58.123.70 with SMTP id ly6mr2098027veb.26.1391018490691; Wed, 29 Jan 2014 10:01:30 -0800 (PST) Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com [209.85.220.181]) by mx.google.com with ESMTPS id gq1si1021763vec.137.2014.01.29.10.01.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 29 Jan 2014 10:01:30 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.181; Received: by mail-vc0-f181.google.com with SMTP id ie18so1358990vcb.26 for ; Wed, 29 Jan 2014 10:01:30 -0800 (PST) X-Received: by 10.58.208.130 with SMTP id me2mr7865441vec.13.1391018490597; Wed, 29 Jan 2014 10:01:30 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp133707vcz; Wed, 29 Jan 2014 10:01:29 -0800 (PST) X-Received: by 10.180.97.37 with SMTP id dx5mr6571169wib.53.1391018488687; Wed, 29 Jan 2014 10:01:28 -0800 (PST) Received: from casper.infradead.org (casper.infradead.org. [2001:770:15f::2]) by mx.google.com with ESMTPS id b8si1605051wjy.34.2014.01.29.10.01.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jan 2014 10:01:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:770:15f::2 as permitted sender) client-ip=2001:770:15f::2; Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1W8ZRq-0006yW-BR; Wed, 29 Jan 2014 18:01:14 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1W8ZRo-0004Oa-29; Wed, 29 Jan 2014 18:01:12 +0000 Received: from mail-qc0-f173.google.com ([209.85.216.173]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1W8ZRl-0004N5-4a for linux-arm-kernel@lists.infradead.org; Wed, 29 Jan 2014 18:01:09 +0000 Received: by mail-qc0-f173.google.com with SMTP id i8so3258413qcq.18 for ; Wed, 29 Jan 2014 10:00:47 -0800 (PST) X-Received: by 10.140.89.241 with SMTP id v104mr13804750qgd.27.1391018447544; Wed, 29 Jan 2014 10:00:47 -0800 (PST) Received: from xanadu.home (modemcable177.143-130-66.mc.videotron.ca. [66.130.143.177]) by mx.google.com with ESMTPSA id z1sm8712315qaz.18.2014.01.29.10.00.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 29 Jan 2014 10:00:47 -0800 (PST) Date: Wed, 29 Jan 2014 13:00:45 -0500 (EST) From: Nicolas Pitre To: Catalin Marinas Subject: Re: [PATCH 2/9] ARM64: get rid of arch_cpu_idle_prepare() In-Reply-To: <20140127155755.GH32608@arm.com> Message-ID: References: <1390802904-28399-1-git-send-email-nicolas.pitre@linaro.org> <1390802904-28399-3-git-send-email-nicolas.pitre@linaro.org> <20140127154315.GG32608@arm.com> <20140127155755.GH32608@arm.com> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140129_130109_228983_BF801AAB X-CRM114-Status: GOOD ( 17.29 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.216.173 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: "linaro-kernel@lists.linaro.org" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: nicolas.pitre@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 On Mon, 27 Jan 2014, Catalin Marinas wrote: > On Mon, Jan 27, 2014 at 03:51:02PM +0000, Nicolas Pitre wrote: > > On Mon, 27 Jan 2014, Catalin Marinas wrote: > > > > > For arm64, we could simply remove any reference to FIQs. I'm not aware > > > of anyone using them. > > > > OK. What if I sumply remove arch_cpu_idle_prepare() and let you > > remove the rest? > > > > IMHO I'd simply remove local_fiq_{enable/disable}() from > > arm64/kernel/smp.c and leave the infrastructure in place in case someone > > needs it eventually. In which case I could include that into my patch > > as well. > > Sounds good. We can keep the local_fiq_*() functions but remove about 4 > calling sites (process.c and smp.c) until needed. OK here it is. Please feel free to merge this into your tree directly as it no longer has any dependency issues with other patches. ----- >8 From: Nicolas Pitre Subject: [PATCH] ARM64: FIQs are unused So any FIQ handling is superfluous at the moment. The functions to disable/enable FIQs is kept around if ever someone needs them in the future, but existing calling sites including arch_cpu_idle_prepare() may go for now. Signed-off-by: Nicolas Pitre diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c index de17c89985..adeabe8c6b 100644 --- a/arch/arm64/kernel/process.c +++ b/arch/arm64/kernel/process.c @@ -84,11 +84,6 @@ EXPORT_SYMBOL_GPL(pm_power_off); void (*arm_pm_restart)(enum reboot_mode reboot_mode, const char *cmd); EXPORT_SYMBOL_GPL(arm_pm_restart); -void arch_cpu_idle_prepare(void) -{ - local_fiq_enable(); -} - /* * This is our default idle handler. */ @@ -135,7 +130,6 @@ void machine_restart(char *cmd) /* Disable interrupts first */ local_irq_disable(); - local_fiq_disable(); /* Now call the architecture specific reboot code. */ if (arm_pm_restart) diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index a0c2ca602c..94576c02f5 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -159,7 +159,6 @@ asmlinkage void secondary_start_kernel(void) complete(&cpu_running); local_irq_enable(); - local_fiq_enable(); local_async_enable(); /* @@ -491,7 +490,6 @@ static void ipi_cpu_stop(unsigned int cpu) set_cpu_online(cpu, false); - local_fiq_disable(); local_irq_disable(); while (1)