mbox series

[v4,0/8,v3,0/8] ACPI: Buffer property and reference as string support

Message ID 20220711112606.3050368-1-sakari.ailus@linux.intel.com
Headers show
Series ACPI: Buffer property and reference as string support | expand

Message

Sakari Ailus July 11, 2022, 11:25 a.m. UTC
Hello everyone,

This set adds support for _DSD buffer properties (specified by DSD Guide
<URL:https://github.com/UEFI/DSD-Guide/blob/main/dsd-guide.md>) as well as
support for references as strings. Reference property type was previously
supported for device objects only, whereas string references enable
referencing also _DSD sub-node objects --- also included in the set.

The ACPICA patch has been submitted to upstream but not merged yet.

This set currently prepares for data node string reference support and
does not add it anymore.

since v3:

- Use bool return type for acpi_tie_nondev_subnodes. Return false on
  failure.

- Print ACPI buffer parsing error references as %*pE (was %s).

- Unwrap a few lines (i.e. non-functional changes).

- Declare local variables for acpi_copy_property_array_uint().

- Clean up buffer size check in acpi_data_prop_read(), add break at the
  end of the default case.

since v2:

- Use C99 _Generic() in patch unifying reading integer arrays.

since v1:

- Drop the ACPICA, data node child list initialisation and data node
  string reference patches.

Sakari Ailus (8):
  ACPI: property: Return type of acpi_add_nondev_subnodes() should be
    bool
  ACPI: property: Tie data nodes to acpi handles
  ACPI: property: Use acpi_object_type consistently in property ref
    parsing
  ACPI: property: Move property ref argument parsing into a new function
  ACPI: property: Switch node property referencing from ifs to a switch
  ACPI: property: Unify integer value reading functions
  ACPI: property: Add support for parsing buffer property UUID
  ACPI: property: Read buffer properties as integers

 drivers/acpi/property.c | 465 +++++++++++++++++++++++++++-------------
 include/acpi/acpi_bus.h |   3 +-
 include/linux/acpi.h    |   2 +-
 3 files changed, 318 insertions(+), 152 deletions(-)

Comments

Rafael J. Wysocki July 27, 2022, 7:20 p.m. UTC | #1
On Mon, Jul 11, 2022 at 1:24 PM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> Hello everyone,
>
> This set adds support for _DSD buffer properties (specified by DSD Guide
> <URL:https://github.com/UEFI/DSD-Guide/blob/main/dsd-guide.md>) as well as
> support for references as strings. Reference property type was previously
> supported for device objects only, whereas string references enable
> referencing also _DSD sub-node objects --- also included in the set.
>
> The ACPICA patch has been submitted to upstream but not merged yet.
>
> This set currently prepares for data node string reference support and
> does not add it anymore.
>
> since v3:
>
> - Use bool return type for acpi_tie_nondev_subnodes. Return false on
>   failure.
>
> - Print ACPI buffer parsing error references as %*pE (was %s).
>
> - Unwrap a few lines (i.e. non-functional changes).
>
> - Declare local variables for acpi_copy_property_array_uint().
>
> - Clean up buffer size check in acpi_data_prop_read(), add break at the
>   end of the default case.
>
> since v2:
>
> - Use C99 _Generic() in patch unifying reading integer arrays.
>
> since v1:
>
> - Drop the ACPICA, data node child list initialisation and data node
>   string reference patches.
>
> Sakari Ailus (8):
>   ACPI: property: Return type of acpi_add_nondev_subnodes() should be
>     bool
>   ACPI: property: Tie data nodes to acpi handles
>   ACPI: property: Use acpi_object_type consistently in property ref
>     parsing
>   ACPI: property: Move property ref argument parsing into a new function
>   ACPI: property: Switch node property referencing from ifs to a switch
>   ACPI: property: Unify integer value reading functions
>   ACPI: property: Add support for parsing buffer property UUID
>   ACPI: property: Read buffer properties as integers
>
>  drivers/acpi/property.c | 465 +++++++++++++++++++++++++++-------------
>  include/acpi/acpi_bus.h |   3 +-
>  include/linux/acpi.h    |   2 +-
>  3 files changed, 318 insertions(+), 152 deletions(-)
>
> --

The series (including the update of patch [7/8]) has been applied as
5.20 material, thanks!
Sakari Ailus July 27, 2022, 7:35 p.m. UTC | #2
On Wed, Jul 27, 2022 at 09:20:15PM +0200, Rafael J. Wysocki wrote:
> >  drivers/acpi/property.c | 465 +++++++++++++++++++++++++++-------------
> >  include/acpi/acpi_bus.h |   3 +-
> >  include/linux/acpi.h    |   2 +-
> >  3 files changed, 318 insertions(+), 152 deletions(-)
> >
> > --
> 
> The series (including the update of patch [7/8]) has been applied as
> 5.20 material, thanks!

Thank you!

Thanks to Andy for reviews, too!