From patchwork Wed Apr 9 15:14:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Nowicki X-Patchwork-Id: 28093 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f69.google.com (mail-yh0-f69.google.com [209.85.213.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 66EDA2145B for ; Wed, 9 Apr 2014 15:15:00 +0000 (UTC) Received: by mail-yh0-f69.google.com with SMTP id b6sf8002942yha.0 for ; Wed, 09 Apr 2014 08:15:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=oUgUUttF0eHIknNUm1hzcVjQIHOwG1NTBMMi7XMIvYg=; b=Nd0XBjYQTzf8SEIUyXtdzTfKEBnCSXq4KyCu94C+RIjgYrFK2DG7usvh9BrHnmWbBk 08GqSQ0VQhGPN+UsJwn2oZayaBVBszZ4kBY+p5sYsYzbA0jF/FZGmioFN9/FrTPXknS4 qpTieler4eC579OUre6re8pCK4b5iJ2zOUX+24HWG0GDwDq1MRnGQVlKYiahPZMgzpv2 lYTdC/SVqcN3/cSiT6IVnCrge8Uv3cCpZk6sQmcjP217+6loUKJQfmP1qH062Ogzx8/k loGSlj7yHLop1Ts92j2sI3axFrlT3SpLyS85re4FSIVsKvMZHJA789XQnTEHAJhS55Fk FFgw== X-Gm-Message-State: ALoCoQn9rUArwQHflSQ5xusWh1Xf4xF7DmGmxoDzIvImDLmRCkSvM18wmmmE9iejGXifZjeFSJ7U X-Received: by 10.236.142.212 with SMTP id i60mr4006684yhj.39.1397056500199; Wed, 09 Apr 2014 08:15:00 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.22.75 with SMTP id 69ls697573qgm.94.gmail; Wed, 09 Apr 2014 08:15:00 -0700 (PDT) X-Received: by 10.52.138.112 with SMTP id qp16mr862121vdb.40.1397056499979; Wed, 09 Apr 2014 08:14:59 -0700 (PDT) Received: from mail-ve0-f174.google.com (mail-ve0-f174.google.com [209.85.128.174]) by mx.google.com with ESMTPS id tm8si181573vdc.170.2014.04.09.08.14.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 09 Apr 2014 08:14:59 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.174; Received: by mail-ve0-f174.google.com with SMTP id oz11so2166092veb.5 for ; Wed, 09 Apr 2014 08:14:59 -0700 (PDT) X-Received: by 10.52.18.68 with SMTP id u4mr830366vdd.58.1397056499896; Wed, 09 Apr 2014 08:14:59 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.12.8 with SMTP id v8csp338152vcv; Wed, 9 Apr 2014 08:14:59 -0700 (PDT) X-Received: by 10.66.65.204 with SMTP id z12mr12923136pas.60.1397056499073; Wed, 09 Apr 2014 08:14:59 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j4si629389pad.104.2014.04.09.08.14.58; Wed, 09 Apr 2014 08:14:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-acpi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964824AbaDIPO3 (ORCPT + 8 others); Wed, 9 Apr 2014 11:14:29 -0400 Received: from mail-ee0-f43.google.com ([74.125.83.43]:63977 "EHLO mail-ee0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933891AbaDIPO0 (ORCPT ); Wed, 9 Apr 2014 11:14:26 -0400 Received: by mail-ee0-f43.google.com with SMTP id e53so2025066eek.30 for ; Wed, 09 Apr 2014 08:14:25 -0700 (PDT) X-Received: by 10.14.7.137 with SMTP id 9mr116935eep.114.1397056464973; Wed, 09 Apr 2014 08:14:24 -0700 (PDT) Received: from tn-HP3-PC.semihalf.com ([80.82.22.190]) by mx.google.com with ESMTPSA id x46sm2326082een.17.2014.04.09.08.14.23 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 09 Apr 2014 08:14:24 -0700 (PDT) From: Tomasz Nowicki To: rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com, bp@alien8.de, bp@suse.de, m.chehab@samsung.com Cc: linux-edac@vger.kernel.org, x86@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, Tomasz Nowicki Subject: [PATCH 4/7] acpi, apei, ghes: Factor out NMI error notification context. Date: Wed, 9 Apr 2014 17:14:32 +0200 Message-Id: <1397056476-9183-5-git-send-email-tomasz.nowicki@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1397056476-9183-1-git-send-email-tomasz.nowicki@linaro.org> References: <1397056476-9183-1-git-send-email-tomasz.nowicki@linaro.org> Sender: linux-acpi-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: tomasz.nowicki@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Use CONFIG_ACPI_APEI_NMI to isolate NMI error notification path. NMI related data and functions are grouped so they can be wrapped inside one Signed-off-by: Tomasz Nowicki --- drivers/acpi/apei/ghes.c | 54 +++++++++++++++++++++++++--------------------- 1 file changed, 30 insertions(+), 24 deletions(-) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index ca8387e..7a0d66e 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -53,7 +53,9 @@ #include #endif #include +#ifdef CONFIG_ACPI_APEI_NMI #include +#endif #include "apei-internal.h" @@ -88,8 +90,6 @@ bool ghes_disable; module_param_named(disable, ghes_disable, bool, 0); -static int ghes_panic_timeout __read_mostly = 30; - /* * All error sources notified with SCI shares one notifier function, * so they need to be linked and checked one by one. This is applied @@ -99,16 +99,9 @@ static int ghes_panic_timeout __read_mostly = 30; * list changing, not for traversing. */ static LIST_HEAD(ghes_sci); -static LIST_HEAD(ghes_nmi); static DEFINE_MUTEX(ghes_list_mutex); /* - * NMI may be triggered on any CPU, so ghes_nmi_lock is used for - * mutual exclusion. - */ -static DEFINE_RAW_SPINLOCK(ghes_nmi_lock); - -/* * Because the memory area used to transfer hardware error information * from BIOS to Linux can be determined only in NMI, IRQ or timer * handler, but general ioremap can not be used in atomic context, so @@ -132,18 +125,8 @@ static struct vm_struct *ghes_ioremap_area; static DEFINE_RAW_SPINLOCK(ghes_ioremap_lock_nmi); static DEFINE_SPINLOCK(ghes_ioremap_lock_irq); -/* - * printk is not safe in NMI context. So in NMI handler, we allocate - * required memory from lock-less memory allocator - * (ghes_estatus_pool), save estatus into it, put them into lock-less - * list (ghes_estatus_llist), then delay printk into IRQ context via - * irq_work (ghes_proc_irq_work). ghes_estatus_size_request record - * required pool size by all NMI error source. - */ static struct gen_pool *ghes_estatus_pool; static unsigned long ghes_estatus_pool_size_request; -static struct llist_head ghes_estatus_llist; -static struct irq_work ghes_proc_irq_work; struct ghes_estatus_cache *ghes_estatus_caches[GHES_ESTATUS_CACHES_SIZE]; static atomic_t ghes_estatus_cache_alloced; @@ -259,11 +242,6 @@ static int ghes_estatus_pool_expand(unsigned long len) return 0; } -static void ghes_estatus_pool_shrink(unsigned long len) -{ - ghes_estatus_pool_size_request -= PAGE_ALIGN(len); -} - static struct ghes *ghes_new(struct acpi_hest_generic *generic) { struct ghes *ghes; @@ -744,6 +722,28 @@ static int ghes_notify_sci(struct notifier_block *this, return ret; } +#ifdef CONFIG_ACPI_APEI_NMI +/* + * printk is not safe in NMI context. So in NMI handler, we allocate + * required memory from lock-less memory allocator + * (ghes_estatus_pool), save estatus into it, put them into lock-less + * list (ghes_estatus_llist), then delay printk into IRQ context via + * irq_work (ghes_proc_irq_work). ghes_estatus_size_request record + * required pool size by all NMI error source. + */ +static struct llist_head ghes_estatus_llist; +static struct irq_work ghes_proc_irq_work; + +/* + * NMI may be triggered on any CPU, so ghes_nmi_lock is used for + * mutual exclusion. + */ +static DEFINE_RAW_SPINLOCK(ghes_nmi_lock); + +static LIST_HEAD(ghes_nmi); + +static int ghes_panic_timeout __read_mostly = 30; + static struct llist_node *llist_nodes_reverse(struct llist_node *llnode) { struct llist_node *next, *tail = NULL; @@ -902,6 +902,12 @@ static unsigned long ghes_esource_prealloc_size( return prealloc_size; } +static void ghes_estatus_pool_shrink(unsigned long len) +{ + ghes_estatus_pool_size_request -= PAGE_ALIGN(len); +} +#endif + static int ghes_notify_init_nmi(struct ghes *ghes) { unsigned long len;