From patchwork Mon Jun 22 12:05:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiju Jose X-Patchwork-Id: 191319 Delivered-To: patch@linaro.org Received: by 2002:a54:3249:0:0:0:0:0 with SMTP id g9csp134370ecs; Mon, 22 Jun 2020 05:07:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAQJ39TM9is+PVpLT6WL2mEXd0ipDKDjIACfKKm9KlJURkDYcNbwreuL3QlhGhGIBnnOr2 X-Received: by 2002:a05:6402:787:: with SMTP id d7mr1101164edy.46.1592827664772; Mon, 22 Jun 2020 05:07:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592827664; cv=none; d=google.com; s=arc-20160816; b=NAICbH5Jpz9DTvrhI0XhUfOxp+weHii7omY3NxW/AY2l5XM8/Cs8dzCQG14EcWUtfa Xf0qGb4ESVShzNd54VQu7u4FBoJ+1O/L9CJbr8s0KNHUJW7f3/i1p3ESI4Bxee4o3+OU RDLuKlEmmGBx7wcPJTAMSwr/j3EtzHEnsetJNMLnsJDMq69D5MHUQs8NIYIDuKDxdsTT AkjBaL4TPQ6brsJ7ISXjp4YxqHTGZ7E1NmFB7U9ZOIb0rGLw8YbiUvxVODddNLJE/gn+ CFh6SGeBRfeKT7qCmiQQJrf8x5pP5N2noBWjGjkD3MjQ3hXLb9K8aCZ3p3eR7HDs6kwC WMwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=+pa0u3REDK0TsqXNhOdxqONBqiRU/iZU21lROkMdEMg=; b=YSQSbKOmcrCa9wt0jBqcpNf+7WfHZS/IS/xavrD4n4NZnHCw7ApDsh8eMYFNUDrW/0 PmGJSQygdMCXSGPZS0v320JTf82q29ES8aR7UsmPUUgNnMSRlnwVMcBH5a0o2FHiODGC WK5vQ2w5ZdCxXc9dlyejMow392Cz9HvKoIGHbEO9Utm/QFBxyvyAQgqkWh3lhRCb2AHV 4XuVlwPBAPE2Bp4ohDrbiE9s0aSBnMVlM/FrQkvNDQ+Gr7KQ2aL9Q5d8jAMIQNVa2BhQ dom+m581ODML0Kp9ZF1Nmb9XRKdq2FZAVDGwi5PL9LoPBEtkGAHgHhPF+4Bihw7LtnAO GLIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-acpi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-acpi-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f18si8596360ejx.476.2020.06.22.05.07.44; Mon, 22 Jun 2020 05:07:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-acpi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-acpi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-acpi-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728132AbgFVMHh (ORCPT + 7 others); Mon, 22 Jun 2020 08:07:37 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:2353 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726889AbgFVMHg (ORCPT ); Mon, 22 Jun 2020 08:07:36 -0400 Received: from lhreml715-chm.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 6F542F674EA362ED9CCC; Mon, 22 Jun 2020 13:07:35 +0100 (IST) Received: from DESKTOP-6T4S3DQ.china.huawei.com (10.47.81.228) by lhreml715-chm.china.huawei.com (10.201.108.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1913.5; Mon, 22 Jun 2020 13:07:34 +0100 From: Shiju Jose To: , , , , , , , , , , , , , CC: , , , Subject: [PATCH v11 1/2] ACPI / APEI: Add a notifier chain for unknown (vendor) CPER records Date: Mon, 22 Jun 2020 13:05:26 +0100 Message-ID: <20200622120527.690-2-shiju.jose@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20200622120527.690-1-shiju.jose@huawei.com> References: <20200622120527.690-1-shiju.jose@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.47.81.228] X-ClientProxiedBy: lhreml706-chm.china.huawei.com (10.201.108.55) To lhreml715-chm.china.huawei.com (10.201.108.66) X-CFilter-Loop: Reflected Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org CPER records describing a firmware-first error are identified by GUID. The ghes driver currently logs, but ignores any unknown CPER records. This prevents describing errors that can't be represented by a standard entry, that would otherwise allow a driver to recover from an error. The UEFI spec calls these 'Non-standard Section Body' (N.2.3 of version 2.8). Add a notifier chain for these non-standard/vendor-records. Callers must identify their type of records by GUID. Record data is copied to memory from the ghes_estatus_pool to allow us to keep it until after the notifier has run. Signed-off-by: Shiju Jose [ Removed kfifo and ghes_gdata_pool. Expanded commit message ] Signed-off-by: James Morse --- drivers/acpi/apei/ghes.c | 63 ++++++++++++++++++++++++++++++++++++++++ include/acpi/ghes.h | 27 +++++++++++++++++ 2 files changed, 90 insertions(+) -- 2.17.1 diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index 81bf71b10d44..99df00f64306 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -79,6 +79,12 @@ ((struct acpi_hest_generic_status *) \ ((struct ghes_estatus_node *)(estatus_node) + 1)) +#define GHES_VENDOR_ENTRY_LEN(gdata_len) \ + (sizeof(struct ghes_vendor_record_entry) + (gdata_len)) +#define GHES_GDATA_FROM_VENDOR_ENTRY(vendor_entry) \ + ((struct acpi_hest_generic_data *) \ + ((struct ghes_vendor_record_entry *)(vendor_entry) + 1)) + /* * NMI-like notifications vary by architecture, before the compiler can prune * unused static functions it needs a value for these enums. @@ -123,6 +129,12 @@ static DEFINE_MUTEX(ghes_list_mutex); */ static DEFINE_SPINLOCK(ghes_notify_lock_irq); +struct ghes_vendor_record_entry { + struct work_struct work; + int error_severity; + char vendor_record[]; +}; + static struct gen_pool *ghes_estatus_pool; static unsigned long ghes_estatus_pool_size_request; @@ -511,6 +523,56 @@ static void ghes_handle_aer(struct acpi_hest_generic_data *gdata) #endif } +static BLOCKING_NOTIFIER_HEAD(vendor_record_notify_list); + +int ghes_register_vendor_record_notifier(struct notifier_block *nb) +{ + return blocking_notifier_chain_register(&vendor_record_notify_list, nb); +} +EXPORT_SYMBOL_GPL(ghes_register_vendor_record_notifier); + +void ghes_unregister_vendor_record_notifier(struct notifier_block *nb) +{ + blocking_notifier_chain_unregister(&vendor_record_notify_list, nb); +} +EXPORT_SYMBOL_GPL(ghes_unregister_vendor_record_notifier); + +static void ghes_vendor_record_work_func(struct work_struct *work) +{ + struct ghes_vendor_record_entry *entry; + struct acpi_hest_generic_data *gdata; + u32 len; + + entry = container_of(work, struct ghes_vendor_record_entry, work); + gdata = GHES_GDATA_FROM_VENDOR_ENTRY(entry); + + blocking_notifier_call_chain(&vendor_record_notify_list, + entry->error_severity, gdata); + + len = GHES_VENDOR_ENTRY_LEN(acpi_hest_get_record_size(gdata)); + gen_pool_free(ghes_estatus_pool, (unsigned long)entry, len); +} + +static void ghes_defer_non_standard_event(struct acpi_hest_generic_data *gdata, + int sev) +{ + struct acpi_hest_generic_data *copied_gdata; + struct ghes_vendor_record_entry *entry; + u32 len; + + len = GHES_VENDOR_ENTRY_LEN(acpi_hest_get_record_size(gdata)); + entry = (void *)gen_pool_alloc(ghes_estatus_pool, len); + if (!entry) + return; + + copied_gdata = GHES_GDATA_FROM_VENDOR_ENTRY(entry); + memcpy(copied_gdata, gdata, acpi_hest_get_record_size(gdata)); + entry->error_severity = sev; + + INIT_WORK(&entry->work, ghes_vendor_record_work_func); + schedule_work(&entry->work); +} + static bool ghes_do_proc(struct ghes *ghes, const struct acpi_hest_generic_status *estatus) { @@ -549,6 +611,7 @@ static bool ghes_do_proc(struct ghes *ghes, } else { void *err = acpi_hest_get_payload(gdata); + ghes_defer_non_standard_event(gdata, sev); log_non_standard_event(sec_type, fru_id, fru_text, sec_sev, err, gdata->error_data_length); diff --git a/include/acpi/ghes.h b/include/acpi/ghes.h index 517a5231cc1b..ae0e8847fdd5 100644 --- a/include/acpi/ghes.h +++ b/include/acpi/ghes.h @@ -53,6 +53,33 @@ enum { GHES_SEV_PANIC = 0x3, }; +#ifdef CONFIG_ACPI_APEI_GHES +/** + * ghes_register_vendor_record_notifier - register a notifier for vendor + * records that the kernel would otherwise ignore. + * @nb: pointer to the notifier_block structure of the event handler. + * + * return 0 : SUCCESS, non-zero : FAIL + */ +int ghes_register_vendor_record_notifier(struct notifier_block *nb); + +/** + * ghes_unregister_vendor_record_notifier - unregister the previously + * registered vendor record notifier. + * @nb: pointer to the notifier_block structure of the vendor record handler. + */ +void ghes_unregister_vendor_record_notifier(struct notifier_block *nb); +#else +static inline int ghes_register_vendor_record_notifier(struct notifier_block *nb) +{ + return -ENODEV; +} + +static inline void ghes_unregister_vendor_record_notifier(struct notifier_block *nb) +{ +} +#endif + int ghes_estatus_pool_init(int num_ghes); /* From drivers/edac/ghes_edac.c */