| Message ID | 1484657084-26227-1-git-send-email-m.szyprowski@samsung.com |
|---|---|
| Headers | show |
| Series | Move pad retention control to Exynos pin controller driver | expand |
On Tue, Jan 17, 2017 at 01:44:37PM +0100, Marek Szyprowski wrote: > Return proper error code in case of memory allocation failure. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks for fixing. Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Tue, Jan 17, 2017 at 01:44:40PM +0100, Marek Szyprowski wrote: > Replace custom code with generic helper. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > Acked-by: Tomasz Figa <tomasz.figa@gmail.com> > --- > drivers/pinctrl/samsung/pinctrl-samsung.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Tue, Jan 17, 2017 at 01:44:43PM +0100, Marek Szyprowski wrote: > This patch moves pad retention control from S5PV210 machine code to > Exynos pin controller driver. This helps to avoid possible ordering > and logical dependencies between machine and pin control code. Till > now it worked fine only because sys_ops for machine code and pin > controller were called in registration order. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm/mach-s5pv210/pm.c | 7 ---- > arch/arm/mach-s5pv210/regs-clock.h | 4 --- For mach-s5pv210: Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Tue, Jan 17, 2017 at 1:44 PM, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > This patchset is a follow-up of my work on adding runtime PM support > to Exynos pin controller driver: > http://www.spinics.net/lists/arm-kernel/msg550161.html Nice, once you are done fixing the remaining nits, add Tomasz ACKs and resend as v3 and I will apply it. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Wed, Jan 18, 2017 at 12:39 PM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Tue, Jan 17, 2017 at 1:44 PM, Marek Szyprowski > <m.szyprowski@samsung.com> wrote: > >> This patchset is a follow-up of my work on adding runtime PM support >> to Exynos pin controller driver: >> http://www.spinics.net/lists/arm-kernel/msg550161.html > > Nice, once you are done fixing the remaining nits, add Tomasz ACKs > and resend as v3 and I will apply it. Wait, for the pinctrl patches (and also the commits moving the bits arch/arm -> pintrl) you need the soc changes (mostly: the header). I'll prepare a tag with them but I am still giving some time for review. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hello, This patchset is a follow-up of my work on adding runtime PM support to Exynos pin controller driver: http://www.spinics.net/lists/arm-kernel/msg550161.html Runtime PM support itself needs a bit more discussion, so lets first focus on the prerequisites. In case of Exynos pin controller driver it is a pad retention control. In current code it was handled by machine and PMU code and had no relation to what pin controller driver does. This patch series moves pad retention control to pin controller driver. While implementing it, I also did a little cleanup of both Exynos PMU and pin controller drivers. Exynos PMU driver now provides a convenient function to get PMU regmap from other Exynos drivers. Patch #1 provides a new interface to get Exynos PMU regmap, which is used by the patch #11. Patches 2-10 are additional cleanups to the code I was modyfying. Patches 10-12 implements the move of retention control and patch #13 is another cleanup, which is possible after removing dependency to platform PM code. Patches are based on linux-next from 2017.01.16 with Exynos4415 support removal patch applied: https://lkml.org/lkml/2017/1/14/137 Changelog: v2: - reworked exynos_get_pmu_regmap() function and moved to Exynos PMU driver, now it doesn't depend on driver probe order thus doesn't need to defer probing of pinctrl driver if PMU has not yet been probed - collected Acks, minor fixes according to review comments v1: https://www.spinics.net/lists/arm-kernel/msg554487.html - removed the need to add PMU phandles to all pin controller nodes, so old DTBs are properly supported. This has been achieved by getting PMU regmap from the "exynos-pmu" device of fixed name. - more cleanup in Exynos pin controller driver: added missing entries in DT documentation, removed "memory allocation failed" messages and added initconst annotations. - added support for s5pv210. - reworked retention control code to be simpler and ready for adding Exynos5433 support. v0: http://www.spinics.net/lists/arm-kernel/msg550161.html - initial version - part of "Runtime PM for Exynos pin controller driver" patchset Patch summary: Marek Szyprowski (13): soc: samsung: pmu: Provide global function to get PMU regmap soc: samsung: pmu: Use of_device_get_match_data helper soc: samsung: pmu: Remove messages for failed memory allocation pinctrl: samsung: Document Exynos3250 SoC support pinctrl: samsung: Remove messages for failed memory allocation pinctrl: samsung: Fix samsung_pinctrl_create_functions return value pinctrl: samsung: Add missing initconst annotation pinctrl: samsung: Remove dead code pinctrl: samsung: Use generic of_device_get_match_data helper pinctrl: samsung: Add infrastructure for pin-bank retention control pinctrl: samsung: Move retention control from mach-exynos to the pinctrl driver pinctrl: samsung: Move retention control from mach-s5pv210 to the pinctrl driver pinctrl: samsung: Replace syscore ops with standard platform device pm_ops .../bindings/pinctrl/samsung-pinctrl.txt | 1 + arch/arm/mach-exynos/suspend.c | 64 ------ arch/arm/mach-s5pv210/pm.c | 7 - arch/arm/mach-s5pv210/regs-clock.h | 4 - drivers/pinctrl/samsung/pinctrl-exynos.c | 232 +++++++++++++++++++-- drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 12 +- drivers/pinctrl/samsung/pinctrl-samsung.c | 123 ++++------- drivers/pinctrl/samsung/pinctrl-samsung.h | 42 ++++ drivers/soc/samsung/exynos-pmu.c | 22 +- include/linux/soc/samsung/exynos-pmu.h | 7 + 10 files changed, 320 insertions(+), 194 deletions(-) -- 1.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel