From patchwork Mon Apr 16 23:37:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob X-Patchwork-Id: 7878 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id D2C0A23E1D for ; Mon, 16 Apr 2012 23:37:53 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 90A3BA1846B for ; Mon, 16 Apr 2012 23:37:53 +0000 (UTC) Received: by iage36 with SMTP id e36so11114275iag.11 for ; Mon, 16 Apr 2012 16:37:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=QUp3fDuU0rSr7rP6Q4OXRCV+cJF6XRNy4V4pdjwyBy0=; b=dk88G9oqv3uoJJ1HqNF/tNoVKNKAbLcb8Cp0/FjP2Ory7KgizPCCvPMSl7/l9Uyt8R wvSutXQD4jfgsehd6MshGxOL0CtwkhgUvU7VHt9wu4QHAaQiYJraMllQkdX6KB4PJ6i9 MIoaPP8eGuKZ9IZTeEnL8886oZVrId0tva7vL0KCIMdw4aIYUrpzKsQ8CKC0TRj4aeFn LtIFrJRuHFF6kQKHajNPrREoIwRaJip45PtQW3wnRjHfMRofJoH7EfKq5k30abOytO8D HjAuzwdSYqjFieVupcOQaO8kCDQX+EYb25YPrBxrpXxllhIcaY+XuyV3KtYLJH2Etnte 9q1g== Received: by 10.50.194.163 with SMTP id hx3mr7363419igc.49.1334619473025; Mon, 16 Apr 2012 16:37:53 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.137.198 with SMTP id x6csp112242ibt; Mon, 16 Apr 2012 16:37:52 -0700 (PDT) Received: by 10.60.13.196 with SMTP id j4mr18674282oec.14.1334619472146; Mon, 16 Apr 2012 16:37:52 -0700 (PDT) Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com [209.85.214.178]) by mx.google.com with ESMTPS id rz10si9099352obc.44.2012.04.16.16.37.51 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 Apr 2012 16:37:52 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.214.178 is neither permitted nor denied by best guess record for domain of rob.lee@linaro.org) client-ip=209.85.214.178; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.214.178 is neither permitted nor denied by best guess record for domain of rob.lee@linaro.org) smtp.mail=rob.lee@linaro.org Received: by obfk16 with SMTP id k16so10327987obf.37 for ; Mon, 16 Apr 2012 16:37:51 -0700 (PDT) Received: by 10.182.179.4 with SMTP id dc4mr12231081obc.53.1334619471800; Mon, 16 Apr 2012 16:37:51 -0700 (PDT) Received: from localhost.localdomain ([216.59.27.108]) by mx.google.com with ESMTPS id ch5sm21131259obb.16.2012.04.16.16.37.50 (version=SSLv3 cipher=OTHER); Mon, 16 Apr 2012 16:37:51 -0700 (PDT) From: Robert Lee To: kernel@pengutronix.de Cc: shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org, patches@linaro.org Subject: [PATCH] ARM: imx: Fix imx5 idle logic bug Date: Mon, 16 Apr 2012 18:37:48 -0500 Message-Id: <1334619468-25680-1-git-send-email-rob.lee@linaro.org> X-Mailer: git-send-email 1.7.10 X-Gm-Message-State: ALoCoQnRV8RFLXNYpi5/BNv5l9mDMuQtU+0iZz+yORkVY3CFPWqV9qjDvKK5MLXzevUFiFa79kKS The imx5_idle() check of the tzic_eanble_wake() return value uses incorrect (inverted) logic causing all attempt to idle to fail. Signed-off-by: Robert Lee --- arch/arm/mach-imx/mm-imx5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/mm-imx5.c b/arch/arm/mach-imx/mm-imx5.c index 05250ae..e10f391 100644 --- a/arch/arm/mach-imx/mm-imx5.c +++ b/arch/arm/mach-imx/mm-imx5.c @@ -35,7 +35,7 @@ static void imx5_idle(void) } clk_enable(gpc_dvfs_clk); mx5_cpu_lp_set(WAIT_UNCLOCKED_POWER_OFF); - if (tzic_enable_wake() != 0) + if (!tzic_enable_wake()) cpu_do_idle(); clk_disable(gpc_dvfs_clk); }