From patchwork Tue Feb 4 15:58:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 24124 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f69.google.com (mail-pa0-f69.google.com [209.85.220.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D4857202FA for ; Tue, 4 Feb 2014 16:00:07 +0000 (UTC) Received: by mail-pa0-f69.google.com with SMTP id fa1sf23158234pad.4 for ; Tue, 04 Feb 2014 08:00:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=R9sKcMEvEIM7+c7rKx7N3UgOpQmEoigZS6qU1H/2e7w=; b=LekGfStNvFZr5wTpJhuOM60sJo9tBmESCg0NdmlG5K486TjkcJLaB+6CCEHH8cZEdg PdwzPN5E6eAN+Ju6jUiETYlfRQyqhg1Bq4NXq3Mea+oQ6Z+0njFykIavPrX6cLcW7AmI E54v4zksRyWrDW5eFFET6qv1m4AOFcuLk1z0/QYlFuw46pDH70+PtJzf2YOH5eX/UCNJ EVPyTEklbs5RkibojAZ9o22Ejez4hPf8n5jG+pRa0Spfy0WQONSxLRJ6gTPSISfLu++2 yvi9MiFH60jQovHm5bganMTX32NhM26noG2ks1C3CP3qmZjoMAx7LkxnJ4BzsKvrUkfC wtQQ== X-Gm-Message-State: ALoCoQl/QBWOBcU3/LXEm4/jEP+zL50+WSqQwCKBH0faVoDYd9g1/uufSdG+oi9+7RYGImHrX1uc X-Received: by 10.66.228.67 with SMTP id sg3mr16112821pac.25.1391529603045; Tue, 04 Feb 2014 08:00:03 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.50.171 with SMTP id s40ls2218580qga.17.gmail; Tue, 04 Feb 2014 08:00:02 -0800 (PST) X-Received: by 10.52.108.232 with SMTP id hn8mr5681046vdb.29.1391529602944; Tue, 04 Feb 2014 08:00:02 -0800 (PST) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id os4si1131802vcb.97.2014.02.04.08.00.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Feb 2014 08:00:02 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id ld13so6019699vcb.32 for ; Tue, 04 Feb 2014 08:00:02 -0800 (PST) X-Received: by 10.220.109.1 with SMTP id h1mr9736074vcp.20.1391529602863; Tue, 04 Feb 2014 08:00:02 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp245403vcz; Tue, 4 Feb 2014 08:00:02 -0800 (PST) X-Received: by 10.112.211.233 with SMTP id nf9mr2020738lbc.50.1391529601764; Tue, 04 Feb 2014 08:00:01 -0800 (PST) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx.google.com with ESMTPS id 1si12950612laj.141.2014.02.04.08.00.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Feb 2014 08:00:01 -0800 (PST) Received-SPF: neutral (google.com: 209.85.217.182 is neither permitted nor denied by best guess record for domain of ulf.hansson@linaro.org) client-ip=209.85.217.182; Received: by mail-lb0-f182.google.com with SMTP id w7so6720919lbi.27 for ; Tue, 04 Feb 2014 08:00:01 -0800 (PST) X-Received: by 10.112.181.7 with SMTP id ds7mr62492lbc.93.1391529601111; Tue, 04 Feb 2014 08:00:01 -0800 (PST) Received: from localhost.localdomain (host-95-199-220-119.mobileonline.telia.com. [95.199.220.119]) by mx.google.com with ESMTPSA id dm8sm35906603lad.7.2014.02.04.07.59.58 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Feb 2014 08:00:00 -0800 (PST) From: Ulf Hansson To: Russell King , linux-arm-kernel@lists.infradead.org Cc: Alessandro Rubini , Linus Walleij , Wolfram Sang , Chris Ball , Mark Brown , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, Ulf Hansson Subject: [PATCH 16/17] i2c: nomadik: Remove busy check for transfers at suspend late Date: Tue, 4 Feb 2014 16:58:57 +0100 Message-Id: <1391529538-21685-17-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1391529538-21685-1-git-send-email-ulf.hansson@linaro.org> References: <1391529538-21685-1-git-send-email-ulf.hansson@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ulf.hansson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , We should never be busy performing transfers at suspend late, thus there are no reason to check for it. Cc: Alessandro Rubini Cc: Linus Walleij Cc: Wolfram Sang Signed-off-by: Ulf Hansson --- drivers/i2c/busses/i2c-nomadik.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index eda4f0d..2004eea 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c @@ -179,7 +179,6 @@ struct i2c_nmk_client { * @stop: stop condition. * @xfer_complete: acknowledge completion for a I2C message. * @result: controller propogated result. - * @busy: Busy doing transfer. */ struct nmk_i2c_dev { struct i2c_vendor_data *vendor; @@ -193,7 +192,6 @@ struct nmk_i2c_dev { int stop; struct completion xfer_complete; int result; - bool busy; }; /* controller's abort causes */ @@ -679,8 +677,6 @@ static int nmk_i2c_xfer(struct i2c_adapter *i2c_adap, struct nmk_i2c_dev *dev = i2c_get_adapdata(i2c_adap); int j; - dev->busy = true; - pm_runtime_get_sync(&dev->adev->dev); /* Attempt three times to send the message queue */ @@ -705,8 +701,6 @@ static int nmk_i2c_xfer(struct i2c_adapter *i2c_adap, pm_runtime_put_sync(&dev->adev->dev); - dev->busy = false; - /* return the no. messages processed */ if (status) return status; @@ -896,9 +890,6 @@ static int nmk_i2c_suspend_late(struct device *dev) struct amba_device *adev = to_amba_device(dev); struct nmk_i2c_dev *nmk_i2c = amba_get_drvdata(adev); - if (nmk_i2c->busy) - return -EBUSY; - pinctrl_pm_select_sleep_state(dev); return 0; @@ -1019,7 +1010,6 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id) goto err_no_mem; } dev->vendor = vendor; - dev->busy = false; dev->adev = adev; amba_set_drvdata(adev, dev);