From patchwork Wed Apr 16 15:44:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Pieralisi X-Patchwork-Id: 28498 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yk0-f197.google.com (mail-yk0-f197.google.com [209.85.160.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id DB0502036A for ; Wed, 16 Apr 2014 15:43:29 +0000 (UTC) Received: by mail-yk0-f197.google.com with SMTP id 19sf24520950ykq.8 for ; Wed, 16 Apr 2014 08:43:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=3HLtd8e0hOvM+MLWACDAdFRwUxa7+yeK8DMfQabAkG4=; b=AHaWXwQ6La1RutCIOuEZ71R3XchxjA0cHn3VRsKYQNHukfDvkFLIH9YqeaYdNptiYF BYYZYZzUOtbDk8Z8FztbJCSjL2Iw1aiNfJUwxC31F49T2GxkIZfi2i9ueEpW0y4oXQhd SZkd+zeZqAijkvAcmWdiJC1gYYYq+lBfFlZo8gjJWVVq5938+xQAyfnPWoYeMrfk2dMQ An1pxM1dfZMWdHe0d0fYKdncjZTtKw7/kWxBnLldDRN5po1nTmtMoesJTwUwuC7NzTm9 H4UCSjy1Q09qXqmyDv4vsIo7mGErwL/iRZWBUY9WXkGYyZL17vIFUQqmCrSMvkGRYBul q3rw== X-Gm-Message-State: ALoCoQngMP4PIRknTRoHDCvSHCIdQ/jkyD+U1Zie/x/ZfMB9bQrdZoP+PvoqjYWyRU+UyRkznFS7 X-Received: by 10.236.127.35 with SMTP id c23mr3507653yhi.51.1397663009560; Wed, 16 Apr 2014 08:43:29 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.34.233 with SMTP id l96ls670385qgl.90.gmail; Wed, 16 Apr 2014 08:43:29 -0700 (PDT) X-Received: by 10.58.134.101 with SMTP id pj5mr743799veb.38.1397663009421; Wed, 16 Apr 2014 08:43:29 -0700 (PDT) Received: from mail-ve0-f170.google.com (mail-ve0-f170.google.com [209.85.128.170]) by mx.google.com with ESMTPS id 10si3931804vcu.78.2014.04.16.08.43.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 16 Apr 2014 08:43:29 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.170; Received: by mail-ve0-f170.google.com with SMTP id pa12so11048019veb.15 for ; Wed, 16 Apr 2014 08:43:29 -0700 (PDT) X-Received: by 10.220.159.4 with SMTP id h4mr3541247vcx.1.1397663009317; Wed, 16 Apr 2014 08:43:29 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp322240vcb; Wed, 16 Apr 2014 08:43:28 -0700 (PDT) X-Received: by 10.66.142.170 with SMTP id rx10mr9214288pab.117.1397663008542; Wed, 16 Apr 2014 08:43:28 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id zj1si3585609pbb.237.2014.04.16.08.43.27; Wed, 16 Apr 2014 08:43:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161843AbaDPPnW (ORCPT + 9 others); Wed, 16 Apr 2014 11:43:22 -0400 Received: from service87.mimecast.com ([91.220.42.44]:43605 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161841AbaDPPnP (ORCPT ); Wed, 16 Apr 2014 11:43:15 -0400 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 16 Apr 2014 16:43:13 +0100 Received: from red-moon.cambridge.arm.com ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 16 Apr 2014 16:43:28 +0100 From: Lorenzo Pieralisi To: linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi , Mark Rutland , Sudeep Holla , Catalin Marinas , Charles Garcia Tobin , Nicolas Pitre , Rob Herring , Grant Likely , Peter De Schrijver , Santosh Shilimkar , Daniel Lezcano , Amit Kucheria , Vincent Guittot , Antti Miettinen , Stephen Boyd , Kevin Hilman , Sebastian Capella , Tomasz Figa Subject: [PATCH RFC v2 3/4] drivers: cpuidle: CPU idle ARM64 driver Date: Wed, 16 Apr 2014 16:44:53 +0100 Message-Id: <1397663094-28027-4-git-send-email-lorenzo.pieralisi@arm.com> X-Mailer: git-send-email 1.8.4 In-Reply-To: <1397663094-28027-1-git-send-email-lorenzo.pieralisi@arm.com> References: <1397663094-28027-1-git-send-email-lorenzo.pieralisi@arm.com> X-OriginalArrivalTime: 16 Apr 2014 15:43:28.0071 (UTC) FILETIME=[9C5CA570:01CF598A] X-MC-Unique: 114041616431311101 Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lorenzo.pieralisi@arm.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This patch implements a generic CPU idle driver for ARM64 machines. It relies on the DT idle states infrastructure to initialize idle states count and respective parameters. Current code assumes the driver is managing idle states on all possible CPUs but can be easily generalized to support heterogenous systems and build cpumasks at runtime using MIDRs or DT cpu nodes compatible properties. Suspend back-ends (eg PSCI) must register a suspend initializer with the CPU idle driver so that the suspend backend call can be detected, and the driver code can call the back-end infrastructure to complete the suspend backend initialization. Idle state index 0 is always initialized as a simple wfi state, ie always considered present and functional on all ARM64 platforms. Signed-off-by: Lorenzo Pieralisi --- drivers/cpuidle/Kconfig | 5 ++ drivers/cpuidle/Kconfig.arm64 | 13 ++++ drivers/cpuidle/Makefile | 4 + drivers/cpuidle/cpuidle-arm64.c | 159 ++++++++++++++++++++++++++++++++++++++++ 4 files changed, 181 insertions(+) create mode 100644 drivers/cpuidle/Kconfig.arm64 create mode 100644 drivers/cpuidle/cpuidle-arm64.c diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig index 995654e..0654eb5 100644 --- a/drivers/cpuidle/Kconfig +++ b/drivers/cpuidle/Kconfig @@ -44,6 +44,11 @@ depends on ARM source "drivers/cpuidle/Kconfig.arm" endmenu +menu "ARM64 CPU Idle Drivers" +depends on ARM64 +source "drivers/cpuidle/Kconfig.arm64" +endmenu + menu "POWERPC CPU Idle Drivers" depends on PPC source "drivers/cpuidle/Kconfig.powerpc" diff --git a/drivers/cpuidle/Kconfig.arm64 b/drivers/cpuidle/Kconfig.arm64 new file mode 100644 index 0000000..b83612c --- /dev/null +++ b/drivers/cpuidle/Kconfig.arm64 @@ -0,0 +1,13 @@ +# +# ARM64 CPU Idle drivers +# + +config ARM64_CPUIDLE + bool "Generic ARM64 CPU idle Driver" + select OF_IDLE_STATES + help + Select this to enable generic cpuidle driver for ARM v8. + It provides a generic idle driver whose idle states are configured + at run-time through DT nodes. The CPUidle suspend backend is + initialized by the device tree parsing code on matching the entry + method to the respective CPU operations. diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile index 2fc5139..161a5f2 100644 --- a/drivers/cpuidle/Makefile +++ b/drivers/cpuidle/Makefile @@ -16,6 +16,10 @@ obj-$(CONFIG_ARM_U8500_CPUIDLE) += cpuidle-ux500.o obj-$(CONFIG_ARM_AT91_CPUIDLE) += cpuidle-at91.o ############################################################################### +# ARM64 drivers +obj-$(CONFIG_ARM64_CPUIDLE) += cpuidle-arm64.o + +############################################################################### # POWERPC drivers obj-$(CONFIG_PSERIES_CPUIDLE) += cpuidle-pseries.o obj-$(CONFIG_POWERNV_CPUIDLE) += cpuidle-powernv.o diff --git a/drivers/cpuidle/cpuidle-arm64.c b/drivers/cpuidle/cpuidle-arm64.c new file mode 100644 index 0000000..2cfde6c --- /dev/null +++ b/drivers/cpuidle/cpuidle-arm64.c @@ -0,0 +1,159 @@ +/* + * ARM64 generic CPU idle driver. + * + * Copyright (C) 2014 ARM Ltd. + * Author: Lorenzo Pieralisi + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include +#include +#include +#include +#include +#include + +#include +#include + +#include "of_idle_states.h" + +typedef int (*suspend_init_fn)(struct cpuidle_driver *, + struct device_node *[]); + +struct cpu_suspend_ops { + const char *id; + suspend_init_fn init_fn; +}; + +static const struct cpu_suspend_ops suspend_operations[] __initconst = { + {"arm,psci", psci_dt_register_idle_states}, + {} +}; + +static __init const struct cpu_suspend_ops *get_suspend_ops(const char *str) +{ + int i; + + if (!str) + return NULL; + + for (i = 0; suspend_operations[i].id; i++) + if (!strcmp(suspend_operations[i].id, str)) + return &suspend_operations[i]; + + return NULL; +} + +/* + * arm_enter_idle_state - Programs CPU to enter the specified state + * + * @dev: cpuidle device + * @drv: cpuidle driver + * @idx: state index + * + * Called from the CPUidle framework to program the device to the + * specified target state selected by the governor. + */ +static int arm_enter_idle_state(struct cpuidle_device *dev, + struct cpuidle_driver *drv, int idx) +{ + int ret; + + if (!idx) { + cpu_do_idle(); + return idx; + } + + cpu_pm_enter(); + /* + * Pass idle state index to cpu_suspend which in turn will call + * the CPU ops suspend protocol with idle index as a parameter. + * + * Some states would not require context to be saved and flushed + * to DRAM, so calling cpu_suspend would not be stricly necessary. + * When power domains specifications for ARM CPUs are finalized then + * this code can be optimized to prevent saving registers if not + * needed. + */ + ret = cpu_suspend(idx); + + cpu_pm_exit(); + + return ret ? -1 : idx; +} + +struct cpuidle_driver arm64_idle_driver = { + .name = "arm64_idle", + .owner = THIS_MODULE, +}; + +static struct device_node *state_nodes[CPUIDLE_STATE_MAX] __initdata; + +/* + * arm64_idle_init + * + * Registers the arm64 specific cpuidle driver with the cpuidle + * framework. It relies on core code to parse the idle states + * and initialize them using driver data structures accordingly. + */ +static int __init arm64_idle_init(void) +{ + int i, ret; + const char *entry_method; + struct device_node *idle_states_node; + const struct cpu_suspend_ops *suspend_init; + struct cpuidle_driver *drv = &arm64_idle_driver; + + idle_states_node = of_find_node_by_path("/cpus/idle-states"); + if (!idle_states_node) + return -ENOENT; + + if (of_property_read_string(idle_states_node, "entry-method", + &entry_method)) { + pr_warn(" * %s missing entry-method property\n", + idle_states_node->full_name); + of_node_put(idle_states_node); + return -EOPNOTSUPP; + } + + suspend_init = get_suspend_ops(entry_method); + if (!suspend_init) { + pr_warn("Missing suspend initializer\n"); + of_node_put(idle_states_node); + return -EOPNOTSUPP; + } + + /* + * State at index 0 is standby wfi and considered standard + * on all ARM platforms. If in some platforms simple wfi + * can't be used as "state 0", DT bindings must be implemented + * to work around this issue and allow installing a special + * handler for idle state index 0. + */ + drv->states[0].exit_latency = 1; + drv->states[0].target_residency = 1; + drv->states[0].flags = CPUIDLE_FLAG_TIME_VALID; + strncpy(drv->states[0].name, "ARM WFI", CPUIDLE_NAME_LEN); + strncpy(drv->states[0].desc, "ARM WFI", CPUIDLE_DESC_LEN); + + drv->cpumask = (struct cpumask *) cpu_possible_mask; + /* + * Start at index 1, request idle state nodes to be filled + */ + ret = of_init_idle_driver(drv, state_nodes, 1, true); + if (ret) + return ret; + + if (suspend_init->init_fn(drv, state_nodes)) + return -EOPNOTSUPP; + + for (i = 0; i < drv->state_count; i++) + drv->states[i].enter = arm_enter_idle_state; + + return cpuidle_register(drv, NULL); +} +device_initcall(arm64_idle_init);