From patchwork Mon Apr 21 22:36:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: vkamensky X-Patchwork-Id: 28754 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yk0-f199.google.com (mail-yk0-f199.google.com [209.85.160.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 53C782032B for ; Mon, 21 Apr 2014 22:39:22 +0000 (UTC) Received: by mail-yk0-f199.google.com with SMTP id 200sf13409206ykr.2 for ; Mon, 21 Apr 2014 15:39:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:subject:date:message-id:cc :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list :content-type:content-transfer-encoding; bh=AkmJEbcb1+o9JDBZ3CgGMxQnpf5/p/aNOODw9JVOLqw=; b=gDd4X/HVjGI1Jlq4OqOgVithJQryrj/oT1eSCi+j4AoqfR9o136XY7SRE76p1XS6Py 7KGbgosEGFHcwvPFUo9kroFW5R0BRGC0j7jyEgXjF/rVkNfB5OEWqjYrw6a+1MgQmbnN R+9+36G5Ynw5LJHmjhuOL9Bs7EpFuLJAT1PCAqs69kVO653Ebyf9KMdCWcPDwKrJC4Fr ce2wxFirfYeEjSrYzhkegpl35nu1RzbQhrIUTMUFuGv6w7IPMA28kUc4+p43cg36w48V oadE6K/qbz56BDLC2VcM/K6TAHesCYusE6R55UW2R9aGjzWSiPfhVxvcpp9BrMUIqa6h vg7w== X-Gm-Message-State: ALoCoQnmumqFtjxKDTl7U1uUFCFOvPr4nzxY7VQzscLw9N6i1swFykUfux79WkYJEtdEf49o4slr X-Received: by 10.58.7.134 with SMTP id j6mr21040165vea.29.1398119962038; Mon, 21 Apr 2014 15:39:22 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.104.163 with SMTP id a32ls2513300qgf.73.gmail; Mon, 21 Apr 2014 15:39:21 -0700 (PDT) X-Received: by 10.220.162.6 with SMTP id t6mr34116257vcx.12.1398119961925; Mon, 21 Apr 2014 15:39:21 -0700 (PDT) Received: from mail-ve0-f181.google.com (mail-ve0-f181.google.com [209.85.128.181]) by mx.google.com with ESMTPS id mr9si6496968vec.119.2014.04.21.15.39.21 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 21 Apr 2014 15:39:21 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.181; Received: by mail-ve0-f181.google.com with SMTP id oy12so8399128veb.26 for ; Mon, 21 Apr 2014 15:39:21 -0700 (PDT) X-Received: by 10.58.211.69 with SMTP id na5mr2589159vec.30.1398119961745; Mon, 21 Apr 2014 15:39:21 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp323657vcb; Mon, 21 Apr 2014 15:39:21 -0700 (PDT) X-Received: by 10.140.81.197 with SMTP id f63mr5922320qgd.114.1398119961434; Mon, 21 Apr 2014 15:39:21 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id x7si16004433qaj.48.2014.04.21.15.39.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Apr 2014 15:39:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WcMpd-0000tq-Le; Mon, 21 Apr 2014 22:36:57 +0000 Received: from mail-pd0-f172.google.com ([209.85.192.172]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WcMpb-0000si-DL for linux-arm-kernel@lists.infradead.org; Mon, 21 Apr 2014 22:36:56 +0000 Received: by mail-pd0-f172.google.com with SMTP id p10so4133631pdj.31 for ; Mon, 21 Apr 2014 15:36:29 -0700 (PDT) X-Received: by 10.66.177.168 with SMTP id cr8mr5856388pac.128.1398119788079; Mon, 21 Apr 2014 15:36:28 -0700 (PDT) Received: from kamensky-w530.cisco.com.net (c-24-6-79-41.hsd1.ca.comcast.net. [24.6.79.41]) by mx.google.com with ESMTPSA id ky8sm80344798pbc.64.2014.04.21.15.36.26 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Apr 2014 15:36:27 -0700 (PDT) From: Victor Kamensky To: will.deacon@arm.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM64: disable DCACHE_WORD_ACCESS in big endian case Date: Mon, 21 Apr 2014 15:36:10 -0700 Message-Id: <1398119770-27817-1-git-send-email-victor.kamensky@linaro.org> X-Mailer: git-send-email 1.8.1.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140421_153655_464162_CEB9F902 X-CRM114-Status: GOOD ( 10.11 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.3.2 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.192.172 listed in list.dnswl.org] Cc: catalin.marinas@arm.com, linaro-kernel@lists.linaro.org, Victor Kamensky X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: victor.kamensky@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 If DCACHE_WORD_ACCESS is enabled big endian image failed to boot. commit 7bc13fd33adb9536bd73965cd46bbf7377df097c "arm64: dcache: select DCACHE_WORD_ACCESS for little-endian CPUs" enabled this setting for both big endian and little endian cpus. And code in commit itself seems to be endian agnostic, however other, i.e C, code that sits under DCACHE_WORD_ACCESS seems to be not endian agnostic, I could not figure out where though. Solution is to enable DCACHE_WORD_ACCESS only if little endian mode is enabled (default). Signed-off-by: Victor Kamensky --- arch/arm64/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index e6e4d37..106ac4f 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -13,7 +13,7 @@ config ARM64 select CLONE_BACKWARDS select COMMON_CLK select CPU_PM if (SUSPEND || CPU_IDLE) - select DCACHE_WORD_ACCESS + select DCACHE_WORD_ACCESS if !CPU_BIG_ENDIAN select GENERIC_CLOCKEVENTS select GENERIC_CLOCKEVENTS_BROADCAST if SMP select GENERIC_CPU_AUTOPROBE