From patchwork Wed Aug 6 15:18:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Murali Karicheri X-Patchwork-Id: 34978 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f198.google.com (mail-pd0-f198.google.com [209.85.192.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 00C4B20523 for ; Wed, 6 Aug 2014 15:18:43 +0000 (UTC) Received: by mail-pd0-f198.google.com with SMTP id fp1sf15667457pdb.9 for ; Wed, 06 Aug 2014 08:18:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type; bh=YydJNisekEx1z5f/XzOk8pSyrqLNIqZHGX5iWXiGKMY=; b=MSoIT20fiOPr+G6f8/84iIJQJvs4T1dfUnwprbec6CLERUCThi4xWEOkIcsj3LsaVV Hhopb62PEGvq5UnbwbSJPkLLBDVCzJ/DPZSpKonip3LsM1AZrsAtI6AoQ6MaX3IjDX2W stYYXcFWTPplXzmAVIAK6WCH9kVPOEVx36FQ3B8aUb+YFvYqD0tnMtNRT0aprniMrltf rVz6/lCRdPVxJMI9DbGs9J4pCxMuIwI5fChfL1lJwlm0FyzL17Vyh7n7Tpoh/YtiWHyS F0hrJlejdrD7yYYS+ZQV2IXheEBGrU/13OmyvewoyXzFQZljAZJe2bIIyk8bggvOh5kt ePVw== X-Gm-Message-State: ALoCoQkln+Hpc4/tDMOPkMlbJAzbJuog7+HQvJaZzudvudqKpzexSNzxKzaT2RbE+uVTDh3GOTcs X-Received: by 10.70.44.230 with SMTP id h6mr4418601pdm.7.1407338320943; Wed, 06 Aug 2014 08:18:40 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.83.50 with SMTP id i47ls806763qgd.38.gmail; Wed, 06 Aug 2014 08:18:40 -0700 (PDT) X-Received: by 10.52.249.9 with SMTP id yq9mr9635525vdc.6.1407338320724; Wed, 06 Aug 2014 08:18:40 -0700 (PDT) Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com [209.85.220.181]) by mx.google.com with ESMTPS id qc6si585603vcb.85.2014.08.06.08.18.40 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 06 Aug 2014 08:18:40 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.181 as permitted sender) client-ip=209.85.220.181; Received: by mail-vc0-f181.google.com with SMTP id lf12so4166774vcb.26 for ; Wed, 06 Aug 2014 08:18:40 -0700 (PDT) X-Received: by 10.52.244.138 with SMTP id xg10mr9532421vdc.40.1407338320588; Wed, 06 Aug 2014 08:18:40 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp33358vcb; Wed, 6 Aug 2014 08:18:40 -0700 (PDT) X-Received: by 10.66.173.144 with SMTP id bk16mr12084337pac.34.1407338319649; Wed, 06 Aug 2014 08:18:39 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j15si581761pdm.55.2014.08.06.08.18.39 for ; Wed, 06 Aug 2014 08:18:39 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755547AbaHFPSh (ORCPT + 26 others); Wed, 6 Aug 2014 11:18:37 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:44613 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753240AbaHFPSe (ORCPT ); Wed, 6 Aug 2014 11:18:34 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id s76FI6dV018666; Wed, 6 Aug 2014 10:18:06 -0500 Received: from DLEE70.ent.ti.com (dlemailx.itg.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s76FI5gY004085; Wed, 6 Aug 2014 10:18:05 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.174.1; Wed, 6 Aug 2014 10:18:05 -0500 Received: from localhost.localdomain (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s76FI5gf026455; Wed, 6 Aug 2014 10:18:05 -0500 From: Murali Karicheri To: , , , CC: , Murali Karicheri Subject: [PATCH] PCI: keystone: add a pci quirk to limit mrrs Date: Wed, 6 Aug 2014 11:18:20 -0400 Message-ID: <1407338300-9146-1-git-send-email-m-karicheri2@ti.com> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: m-karicheri2@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.181 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Keystone PCI controller has a limitation that memory read request size must not exceed 256 bytes. This is a hardware limitation and add a quirk to force this limit on all downstream devices by updating mrrs. Signed-off-by: Murali Karicheri --- This applies on top of the Keystone PCI controller patch series at http://thread.gmane.org/gmane.linux.kernel.pci/33523 drivers/pci/host/pci-keystone.c | 40 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c index c1cfaef..541ab24 100644 --- a/drivers/pci/host/pci-keystone.c +++ b/drivers/pci/host/pci-keystone.c @@ -42,8 +42,48 @@ /* DEV_STAT_CTRL */ #define PCIE_CAP_BASE 0x70 +/* PCIE controller device IDs */ +#define PCIE_RC_K2HK 0xb008 +#define PCIE_RC_K2E 0xb009 +#define PCIE_RC_K2L 0xb00a + #define to_keystone_pcie(x) container_of(x, struct keystone_pcie, pp) +static void quirk_limit_mrrs(struct pci_dev *dev) +{ + struct pci_bus *bus = dev->bus; + struct pci_dev *bridge = bus->self; + + if (pci_is_root_bus(bus)) + return; + + /* look for the host bridge */ + while (!pci_is_root_bus(bus)) { + bridge = bus->self; + bus = bus->parent; + } + + if (bridge) { + u16 id; + + /* + * Keystone PCI controller has a h/w limitation of + * 256 bytes maximum read request size. It can't handle + * anything higher than this. So force this limit on + * all downstream devices + */ + pci_read_config_word(bridge, PCI_DEVICE_ID, &id); + if ((id == PCIE_RC_K2HK) || (id == PCIE_RC_K2E) || + (id == PCIE_RC_K2L)) { + if (pcie_get_readrq(dev) > 256) { + pr_info("limiting mrrs to 256\n"); + pcie_set_readrq(dev, 256); + } + } + } +} +DECLARE_PCI_FIXUP_FINAL(PCI_ANY_ID, PCI_ANY_ID, quirk_limit_mrrs); + static int ks_pcie_establish_link(struct keystone_pcie *ks_pcie) { struct pcie_port *pp = &ks_pcie->pp;